You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by or...@apache.org on 2023/03/28 15:01:14 UTC
[camel] 01/02: CAMEL-15105: use final fields when possible
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
commit 7a2bcc68738ff17bf8e1b8d4d663d349096133f0
Author: Otavio Rodolfo Piske <an...@gmail.com>
AuthorDate: Tue Mar 28 15:03:41 2023 +0200
CAMEL-15105: use final fields when possible
---
.../java/org/apache/camel/impl/engine/AbstractCamelContext.java | 2 +-
.../apache/camel/impl/engine/DefaultCamelContextExtension.java | 8 ++------
2 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/AbstractCamelContext.java b/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/AbstractCamelContext.java
index d93243898b8..a0fbec6fba9 100644
--- a/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/AbstractCamelContext.java
+++ b/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/AbstractCamelContext.java
@@ -282,7 +282,7 @@ public abstract class AbstractCamelContext extends BaseService
private volatile RestConfiguration restConfiguration;
private volatile VaultConfiguration vaultConfiguration = new VaultConfiguration();
- private List<RoutePolicyFactory> routePolicyFactories = new ArrayList<>();
+ private final List<RoutePolicyFactory> routePolicyFactories = new ArrayList<>();
// special flags to control the first startup which can are special
private volatile boolean firstStartDone;
private volatile boolean doNotStartRoutesOnFirstStart;
diff --git a/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/DefaultCamelContextExtension.java b/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/DefaultCamelContextExtension.java
index 736b8d39dff..2e739885ad3 100644
--- a/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/DefaultCamelContextExtension.java
+++ b/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/DefaultCamelContextExtension.java
@@ -105,9 +105,9 @@ class DefaultCamelContextExtension implements ExtendedCamelContext {
private final AbstractCamelContext camelContext;
private final ThreadLocal<Boolean> isSetupRoutes = new ThreadLocal<>();
- private List<InterceptStrategy> interceptStrategies = new ArrayList<>();
+ private final List<InterceptStrategy> interceptStrategies = new ArrayList<>();
private final Map<String, FactoryFinder> factories = new ConcurrentHashMap<>();
- private Set<LogListener> logListeners;
+ private final Set<LogListener> logListeners = new LinkedHashSet<>();
private volatile String description;
@Deprecated
private ErrorHandlerFactory errorHandlerFactory;
@@ -408,10 +408,6 @@ class DefaultCamelContextExtension implements ExtendedCamelContext {
@Override
public void addLogListener(LogListener listener) {
- if (logListeners == null) {
- logListeners = new LinkedHashSet<>();
- }
-
// avoid adding double which can happen with spring xml on spring boot
logListeners.add(listener);
}