You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/12/18 23:22:08 UTC

[GitHub] codecov-io commented on issue #6524: [SIP 6] Querycontext improvement

codecov-io commented on issue #6524: [SIP 6] Querycontext improvement
URL: https://github.com/apache/incubator-superset/pull/6524#issuecomment-448409473
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6524?src=pr&el=h1) Report
   > Merging [#6524](https://codecov.io/gh/apache/incubator-superset/pull/6524?src=pr&el=desc) into [feature--embeddable-charts-pilot](https://codecov.io/gh/apache/incubator-superset/commit/f366bbe7356106d15c6cfe481f64afbd8091ffb7?src=pr&el=desc) will **decrease** coverage by `0.93%`.
   > The diff coverage is `42.53%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/6524/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/6524?src=pr&el=tree)
   
   ```diff
   @@                         Coverage Diff                         @@
   ##           feature--embeddable-charts-pilot   #6524      +/-   ##
   ===================================================================
   - Coverage                             73.34%   72.4%   -0.94%     
   ===================================================================
     Files                                    67      67              
     Lines                                  9611    9774     +163     
   ===================================================================
   + Hits                                   7049    7077      +28     
   - Misses                                 2562    2697     +135
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/6524?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/6524/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.38% <ø> (ø)` | :arrow_up: |
   | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/6524/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.35% <100%> (+0.02%)` | :arrow_up: |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/6524/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `21.42% <18.18%> (-68.58%)` | :arrow_down: |
   | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/6524/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `27.77% <19.04%> (-67.47%)` | :arrow_down: |
   | [superset/views/api.py](https://codecov.io/gh/apache/incubator-superset/pull/6524/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYXBpLnB5) | `64.7% <50%> (-24.77%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/6524/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `77.83% <66.66%> (ø)` | :arrow_up: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/6524/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `72.83% <80%> (+0.59%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6524?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6524?src=pr&el=footer). Last update [f366bbe...f949126](https://codecov.io/gh/apache/incubator-superset/pull/6524?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org