You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2023/01/10 01:01:27 UTC

[GitHub] [rocketmq] RongtongJin commented on issue #5836: [code discussition] Should the method queryAssignment request again?

RongtongJin commented on issue #5836:
URL: https://github.com/apache/rocketmq/issues/5836#issuecomment-1376571791

   > ![image](https://user-images.githubusercontent.com/31891548/210945126-113b6be5-0545-4622-8cb7-6e2a15164e3d.png)
   > 
   > 1. the method **tryQueryAssignment** and the method **getRebalanceResultFromBroker** both request to the broker to execute the queryAssignment method
   > 
   > Why not pass the result returned by the method tryQueryAssignment to the method getRebalanceResultFromBroker, which can reduce a network request
   
   I think this is really an enhancement, could you submit a pull request to polish it ？


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org