You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "amoghrajesh (via GitHub)" <gi...@apache.org> on 2024/12/05 04:38:31 UTC
[PR] Fixing cli test failure in CI [airflow]
amoghrajesh opened a new pull request, #44679:
URL: https://github.com/apache/airflow/pull/44679
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
Fixing https://github.com/apache/airflow/actions/runs/12171824313/job/33949649869
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixing cli test failure in CI [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #44679:
URL: https://github.com/apache/airflow/pull/44679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixing cli test failure in CI [airflow]
Posted by "gopidesupavan (via GitHub)" <gi...@apache.org>.
gopidesupavan commented on code in PR #44679:
URL: https://github.com/apache/airflow/pull/44679#discussion_r1871358618
##########
tests/cli/test_cli_parser.py:
##########
@@ -423,7 +423,7 @@ def test_invalid_choice_raises_for_export_format_in_db_export_archived_command(
assert error_msg == (
"\nairflow db export-archived command error: argument "
f"--export-format: invalid choice: '{export_format}' "
Review Comment:
```suggestion
assert error_msg.replace("'", "") == (
"\nairflow db export-archived command error: argument "
f"--export-format: invalid choice: {export_format}"
```
As Jarek, mentioned in slack this is happening for 3.12, so may be we can do like this then it should work for all versions, know this is bit ugly but dont have any other option :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixing cli test failure in CI [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on code in PR #44679:
URL: https://github.com/apache/airflow/pull/44679#discussion_r1872529195
##########
tests/cli/test_cli_parser.py:
##########
@@ -423,7 +423,7 @@ def test_invalid_choice_raises_for_export_format_in_db_export_archived_command(
assert error_msg == (
"\nairflow db export-archived command error: argument "
f"--export-format: invalid choice: '{export_format}' "
Review Comment:
Yeah good idea, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixing cli test failure in CI [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #44679:
URL: https://github.com/apache/airflow/pull/44679#discussion_r1872088062
##########
tests/cli/test_cli_parser.py:
##########
@@ -423,7 +423,7 @@ def test_invalid_choice_raises_for_export_format_in_db_export_archived_command(
assert error_msg == (
"\nairflow db export-archived command error: argument "
f"--export-format: invalid choice: '{export_format}' "
Review Comment:
Maybe:
```
assert "airflow db export-archived command error: argument --export-format: invalid choice" in error_msg
```
We do not have to test for exact equality
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixing cli test failure in CI [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on code in PR #44679:
URL: https://github.com/apache/airflow/pull/44679#discussion_r1871648992
##########
tests/cli/test_cli_parser.py:
##########
@@ -423,7 +423,7 @@ def test_invalid_choice_raises_for_export_format_in_db_export_archived_command(
assert error_msg == (
"\nairflow db export-archived command error: argument "
f"--export-format: invalid choice: '{export_format}' "
Review Comment:
I dont love this idea but I do not have a better one too.
I am thinking instead, we just add a check for PY3.12+ and check?
@potiuk @gopidesupavan wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixing cli test failure in CI [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on PR #44679:
URL: https://github.com/apache/airflow/pull/44679#issuecomment-2519249724
This PR might not be needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org