You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Tom Beerbower <tb...@hortonworks.com> on 2015/05/28 17:56:21 UTC
Review Request 34772: Views : URLStreamProvider & HttpImpersonator do
not inject doAs param correctly
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34772/
-----------------------------------------------------------
Review request for Ambari, Jonathan Hurley and Nate Cole.
Bugs: AMBARI-11489
https://issues.apache.org/jira/browse/AMBARI-11489
Repository: ambari
Description
-------
doAs needs to be passed on query string instead of in http headers
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/view/HttpImpersonatorImpl.java 7dd4947
ambari-server/src/main/java/org/apache/ambari/server/view/ViewURLStreamProvider.java 459cea1
ambari-server/src/test/java/org/apache/ambari/server/view/ViewURLStreamProviderTest.java 267a605
Diff: https://reviews.apache.org/r/34772/diff/
Testing
-------
updated unit tests
mvn clean test
All tests pass
Thanks,
Tom Beerbower
Re: Review Request 34772: Views : URLStreamProvider &
HttpImpersonator do not inject doAs param correctly
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34772/#review85569
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On May 28, 2015, 11:56 a.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34772/
> -----------------------------------------------------------
>
> (Updated May 28, 2015, 11:56 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-11489
> https://issues.apache.org/jira/browse/AMBARI-11489
>
>
> Repository: ambari
>
>
> Description
> -------
>
> doAs needs to be passed on query string instead of in http headers
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/view/HttpImpersonatorImpl.java 7dd4947
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewURLStreamProvider.java 459cea1
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewURLStreamProviderTest.java 267a605
>
> Diff: https://reviews.apache.org/r/34772/diff/
>
>
> Testing
> -------
>
> updated unit tests
>
> mvn clean test
>
> All tests pass
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 34772: Views : URLStreamProvider &
HttpImpersonator do not inject doAs param correctly
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34772/#review85575
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On May 28, 2015, 11:56 a.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34772/
> -----------------------------------------------------------
>
> (Updated May 28, 2015, 11:56 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-11489
> https://issues.apache.org/jira/browse/AMBARI-11489
>
>
> Repository: ambari
>
>
> Description
> -------
>
> doAs needs to be passed on query string instead of in http headers
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/view/HttpImpersonatorImpl.java 7dd4947
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewURLStreamProvider.java 459cea1
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewURLStreamProviderTest.java 267a605
>
> Diff: https://reviews.apache.org/r/34772/diff/
>
>
> Testing
> -------
>
> updated unit tests
>
> mvn clean test
>
> All tests pass
>
>
> Thanks,
>
> Tom Beerbower
>
>