You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2019/11/23 15:00:13 UTC

[GitHub] [zookeeper] Randgalt commented on issue #1010: ZOOKEEPER-3425: ranking the ttl by expireTime asc for the performance

Randgalt commented on issue #1010: ZOOKEEPER-3425: ranking the ttl by expireTime asc for the performance
URL: https://github.com/apache/zookeeper/pull/1010#issuecomment-557804721
 
 
   Here's an alternate implementation that's simpler (in my view). However, I need to think more about the maintenance of the two maps. I'm not certain this is thread safe. Finally, is this optimization needed? This smells like a premature optimization to me. Has anyone seen issues with this in production installations? The TTLs are searched in a background thread and shouldn't affect foreground performance very much.
   
   https://github.com/apache/zookeeper/compare/master...Randgalt:ZOOKEEPER-3425-order-ttls-for-performance

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services