You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by "zzzk1 (via GitHub)" <gi...@apache.org> on 2024/07/02 17:07:04 UTC

[PR] [ISSUE-3821] Fixup! streampark image unavailable in e2e test [incubator-streampark]

zzzk1 opened a new pull request, #3822:
URL: https://github.com/apache/incubator-streampark/pull/3822

   <!--
   Thank you for contributing to StreamPark! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   ## Contribution Checklist
   
     - If this is your first time, please read our contributor guidelines: [Submit Code](https://streampark.apache.org/community/submit_guide/submit_code).
   
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-streampark/issues).
   
     - Name the pull request in the form "[Feature] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
   
     - If the PR is unfinished, add `[WIP]` in your PR title, e.g., `[WIP][Feature] Title of the pull request`.
   
   -->
   
   ## What changes were proposed in this pull request
   
   Issue Number: close #3821 <!-- REMOVE this line if no issue to close -->
   
   update unavailable image tag in e2e test model.
   <!--(For example: This pull request proposed to add checkstyle plugin).-->
   
   ## Brief change log
   <!--*(for example:)*
   - *Add maven-checkstyle-plugin to root pom.xml*
   -->
   
   ## Verifying this change
   
   <!--*(Please pick either of the following options)*-->
   
   
   ## Does this pull request potentially affect one of the following parts
    - Dependencies (does it add or upgrade a dependency): (no)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ISSUE-3821] Fixup! streampark image unavailable in e2e test [incubator-streampark]

Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS commented on code in PR #3822:
URL: https://github.com/apache/incubator-streampark/pull/3822#discussion_r1661097181


##########
streampark-e2e/streampark-e2e-case/src/test/resources/docker/basic/docker-compose.yaml:
##########
@@ -19,7 +19,7 @@ version: "3.8"
 
 services:
   streampark:
-    image: apache/streampark:ci-basic
+    image: apache/streampark:dev

Review Comment:
   The `e2e` images are build by `./Dockerfile` in each PR's CI. Not dev branch.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org