You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/11/10 16:04:52 UTC
[GitHub] [camel] mcollovati opened a new pull request #4591: Fixed inverted Include/ExcludeRoutes documentation
mcollovati opened a new pull request #4591:
URL: https://github.com/apache/camel/pull/4591
Inverted configuration names of *camel.main.routeController​.IncludeRoutes* and *camel.main.routeController​.ExcludeRoutes* so that the name corresponds to the correct description.
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/master/CONTRIBUTING.md
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #4591: Fixed inverted Include/ExcludeRoutes documentation
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #4591:
URL: https://github.com/apache/camel/pull/4591#issuecomment-724863963
Yes, it should work in this case
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #4591: Fixed inverted Include/ExcludeRoutes documentation
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #4591:
URL: https://github.com/apache/camel/pull/4591#issuecomment-724847527
Yeah they are from java source code, look inside camel-main to find it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] mcollovati commented on pull request #4591: Fixed inverted Include/ExcludeRoutes documentation
Posted by GitBox <gi...@apache.org>.
mcollovati commented on pull request #4591:
URL: https://github.com/apache/camel/pull/4591#issuecomment-724858092
I found the javadocs to change; am I supposed to push only changes to the Java source file or also the generated metadata and doc?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] mcollovati commented on pull request #4591: Fixed inverted Include/ExcludeRoutes documentation
Posted by GitBox <gi...@apache.org>.
mcollovati commented on pull request #4591:
URL: https://github.com/apache/camel/pull/4591#issuecomment-724862192
So I should run a `mvn clean install -Pfastinstall` and then commit and push all changes?
Sorry for asking so many questions :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] mcollovati commented on pull request #4591: Fixed inverted Include/ExcludeRoutes documentation
Posted by GitBox <gi...@apache.org>.
mcollovati commented on pull request #4591:
URL: https://github.com/apache/camel/pull/4591#issuecomment-724801565
> Not sure, but this should be autogenerated
Ah, ok; I hit the button "Edit this page" on camel website.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] mcollovati edited a comment on pull request #4591: Fixed inverted Include/ExcludeRoutes documentation
Posted by GitBox <gi...@apache.org>.
mcollovati edited a comment on pull request #4591:
URL: https://github.com/apache/camel/pull/4591#issuecomment-724801565
> Not sure, but this should be autogenerated
Ah, ok; I hit the button "Edit this page" on camel website, following instructions on https://camel.apache.org/manual/latest/faq/how-do-i-edit-the-website.html.
Let me know if I should close this PR and do it in another way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #4591: Fixed inverted Include/ExcludeRoutes documentation
Posted by GitBox <gi...@apache.org>.
davsclaus merged pull request #4591:
URL: https://github.com/apache/camel/pull/4591
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] mcollovati edited a comment on pull request #4591: Fixed inverted Include/ExcludeRoutes documentation
Posted by GitBox <gi...@apache.org>.
mcollovati edited a comment on pull request #4591:
URL: https://github.com/apache/camel/pull/4591#issuecomment-724801565
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #4591: Fixed inverted Include/ExcludeRoutes documentation
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #4591:
URL: https://github.com/apache/camel/pull/4591#issuecomment-724860529
There is a regen_bot if you don't have time to build everything
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org