[jira] [Commented] (NIFI-543) Provide extensions a way to indicate that they can run only on primary node, if clustered

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16431139#comment-16431139 ] 

ASF GitHub Bot commented on NIFI-543:
-------------------------------------

Github user markap14 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2509#discussion_r180211409
  
    --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-processor-configuration.js ---
    @@ -741,8 +742,8 @@
                             }
                         });
     
    -                    // show the execution node option if we're cluster or we're currently configured to run on the primary node only
    -                    if (nfClusterSummary.isClustered() || executionNode === 'PRIMARY') {
    +                    // show the execution node option if we're clustered and execution node is not restricted to run only in primary node
    +                    if (nfClusterSummary.isClustered() && executionNodeRestricted !== true) {
    --- End diff --
    
    I think we still need the executionNode === 'PRIMARY' here:
    ```
    if ((nfClusterSummary.isClustered() && executionNodeRestricted !== true) || executionNode === 'PRIMARY') {
    ```
    This way, if running in standalone mode, but the processor is marked with an ExecutionNode of Primary Node (which may be the case if instantiating a template from a cluster, or if if copying a flow.xml.gz over or something like that) we still have the ability to change it to 'All Nodes'.


> Provide extensions a way to indicate that they can run only on primary node, if clustered
> -----------------------------------------------------------------------------------------
>
>                 Key: NIFI-543
>                 URL: https://issues.apache.org/jira/browse/NIFI-543
>             Project: Apache NiFi
>          Issue Type: Sub-task
>          Components: Core Framework, Documentation & Website, Extensions
>            Reporter: Mark Payne
>            Assignee: Sivaprasanna Sethuraman
>            Priority: Major
>
> There are Processors that are known to be problematic if run from multiple nodes simultaneously. These processors should be able to use a @PrimaryNodeOnly annotation (or something similar) to indicate that they can be scheduled to run only on primary node if run in a cluster.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)