[GitHub] couchdb-couch pull request #229: Return error row instead of crashing

[iilyak <gi...@git.apache.org>]

Github user iilyak commented on a diff in the pull request:

    https://github.com/apache/couchdb-couch/pull/229#discussion_r103786495
  
    --- Diff: src/couch_query_servers.erl ---
    @@ -169,6 +178,19 @@ sum_values(Value, Acc) when is_number(Value), is_list(Acc) ->
         sum_arrays(Acc, [Value]);
     sum_values(Value, Acc) when is_list(Value), is_number(Acc) ->
         sum_arrays([Acc], Value);
    +sum_values({Props}, Acc) ->
    +    case lists:keyfind(<<"error">>, 1, Props) of
    --- End diff --
    
    I don't like the fact that we are passing error in the payload. This forces us to iterate through Props.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---