RecipientIsLocal false negative on james_domain table case mismatch

[Jerry Malcolm <te...@malcolms.com>]

One of my clients reported a problem today that I traced back to a false 
negative on the RecipientIsLocal matcher.  I finally realized that the 
recipient's domain name was defined in mixed case in the james_domain 
table.   This cause the DomainList.isLocalDomain() method to not find 
the domain due to case mismatch which ultimately caused RecipientIsLocal 
to return false. Simple fix was to lowercase the domain name in the 
table. But as long as mixed case is allowed in the table and the check 
for domains is case-sensitive, local domains are at risk of not being 
found in the table.

What do you recommend as the correct fix?  I can open a JIRA and submit 
the fix.

Jerry


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org

Re: RecipientIsLocal false negative on james_domain table case mismatch

[Raphaël Ouazana-Sustowski <ro...@apache.org>]

Hi again,

This issue seems very similar to the username's one. But the fix could 
be simpler, because Domain class already exists in James, so it would 
need only to ensure the Domain objects are always lower case.

Could you provide a fix for this? It would be very welcomed.

Thanks,
Raphaël.

Le 30/10/2019 à 21:35, Jerry Malcolm a écrit :
> One of my clients reported a problem today that I traced back to a 
> false negative on the RecipientIsLocal matcher.  I finally realized 
> that the recipient's domain name was defined in mixed case in the 
> james_domain table.   This cause the DomainList.isLocalDomain() method 
> to not find the domain due to case mismatch which ultimately caused 
> RecipientIsLocal to return false. Simple fix was to lowercase the 
> domain name in the table. But as long as mixed case is allowed in the 
> table and the check for domains is case-sensitive, local domains are 
> at risk of not being found in the table.
>
> What do you recommend as the correct fix?  I can open a JIRA and 
> submit the fix.
>
> Jerry
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org