You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/28 11:44:21 UTC
[GitHub] [airflow] potiuk opened a new pull request #16689: Separate out coverage files for different executors
potiuk opened a new pull request #16689:
URL: https://github.com/apache/airflow/pull/16689
The coverage files and virtualenvs were not separated out
for different executors - running them in parallell could cause
the files override each other and mysterious failures of
the K8S tests.
This PR separates out the coverage files.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #16689: Separate out coverage files for different executors
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #16689:
URL: https://github.com/apache/airflow/pull/16689#issuecomment-869782146
Should we not have a default value for `EXECUTOR`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #16689: Separate out coverage files for different executors
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #16689:
URL: https://github.com/apache/airflow/pull/16689#discussion_r660000335
##########
File path: TESTING.rst
##########
@@ -657,6 +659,8 @@ in the host.
You can enter the shell via those scripts
+ export EXECUTOR="KubernetesExecutor" ## can be also CeleryExecutor or CeleryKubernetesExecutor
Review comment:
Not related, but why is this not a `.. code-block`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #16689: Separate out coverage files for different executors
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #16689:
URL: https://github.com/apache/airflow/pull/16689#issuecomment-869804764
We do :) https://github.com/apache/airflow/blob/f0b3345ddc489627d73d190a1401804e7b0d9c4e/scripts/ci/libraries/_initialization.sh#L520
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #16689: Separate out coverage files for different executors
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16689:
URL: https://github.com/apache/airflow/pull/16689#issuecomment-869775321
Should help to tackle random race-induced test failures :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #16689: Separate out coverage files for different executors
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #16689:
URL: https://github.com/apache/airflow/pull/16689#discussion_r660004701
##########
File path: TESTING.rst
##########
@@ -657,6 +659,8 @@ in the host.
You can enter the shell via those scripts
+ export EXECUTOR="KubernetesExecutor" ## can be also CeleryExecutor or CeleryKubernetesExecutor
Review comment:
```suggestion
.. code-block:: bash
export EXECUTOR="KubernetesExecutor" ## can be also CeleryExecutor or CeleryKubernetesExecutor
```
¯\_(ツ)_/¯
##########
File path: TESTING.rst
##########
@@ -657,6 +659,8 @@ in the host.
You can enter the shell via those scripts
+ export EXECUTOR="KubernetesExecutor" ## can be also CeleryExecutor or CeleryKubernetesExecutor
Review comment:
```suggestion
.. code-block:: bash
export EXECUTOR="KubernetesExecutor" ## can be also CeleryExecutor or CeleryKubernetesExecutor
```
`¯\_(ツ)_/¯`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #16689: Separate out coverage files for different executors
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16689:
URL: https://github.com/apache/airflow/pull/16689#issuecomment-869804764
We do :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #16689: Separate out coverage files for different executors
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #16689:
URL: https://github.com/apache/airflow/pull/16689
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #16689: Separate out coverage files for different executors
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16689:
URL: https://github.com/apache/airflow/pull/16689#issuecomment-869894983
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #16689: Separate out coverage files for different executors
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16689:
URL: https://github.com/apache/airflow/pull/16689#issuecomment-869775321
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #16689: Separate out coverage files for different executors
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #16689:
URL: https://github.com/apache/airflow/pull/16689#issuecomment-869893819
Ah OK, so the `EXECUTOR` checks are mostly sanity (and for people not running scripts from the usual entry points). Makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #16689: Separate out coverage files for different executors
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #16689:
URL: https://github.com/apache/airflow/pull/16689#issuecomment-869804764
We do :) https://github.com/apache/airflow/blob/f0b3345ddc489627d73d190a1401804e7b0d9c4e/scripts/ci/libraries/_initialization.sh#L520
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #16689: Separate out coverage files for different executors
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #16689:
URL: https://github.com/apache/airflow/pull/16689#discussion_r660000335
##########
File path: TESTING.rst
##########
@@ -657,6 +659,8 @@ in the host.
You can enter the shell via those scripts
+ export EXECUTOR="KubernetesExecutor" ## can be also CeleryExecutor or CeleryKubernetesExecutor
Review comment:
Not related, but why is this not a `.. code-block`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #16689: Separate out coverage files for different executors
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16689:
URL: https://github.com/apache/airflow/pull/16689#issuecomment-869614463
Example failure it caused: https://github.com/apache/airflow/pull/16682/checks?check_run_id=2930829047#step:8:3777
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #16689: Separate out coverage files for different executors
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16689:
URL: https://github.com/apache/airflow/pull/16689#issuecomment-869894983
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #16689: Separate out coverage files for different executors
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #16689:
URL: https://github.com/apache/airflow/pull/16689#discussion_r660004701
##########
File path: TESTING.rst
##########
@@ -657,6 +659,8 @@ in the host.
You can enter the shell via those scripts
+ export EXECUTOR="KubernetesExecutor" ## can be also CeleryExecutor or CeleryKubernetesExecutor
Review comment:
```suggestion
.. code-block:: bash
export EXECUTOR="KubernetesExecutor" ## can be also CeleryExecutor or CeleryKubernetesExecutor
```
¯\_(ツ)_/¯
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #16689: Separate out coverage files for different executors
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #16689:
URL: https://github.com/apache/airflow/pull/16689#discussion_r660004701
##########
File path: TESTING.rst
##########
@@ -657,6 +659,8 @@ in the host.
You can enter the shell via those scripts
+ export EXECUTOR="KubernetesExecutor" ## can be also CeleryExecutor or CeleryKubernetesExecutor
Review comment:
```suggestion
.. code-block:: bash
export EXECUTOR="KubernetesExecutor" ## can be also CeleryExecutor or CeleryKubernetesExecutor
```
`¯\_(ツ)_/¯`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #16689: Separate out coverage files for different executors
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #16689:
URL: https://github.com/apache/airflow/pull/16689
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #16689: Separate out coverage files for different executors
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #16689:
URL: https://github.com/apache/airflow/pull/16689#issuecomment-869782146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org