You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Seumas Soltysik (JIRA)" <ji...@apache.org> on 2006/09/25 17:15:50 UTC

[jira] Created: (CXF-115) org.apache.cxf.jaxws.EndpointImpl needs additional constructors

org.apache.cxf.jaxws.EndpointImpl needs additional constructors
---------------------------------------------------------------

                 Key: CXF-115
                 URL: http://issues.apache.org/jira/browse/CXF-115
             Project: CeltiXfire
          Issue Type: Improvement
          Components: JAX-WS Runtime
            Reporter: Seumas Soltysik


Currently Endpoint impl has the following constructor:
  public EndpointImpl(Bus b, Object implementor, String uri) 

This constructor extracts annotation information from the implementor object in order to create the Endpoint. However, if a user wants to over-ride one of the annotation values such as the wsdlLocation value they cannot do this. This situation happens when a implementation is code generated and then the location of the wsdl changes. This could happen if you are packaging up a endpoint along with a wsdl for deployment into a container.

I think what is needed is a more flexible constructor that looks something like this:

public EndpointImpl(Bus b, Object implementor, Service s, String portname)

This way a user is free to contruct their own Service from a wsdl not specified by the WSDL location. 


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (CXF-115) org.apache.cxf.jaxws.EndpointImpl needs additional constructors

Posted by "Dan Diephouse (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/CXF-115?page=all ]

Dan Diephouse closed CXF-115.
-----------------------------

    Fix Version/s: 2.0-M1
       Resolution: Fixed

I added a patch for this to SVN. To use it do something like so:

 GreeterImpl greeter = new GreeterImpl();
        JaxWsServiceFactoryBean serviceFactory = new JaxWsServiceFactoryBean();
        serviceFactory.setBus(getBus());
        serviceFactory.setInvoker(new BeanInvoker(greeter));
        serviceFactory.setServiceClass(GreeterImpl.class);
        
        EndpointImpl endpoint = new EndpointImpl(getBus(), greeter, serviceFactory);

It passes the servicefactory as we need to get information from it inside EndpointImpl.

> org.apache.cxf.jaxws.EndpointImpl needs additional constructors
> ---------------------------------------------------------------
>
>                 Key: CXF-115
>                 URL: http://issues.apache.org/jira/browse/CXF-115
>             Project: CeltiXfire
>          Issue Type: Improvement
>          Components: JAX-WS Runtime
>            Reporter: Seumas Soltysik
>             Fix For: 2.0-M1
>
>
> Currently Endpoint impl has the following constructor:
>   public EndpointImpl(Bus b, Object implementor, String uri) 
> This constructor extracts annotation information from the implementor object in order to create the Endpoint. However, if a user wants to over-ride one of the annotation values such as the wsdlLocation value they cannot do this. This situation happens when a implementation is code generated and then the location of the wsdl changes. This could happen if you are packaging up a endpoint along with a wsdl for deployment into a container.
> I think what is needed is a more flexible constructor that looks something like this:
> public EndpointImpl(Bus b, Object implementor, Service s, String portname)
> This way a user is free to contruct their own Service from a wsdl not specified by the WSDL location. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (CXF-115) org.apache.cxf.jaxws.EndpointImpl needs additional constructors

Posted by "Dan Diephouse (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/CXF-115?page=all ]

Dan Diephouse closed CXF-115.
-----------------------------

    Resolution: Fixed

Closing as I think this is resolved, let me know if you still have issues.

> org.apache.cxf.jaxws.EndpointImpl needs additional constructors
> ---------------------------------------------------------------
>
>                 Key: CXF-115
>                 URL: http://issues.apache.org/jira/browse/CXF-115
>             Project: CXF
>          Issue Type: Improvement
>          Components: JAX-WS Runtime
>            Reporter: Seumas Soltysik
>         Assigned To: Dan Diephouse
>             Fix For: 2.0-M1
>
>
> Currently Endpoint impl has the following constructor:
>   public EndpointImpl(Bus b, Object implementor, String uri) 
> This constructor extracts annotation information from the implementor object in order to create the Endpoint. However, if a user wants to over-ride one of the annotation values such as the wsdlLocation value they cannot do this. This situation happens when a implementation is code generated and then the location of the wsdl changes. This could happen if you are packaging up a endpoint along with a wsdl for deployment into a container.
> I think what is needed is a more flexible constructor that looks something like this:
> public EndpointImpl(Bus b, Object implementor, Service s, String portname)
> This way a user is free to contruct their own Service from a wsdl not specified by the WSDL location. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (CXF-115) org.apache.cxf.jaxws.EndpointImpl needs additional constructors

Posted by "Seumas Soltysik (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/CXF-115?page=comments#action_12442713 ] 
            
Seumas Soltysik commented on CXF-115:
-------------------------------------

Dan, this change does not quite provide the necessary functionality. Since I would like to create an Endpoint using a information from a WSDL with a URL other than what is annotated by the impl class, I need an EndpointImpl constructor that takes a WSDLServiceFactory. 

The driver code would look like this:
       WSDLServiceFactory factory = new WSDLServiceFactory(bus, wsdlLoc, serviceName);        
        endpoint = new  EndpointImpl(bus, impl, factory);

To make it more generic we could have a constructor that looks like this
EndpointImpl(Bus b, Object impl, AbstractServiceFactoryBean serviceFactory) {
        this.bus = b;
        this.serviceFactory = serviceFactory;
        this.implInfo = new JaxWsImplementorInfo(implementor.getClass());
        this.service = serviceFactory.getService();
        this.implementor = implementor;
        
        if (this.service == null) {
            service = serviceFactory.create();
        }
        
        doInit = true;
}

> org.apache.cxf.jaxws.EndpointImpl needs additional constructors
> ---------------------------------------------------------------
>
>                 Key: CXF-115
>                 URL: http://issues.apache.org/jira/browse/CXF-115
>             Project: CXF
>          Issue Type: Improvement
>          Components: JAX-WS Runtime
>            Reporter: Seumas Soltysik
>             Fix For: 2.0-M1
>
>
> Currently Endpoint impl has the following constructor:
>   public EndpointImpl(Bus b, Object implementor, String uri) 
> This constructor extracts annotation information from the implementor object in order to create the Endpoint. However, if a user wants to over-ride one of the annotation values such as the wsdlLocation value they cannot do this. This situation happens when a implementation is code generated and then the location of the wsdl changes. This could happen if you are packaging up a endpoint along with a wsdl for deployment into a container.
> I think what is needed is a more flexible constructor that looks something like this:
> public EndpointImpl(Bus b, Object implementor, Service s, String portname)
> This way a user is free to contruct their own Service from a wsdl not specified by the WSDL location. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Reopened: (CXF-115) org.apache.cxf.jaxws.EndpointImpl needs additional constructors

Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/CXF-115?page=all ]

Daniel Kulp reopened CXF-115:
-----------------------------

      Assignee: Dan Diephouse
             

> org.apache.cxf.jaxws.EndpointImpl needs additional constructors
> ---------------------------------------------------------------
>
>                 Key: CXF-115
>                 URL: http://issues.apache.org/jira/browse/CXF-115
>             Project: CXF
>          Issue Type: Improvement
>          Components: JAX-WS Runtime
>            Reporter: Seumas Soltysik
>         Assigned To: Dan Diephouse
>             Fix For: 2.0-M1
>
>
> Currently Endpoint impl has the following constructor:
>   public EndpointImpl(Bus b, Object implementor, String uri) 
> This constructor extracts annotation information from the implementor object in order to create the Endpoint. However, if a user wants to over-ride one of the annotation values such as the wsdlLocation value they cannot do this. This situation happens when a implementation is code generated and then the location of the wsdl changes. This could happen if you are packaging up a endpoint along with a wsdl for deployment into a container.
> I think what is needed is a more flexible constructor that looks something like this:
> public EndpointImpl(Bus b, Object implementor, Service s, String portname)
> This way a user is free to contruct their own Service from a wsdl not specified by the WSDL location. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (CXF-115) org.apache.cxf.jaxws.EndpointImpl needs additional constructors

Posted by "Dan Diephouse (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/CXF-115?page=comments#action_12442719 ] 
            
Dan Diephouse commented on CXF-115:
-----------------------------------

The JAX-WS service factory already provides functionality to override the URL. Try:

sf = new JaxWsServiceFactoryBean();
sf.setWsdlURL(new URL("overridingurl"));

new EndpointImpl(..., sf);



> org.apache.cxf.jaxws.EndpointImpl needs additional constructors
> ---------------------------------------------------------------
>
>                 Key: CXF-115
>                 URL: http://issues.apache.org/jira/browse/CXF-115
>             Project: CXF
>          Issue Type: Improvement
>          Components: JAX-WS Runtime
>            Reporter: Seumas Soltysik
>             Fix For: 2.0-M1
>
>
> Currently Endpoint impl has the following constructor:
>   public EndpointImpl(Bus b, Object implementor, String uri) 
> This constructor extracts annotation information from the implementor object in order to create the Endpoint. However, if a user wants to over-ride one of the annotation values such as the wsdlLocation value they cannot do this. This situation happens when a implementation is code generated and then the location of the wsdl changes. This could happen if you are packaging up a endpoint along with a wsdl for deployment into a container.
> I think what is needed is a more flexible constructor that looks something like this:
> public EndpointImpl(Bus b, Object implementor, Service s, String portname)
> This way a user is free to contruct their own Service from a wsdl not specified by the WSDL location. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira