Re: [I] Relax need of ordering/precombine field for tables with autogenerated record keys for DeltaStreamer [hudi]

["nsivabalan (via GitHub)" <gi...@apache.org>]

nsivabalan commented on issue #16346:
URL: https://github.com/apache/hudi/issues/16346#issuecomment-4795589836

   This appears to be resolved on current master. Commit [`8f6b1ae`](https://github.com/apache/hudi/commit/8f6b1aed3ef746e6d21bd193684d41ffa1995d3c) (HUDI-8551, _Support no precombine field with EVENT_TIME_ORDERING merge mode_, #12292) added a `shouldUseOrderingField` guard in `HoodieStreamerUtils.createHoodieRecords` so the ordering field is only read when one is actually configured — matching exactly the relaxation requested here. The check is still present at [`HoodieStreamerUtils.java:94-96`](https://github.com/apache/hudi/blob/master/hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/HoodieStreamerUtils.java#L94-L96):
   
   ```java
   boolean shouldCombine = cfg.filterDupes || cfg.operation.equals(WriteOperationType.UPSERT);
   String orderingFieldsStr = tableConfig.getOrderingFieldsStr().orElse(cfg.sourceOrderingFields);
   boolean shouldUseOrderingField = shouldCombine && !StringUtils.isNullOrEmpty(orderingFieldsStr);
   ```
   
   NPEs in the downstream record types were also addressed in the same commit. UPSERT with auto-generated record keys and no `--source-ordering-field` should now work end-to-end. Closing as fixed — please reopen with a current-master repro if you still hit it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org