You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by jean-frederic clere <jf...@gmail.com> on 2010/02/24 11:56:14 UTC
[VOTE] Release build 6.0.25
The candidates binaries are available here:
http://people.apache.org/~jfclere/tomcat-6/v6.0.25/
According to the release process, the 6.0.25 tag is:
[ ] Broken
[ ] Alpha
[ ] Beta
[ ] Stable
Cheers
Jean-Frederic
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release build 6.0.25
Posted by Mladen Turk <mt...@apache.org>.
On 02/24/2010 11:56 AM, jean-frederic clere wrote:
>
> According to the release process, the 6.0.25 tag is:
> [ ] Broken
> [ ] Alpha
> [ ] Beta
> [X] Stable
>
Checked on windows and linux.
You might wish to add the note about known issue
Windows exception thrown on shutdown
SEVERE: Socket accept failed.
This is now displayed thanks to the tcnative 1.1.20
It is caused by AJP connector not being awaken
from the accept loop like we are doing for http
connectors on shutdown.
Regards
--
^TM
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release build 6.0.25
Posted by jean-frederic clere <jf...@gmail.com>.
On 02/25/2010 01:07 PM, Tim Funk wrote:
> So far all looks OK - but due to the version issue - I vote:
> [X] Broken
>
> I believe rebuilding with an updated properties (no retag needed) should
> fix the issue.
Yep it is just a packaging problem.
Cheers
Jean-Frederic
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release build 6.0.25
Posted by Tim Funk <fu...@apache.org>.
So far all looks OK - but due to the version issue - I vote:
[X] Broken
I believe rebuilding with an updated properties (no retag needed) should
fix the issue.
-Tim
On 2/25/2010 6:07 AM, Konstantin Kolinko wrote:
> 2010/2/24 jean-frederic clere<jf...@gmail.com>:
>> The candidates binaries are available here:
>> http://people.apache.org/~jfclere/tomcat-6/v6.0.25/
>>
>
> org/apache/catalina/util/ServerInfo.properties:
>
> server.info=Apache Tomcat/6.0.25
> server.number=6.0.0.0
> server.built=February 24 2010 1107
>
> 6.0.24, 23 also had "6.0.0.0" in their server.number. In 6.0.20 it
> was "6.0.20.0" as it should be.
>
> Best regards,
> Konstantin Kolinko
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release build 6.0.25
Posted by Konstantin Kolinko <kn...@gmail.com>.
2010/2/24 jean-frederic clere <jf...@gmail.com>:
> The candidates binaries are available here:
> http://people.apache.org/~jfclere/tomcat-6/v6.0.25/
>
org/apache/catalina/util/ServerInfo.properties:
server.info=Apache Tomcat/6.0.25
server.number=6.0.0.0
server.built=February 24 2010 1107
6.0.24, 23 also had "6.0.0.0" in their server.number. In 6.0.20 it
was "6.0.20.0" as it should be.
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release build 6.0.25
Posted by Konstantin Kolinko <kn...@gmail.com>.
2010/2/27 Konstantin Kolinko <kn...@gmail.com>:
> 2010/2/24 jean-frederic clere <jf...@gmail.com>:
>> The candidates binaries are available here:
>> http://people.apache.org/~jfclere/tomcat-6/v6.0.25/
>>
>> According to the release process, the 6.0.25 tag is:
>> [x] Broken
>
> https://issues.apache.org/bugzilla/show_bug.cgi?id=48827
> Showstopper.
>
I should say that there is one more showstopper in 6.0.25:
the /findleaks command added to Manager webapp in 6.0.25 is not
covered by security constraints, thus enabling a DoS attack vector.
The fix for manager app web.xml is trivial and proposed in rev.917439.
Sorry for the inconvenience.
6.0.24 and trunk are not affected.
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release build 6.0.25
Posted by Konstantin Kolinko <kn...@gmail.com>.
2010/2/24 jean-frederic clere <jf...@gmail.com>:
> The candidates binaries are available here:
> http://people.apache.org/~jfclere/tomcat-6/v6.0.25/
>
> According to the release process, the 6.0.25 tag is:
> [x] Broken
https://issues.apache.org/bugzilla/show_bug.cgi?id=48827
Showstopper.
By the way: I have not a proof yet, but I think that not all cases of
https://issues.apache.org/bugzilla/show_bug.cgi?id=48668
were fixed by http://svn.apache.org/viewvc?rev=915572&view=rev
That is: there are still several places in Parser.java where
reader.matches("${") and reader.matches("#{") are called regardless of
whether pageInfo.isELIgnored() or
pageInfo.isDeferredSyntaxAllowedAsLiteral() are true. I consider it a
rare case though.
I planned to look at BZ 48668 first. In any case, that I won't be able
to do that earlier than in 8 hours from now.
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release build 6.0.25
Posted by Yoav Shapira <yo...@apache.org>.
On Wed, Feb 24, 2010 at 5:56 AM, jean-frederic clere <jf...@gmail.com> wrote:
> The candidates binaries are available here:
> http://people.apache.org/~jfclere/tomcat-6/v6.0.25/
>
> According to the release process, the 6.0.25 tag is:
> [ ] Broken
> [ ] Alpha
> [ ] Beta
> [ X ] Stable
My usual testing with a couple of home-brewed web apps.
Yoav
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release build 6.0.25
Posted by Mark Thomas <ma...@apache.org>.
On 24/02/2010 10:56, jean-frederic clere wrote:
> The candidates binaries are available here:
> http://people.apache.org/~jfclere/tomcat-6/v6.0.25/
>
> According to the release process, the 6.0.25 tag is:
> [ ] Broken
> [ ] Alpha
> [ ] Beta
> [X] Stable
PGP signatures all match
Key in web of trust
.exe installs and runs with defaults on x64 windows
Uninstall also works as expected
.zip works
Checked random manifest files - no issues
Apart from expected line ending differences -src.zip == -src.tar.gz
-src.zip == svn tag
Servlet 2.5 TCK passes without security manager
Servlet 2.5 TCK passes with security manager (some failures but all
expected as test tries to create network connection that is blocked by
default security policy)
JSP 2.1 TCK passes without security manager
JSP 2.1 TCK passes with security manager
Issues found:
version.build was not overridden so version number reports as 6.0.0.0
rather than 6.0.25.0. Packaging issue, not a src issue so can be fixed
without re-tagging.
Some log messages lost on shutdown - shutdown via Catalina shutdown
hook. Issues exists in 6.0.24. Fix in trunk and proposed for 6.0.x. Not
a show stopper.
Some .xml files (eg manager.xml) in .zip have LF line-endings. Fixed in
trunk. Should consider porting build changes from trunk to 6.0.x. Not a
show stopper.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release build 6.0.25
Posted by Mladen Turk <mt...@apache.org>.
On 02/24/2010 11:56 AM, jean-frederic clere wrote:
> The candidates binaries are available here:
> http://people.apache.org/~jfclere/tomcat-6/v6.0.25/
>
If the release is postponed I'd like to add the
legacy renegotiation support from trunk.
It requires tomcat-native 1.2.21 release first
with compiled OpenSSL 0.9.8m.
This should take around two days.
However it can wait till 6.0.26 as far as I'm concerned.
Regards
--
^TM
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org