You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/03/05 04:36:25 UTC

[GitHub] [dolphinscheduler] calvinjiang opened a new pull request #8704: [Fix-8624][UI-Next][V1.0.0-Alpha] Rectify the issue to display the timing form when clicking the timing button in the process definition page.

calvinjiang opened a new pull request #8704:
URL: https://github.com/apache/dolphinscheduler/pull/8704


   <!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
   
   
   ## Purpose of the pull request
   This PR will close #8624 .
   <!--(For example: This pull request adds checkstyle plugin).-->
   
   ## Brief change log
   
   <!--*(for example:)*
     - *Add maven-checkstyle-plugin to root pom.xml*
   -->
   ## Verify this pull request
   This change added tests and can be verified as follows:
     - *Manually verified the change by testing locally.* 
   ![image](https://user-images.githubusercontent.com/4928204/156867953-12387bb7-0a21-4734-8ffa-cee58b7fee9d.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler] calvinjiang commented on a change in pull request #8704: [Fix-8624][UI-Next][V1.0.0-Alpha] Rectify the issue to display the timing form when clicking the timing button in the process definition page.

Posted by GitBox <gi...@apache.org>.
calvinjiang commented on a change in pull request #8704:
URL: https://github.com/apache/dolphinscheduler/pull/8704#discussion_r820044282



##########
File path: dolphinscheduler-ui-next/src/views/projects/workflow/definition/components/timing-modal.tsx
##########
@@ -188,8 +188,8 @@ export default defineComponent({
       () => props.row,
       () => {
         timingState.timingForm.startEndTime = [
-          new Date(props.row.startTime),
-          new Date(props.row.endTime)
+          props.row.startTime? new Date(props.row.startTime) : new Date(),

Review comment:
       No problem. I'll improve that.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler] songjianet merged pull request #8704: [Fix-8624][UI-Next][V1.0.0-Alpha] Rectify the issue to display the timing form when clicking the timing button in the process definition page.

Posted by GitBox <gi...@apache.org>.
songjianet merged pull request #8704:
URL: https://github.com/apache/dolphinscheduler/pull/8704


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #8704: [Fix-8624][UI-Next][V1.0.0-Alpha] Rectify the issue to display the timing form when clicking the timing button in the process definition page.

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #8704:
URL: https://github.com/apache/dolphinscheduler/pull/8704#issuecomment-1059702155


   SonarCloud Quality Gate failed.&nbsp; &nbsp; ![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8704&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8704&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8704&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8704&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8704&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8704&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=8704&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=8704&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=8704&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8704&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8704&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=8704&resolved=false&types=CODE_SMELL)
   
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=8704&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=8704&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=8704&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=8704&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler] devosend commented on a change in pull request #8704: [Fix-8624][UI-Next][V1.0.0-Alpha] Rectify the issue to display the timing form when clicking the timing button in the process definition page.

Posted by GitBox <gi...@apache.org>.
devosend commented on a change in pull request #8704:
URL: https://github.com/apache/dolphinscheduler/pull/8704#discussion_r820043820



##########
File path: dolphinscheduler-ui-next/src/views/projects/workflow/definition/components/timing-modal.tsx
##########
@@ -188,8 +188,8 @@ export default defineComponent({
       () => props.row,
       () => {
         timingState.timingForm.startEndTime = [
-          new Date(props.row.startTime),
-          new Date(props.row.endTime)
+          props.row.startTime? new Date(props.row.startTime) : new Date(),

Review comment:
       You can use `props.row.crontab` to determine whether timeForm init is needed. Beause timeForm.crontab and other's needs to be initialized.
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler] devosend commented on pull request #8704: [Fix-8624][UI-Next][V1.0.0-Alpha] Rectify the issue to display the timing form when clicking the timing button in the process definition page.

Posted by GitBox <gi...@apache.org>.
devosend commented on pull request #8704:
URL: https://github.com/apache/dolphinscheduler/pull/8704#issuecomment-1059696540


   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org