You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "Tomek Rękawek (JIRA)" <ji...@apache.org> on 2016/02/19 16:43:19 UTC

[jira] [Commented] (OAK-4029) Optimize the bulk update method

    [ https://issues.apache.org/jira/browse/OAK-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15154370#comment-15154370 ] 

Tomek Rękawek commented on OAK-4029:
------------------------------------

[~reschke], could you take a look on the patch? It removes more code than adds so I think it's pretty good ;)

> Optimize the bulk update method
> -------------------------------
>
>                 Key: OAK-4029
>                 URL: https://issues.apache.org/jira/browse/OAK-4029
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: rdbmk
>            Reporter: Tomek Rękawek
>             Fix For: 1.6
>
>         Attachments: OAK-4029.patch
>
>
> It seems that the {{RDBDocumentStoreJDBC.update()}} method contains a redundant SELECT statement, between the UPDATE and INSERT phase. It's used to find out whether we should INSERT remaining documents or if they already exists in the DB. However, we may skip the middle SELECT and try to INSERT all documents with mod_count = 1.
> The second possible optimisation in this method is skipping the first bulk UPDATE operation if there are no documents to be updated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)