You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "xinrong-meng (via GitHub)" <gi...@apache.org> on 2024/10/17 06:12:25 UTC
[PR] [SPARK-50001][PYTHON][PS][CONNECT] Adjust "precision" to be part of kwargs for box plots [spark]
xinrong-meng opened a new pull request, #48513:
URL: https://github.com/apache/spark/pull/48513
### What changes were proposed in this pull request?
Adjust "precision" to be kwargs for box plots in both Pandas on Spark and PySpark.
### Why are the changes needed?
Per discussion here (https://github.com/apache/spark/pull/48445#discussion_r1804042377), precision is Spark-specific implementation detail, so we wanted to keep “precision” as part of kwargs for box plots.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing tests.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50001][PYTHON][PS][CONNECT] Adjust "precision" to be part of kwargs for box plots [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #48513:
URL: https://github.com/apache/spark/pull/48513#issuecomment-2422559469
@xinrong-meng please rebase to enable a recent test image refactor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50001][PYTHON][PS][CONNECT] Adjust "precision" to be part of kwargs for box plots [spark]
Posted by "xinrong-meng (via GitHub)" <gi...@apache.org>.
xinrong-meng commented on PR #48513:
URL: https://github.com/apache/spark/pull/48513#issuecomment-2425523690
Merged to master, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50001][PYTHON][PS][CONNECT] Adjust "precision" to be part of kwargs for box plots [spark]
Posted by "xinrong-meng (via GitHub)" <gi...@apache.org>.
xinrong-meng commented on PR #48513:
URL: https://github.com/apache/spark/pull/48513#issuecomment-2425423660
Rebased, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50001][PYTHON][PS][CONNECT] Adjust "precision" to be part of kwargs for box plots [spark]
Posted by "xinrong-meng (via GitHub)" <gi...@apache.org>.
xinrong-meng commented on code in PR #48513:
URL: https://github.com/apache/spark/pull/48513#discussion_r1804454013
##########
python/pyspark/pandas/plot/core.py:
##########
@@ -857,13 +857,12 @@ def box(self, precision=0.01, **kwds):
Parameters
----------
- precision: scalar, default = 0.01
- This argument is used by pandas-on-Spark to compute approximate statistics
- for building a boxplot. Use *smaller* values to get more precise
- statistics.
**kwds : optional
Additional keyword arguments are documented in
:meth:`pyspark.pandas.Series.plot`.
+ One of the optional keyword arguments is `precision`, a float that is used by
Review Comment:
Sorry I might not fully understand what "numpydoc's kwargs styple" refers to here,
```
**kwds : dict, optional
Additional keyword arguments are documented in
:meth:`pyspark.pandas.Series.plot`.
precision: scalar, default = 0.01
This argument is used by pandas-on-Spark to compute approximate statistics
for building a boxplot. Use smaller values to get more precise
statistics.
```
is the above what we want?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50001][PYTHON][PS][CONNECT] Adjust "precision" to be part of kwargs for box plots [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #48513:
URL: https://github.com/apache/spark/pull/48513#discussion_r1804174312
##########
python/pyspark/pandas/plot/core.py:
##########
@@ -857,13 +857,12 @@ def box(self, precision=0.01, **kwds):
Parameters
----------
- precision: scalar, default = 0.01
- This argument is used by pandas-on-Spark to compute approximate statistics
- for building a boxplot. Use *smaller* values to get more precise
- statistics.
**kwds : optional
Additional keyword arguments are documented in
:meth:`pyspark.pandas.Series.plot`.
+ One of the optional keyword arguments is `precision`, a float that is used by
Review Comment:
Let's probably follow numpydoc's kwargs style (https://numpydoc.readthedocs.io/en/latest/format.html#parameters)
```
Additional arguments should be passed as keyword arguments
**kwargs : dict, optional
Extra arguments to `metric`: refer to each metric documentation for a
list of all possible arguments.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50001][PYTHON][PS][CONNECT] Adjust "precision" to be part of kwargs for box plots [spark]
Posted by "xinrong-meng (via GitHub)" <gi...@apache.org>.
xinrong-meng commented on code in PR #48513:
URL: https://github.com/apache/spark/pull/48513#discussion_r1805719382
##########
python/pyspark/pandas/plot/core.py:
##########
@@ -857,13 +857,12 @@ def box(self, precision=0.01, **kwds):
Parameters
----------
- precision: scalar, default = 0.01
- This argument is used by pandas-on-Spark to compute approximate statistics
- for building a boxplot. Use *smaller* values to get more precise
- statistics.
**kwds : optional
Additional keyword arguments are documented in
:meth:`pyspark.pandas.Series.plot`.
+ One of the optional keyword arguments is `precision`, a float that is used by
Review Comment:
I didn't realize `metric` in the example is a parameter like `precision`..
Thank you that's so clear!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50001][PYTHON][PS][CONNECT] Adjust "precision" to be part of kwargs for box plots [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #48513:
URL: https://github.com/apache/spark/pull/48513#discussion_r1805661354
##########
python/pyspark/pandas/plot/core.py:
##########
@@ -857,13 +857,12 @@ def box(self, precision=0.01, **kwds):
Parameters
----------
- precision: scalar, default = 0.01
- This argument is used by pandas-on-Spark to compute approximate statistics
- for building a boxplot. Use *smaller* values to get more precise
- statistics.
**kwds : optional
Additional keyword arguments are documented in
:meth:`pyspark.pandas.Series.plot`.
+ One of the optional keyword arguments is `precision`, a float that is used by
Review Comment:
I actually meant something like
```
**kwds : dict, optional
Extra arguments to `precision `: refer to a float that is used by ...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50001][PYTHON][PS][CONNECT] Adjust "precision" to be part of kwargs for box plots [spark]
Posted by "xinrong-meng (via GitHub)" <gi...@apache.org>.
xinrong-meng closed pull request #48513: [SPARK-50001][PYTHON][PS][CONNECT] Adjust "precision" to be part of kwargs for box plots
URL: https://github.com/apache/spark/pull/48513
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org