[GitHub] [pinot] FelixGV commented on pull request #7904: Shade a few dependencies in `pinot-spi` and `pinot-avro-base`

[GitBox <gi...@apache.org>]

FelixGV commented on pull request #7904:
URL: https://github.com/apache/pinot/pull/7904#issuecomment-994245642


   Note that shading Avro usually doesn't go well. If your usage of Avro is purely self-contained then it might work, but if you ever come across a case where you pass Avro objects from some shaded code to non-shaded code (or vice versa) running in a different version, that usually blows up. For example, if you pass a shaded record into a non-shaded datum writer of a different version, that would likely fail.
   
   If the issue is having multiple versions of Avro on the class path, then the cleaner solution would be to adopt [avro-util](https://github.com/linkedin/avro-util) 's compat helper, which makes the Avro-using code version-agnostic.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org