You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/13 17:35:32 UTC

[GitHub] [airflow] fllaca opened a new pull request #11511: Helm chart fixes in pod template

fllaca opened a new pull request #11511:
URL: https://github.com/apache/airflow/pull/11511


   I came with some little issues while testing the chart in this repo locally, here I'm bundling some fixes to them:
   
   - default pod_template image to `defaultAirflowRepository:defaultAirflowTag`
   - fix never-ending git-sync init containers
   - fix broken reference to volume
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] fllaca commented on a change in pull request #11511: Helm chart fixes in pod template

Posted by GitBox <gi...@apache.org>.
fllaca commented on a change in pull request #11511:
URL: https://github.com/apache/airflow/pull/11511#discussion_r504513822



##########
File path: chart/tests/pod-template-file_test.yaml
##########
@@ -22,14 +22,17 @@ tests:
     asserts:
       - isKind:
           of: Pod
-      - equal:
+      - isNotNull:
           path: spec.containers[0].image
-          value: dummy_image

Review comment:
       I couldn't find a way to assert that this value should be the default `defaultAirflowRepository` without hardcoding the test with `apache/airflow:1.10.12` (copying from values.yaml). If that hardcoded value in the assertion is fine, I can change the test back to `equal` assert.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] fllaca commented on a change in pull request #11511: Helm chart fixes in pod template

Posted by GitBox <gi...@apache.org>.
fllaca commented on a change in pull request #11511:
URL: https://github.com/apache/airflow/pull/11511#discussion_r504513822



##########
File path: chart/tests/pod-template-file_test.yaml
##########
@@ -22,14 +22,17 @@ tests:
     asserts:
       - isKind:
           of: Pod
-      - equal:
+      - isNotNull:
           path: spec.containers[0].image
-          value: dummy_image

Review comment:
       I could find a way to assert that this value should be the default `defaultAirflowRepository` without hardcoding the test with `apache/airflow:1.10.12` (copying from values.yaml). If that hardcoded value in the assertion is fine, I can change the test back to `equal` assert.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj merged pull request #11511: Helm chart fixes in pod template

Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #11511:
URL: https://github.com/apache/airflow/pull/11511


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #11511: Helm chart fixes in pod template

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11511:
URL: https://github.com/apache/airflow/pull/11511#issuecomment-707944941


   Hello @fllaca, Can you please rebase this one to latest master. We fixed (hopefully) a problem with queues of jobs for GitHub actions and I think when you rebase, it shoudl run much faster (more info on devlist shortly).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #11511: Helm chart fixes in pod template

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #11511:
URL: https://github.com/apache/airflow/pull/11511#issuecomment-712447068


   Awesome work, congrats on your first merged pull request!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on pull request #11511: Helm chart fixes in pod template

Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #11511:
URL: https://github.com/apache/airflow/pull/11511#issuecomment-712446046


   A very interesting change. I did not know the `GIT_ONE_TIME` option. Thanks for adding that. In our case, it very makes sense.
   
   I also see that you made sure that this change had good unit test coverage.  We are working to modernize our unit tests to overcome some of the limitations of Helm-unittest. One of its limitations even you have encountered - https://github.com/apache/airflow/pull/11511#discussion_r504513822
   I would be happy if you could share your experience on this ticket: https://github.com/apache/airflow/issues/11657
   Can you also help us?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #11511: Helm chart fixes in pod template

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11511:
URL: https://github.com/apache/airflow/pull/11511#issuecomment-707918318






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #11511: Helm chart fixes in pod template

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #11511:
URL: https://github.com/apache/airflow/pull/11511#issuecomment-707899995


   Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
   Here are some useful points:
   - Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
   - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
   - Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโ€™s a heavy docker but it ships with a working Airflow and a lot of integrations.
   - Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
   - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
   - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
   Apache Airflow is a community-driven project and together we are making it better ๐Ÿš€.
   In case of doubts contact the developers at:
   Mailing List: dev@airflow.apache.org
   Slack: https://s.apache.org/airflow-slack
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] fllaca commented on pull request #11511: Helm chart fixes in pod template

Posted by GitBox <gi...@apache.org>.
fllaca commented on pull request #11511:
URL: https://github.com/apache/airflow/pull/11511#issuecomment-708620965


   Hi @potiuk! thanks for taking a look to this. I just rebased and added some helm test. One of the kubernetes test is failing (`CI Build / K8s: 3.7 v1.17.5 image (pull_request)`), would you mind checking it? I went to the build logs but I'm not very sure what is wrong there and/or if it is related to the changes in this PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #11511: Helm chart fixes in pod template

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11511:
URL: https://github.com/apache/airflow/pull/11511#issuecomment-708249231


   [The Workflow run](https://github.com/apache/airflow/actions/runs/306060114) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org