You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@s2graph.apache.org by DO YUNG YOON <sh...@gmail.com> on 2016/05/28 06:26:35 UTC

[Discuss] Intermediate layer between inner abstraction and Rest API.

Hi folks.

I was playing around TinkerPop3 to resolve
https://issues.apache.org/jira/browse/S2GRAPH-72.

JongWook brought up this issue at
https://issues.apache.org/jira/browse/S2GRAPH-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15285099#comment-15285099,
and I think we should discuss if it is necessary and how our
intermediate layer should be.

I am +1 on provide intermediate layer, and suggesting following.


- S2Edge, S2Vertex, S2Graph, S2Query that expect scala primitive
types. also these are responsible to serialize to inner class and
deserialize from inner class(core.Vertex, core.Edge, ...).

- Make S2Edge/S2Vertex to extends Edge/Vertex from TinkerPop3's interface.


My opinion on S2Edge is that following(only for Edge to be simple).


case class S2Edge(graph: Graph, srcId: Any, tgtId: Any, labelName:
String, direction: String, props: Map[String, Any], ts: Long =
System.currentTimeMillis(), operation: String = "insert") extends
TP3's Edge


What do you guys think about this?