You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@netbeans.apache.org by mb...@apache.org on 2023/02/11 03:30:53 UTC

[netbeans] branch master updated: Removed creating of unused objects

This is an automated email from the ASF dual-hosted git repository.

mbien pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/netbeans.git


The following commit(s) were added to refs/heads/master by this push:
     new c00f2286d1 Removed creating of unused objects
     new 410710ec86 Merge pull request #5320 from tbw777/new2
c00f2286d1 is described below

commit c00f2286d17136231e7a9ea54a2edd88f58d05df
Author: Andrei Briukhov <an...@gmail.com>
AuthorDate: Sun Jan 8 14:14:25 2023 +0300

    Removed creating of unused objects
    
    To effictive use of memory and for clean code.
---
 .../modules/j2ee/ejbcore/action/HomeMethodGenerator.java      |  2 +-
 .../wizards/targetpanel/providers/JSFTargetPanelProvider.java |  3 +--
 .../wizards/targetpanel/providers/TagTargetPanelProvider.java |  3 +--
 .../wizards/targetpanel/providers/XmlOptionPanelManager.java  |  1 -
 .../modules/websvc/saas/codegen/j2ee/support/J2eeUtil.java    |  1 -
 .../org/netbeans/upgrade/systemoptions/ColorProcessor.java    |  1 -
 .../src/org/netbeans/upgrade/systemoptions/FileProcessor.java |  1 -
 .../netbeans/upgrade/systemoptions/HostPropertyProcessor.java |  1 -
 .../netbeans/upgrade/systemoptions/NbClassPathProcessor.java  |  1 -
 .../src/org/netbeans/upgrade/systemoptions/URLProcessor.java  |  1 -
 .../src/org/netbeans/modules/welcome/content/RSSFeed.java     |  1 -
 nbbuild/antsrc/org/netbeans/nbbuild/LocMakeNBM.java           |  2 +-
 .../modules/visual/anchor/DefaultAnchorShapeResolver.java     | 11 +++++------
 .../visual/graph/layout/hierarchicalsupport/LayeredGraph.java |  4 +---
 .../netbeans/modules/masterfs/ProvidedExtensionsProxy.java    |  1 -
 .../demosrc/org/netbeans/swing/tabcontrol/demo/TestFrame.java |  1 -
 .../org/netbeans/swing/tabcontrol/DefaultTabDataModel.java    |  2 --
 .../src/org/openide/filesystems/AbstractFolder.java           |  2 +-
 platform/print/src/org/netbeans/modules/print/ui/Preview.java |  3 +--
 .../heapwalk/details/jdk/image/ImageDetailProvider.java       |  1 -
 .../profiler/heapwalk/ui/ReferencesBrowserControllerUI.java   |  3 ---
 .../javascript2/jquery/editor/JQueryCodeCompletion.java       |  2 +-
 .../javascript2/requirejs/editor/RequireJSCodeCompletion.java |  2 +-
 23 files changed, 14 insertions(+), 36 deletions(-)

diff --git a/enterprise/j2ee.ejbcore/src/org/netbeans/modules/j2ee/ejbcore/action/HomeMethodGenerator.java b/enterprise/j2ee.ejbcore/src/org/netbeans/modules/j2ee/ejbcore/action/HomeMethodGenerator.java
index 72965c4aeb..a1890dbbf9 100644
--- a/enterprise/j2ee.ejbcore/src/org/netbeans/modules/j2ee/ejbcore/action/HomeMethodGenerator.java
+++ b/enterprise/j2ee.ejbcore/src/org/netbeans/modules/j2ee/ejbcore/action/HomeMethodGenerator.java
@@ -73,7 +73,7 @@ public class HomeMethodGenerator extends AbstractMethodGenerator {
 
         // remote interface
         if (generateRemote && remoteHome != null) {
-            List<String> exceptions = exceptions = new ArrayList<String>(methodModel.getExceptions());
+            List<String> exceptions = new ArrayList<>(methodModel.getExceptions());
             if (!methodModel.getExceptions().contains("java.rmi.RemoteException")) {
                 exceptions.add("java.rmi.RemoteException");
             }
diff --git a/enterprise/web.core/src/org/netbeans/modules/web/wizards/targetpanel/providers/JSFTargetPanelProvider.java b/enterprise/web.core/src/org/netbeans/modules/web/wizards/targetpanel/providers/JSFTargetPanelProvider.java
index 5a5caf1e5c..327b48c344 100644
--- a/enterprise/web.core/src/org/netbeans/modules/web/wizards/targetpanel/providers/JSFTargetPanelProvider.java
+++ b/enterprise/web.core/src/org/netbeans/modules/web/wizards/targetpanel/providers/JSFTargetPanelProvider.java
@@ -273,7 +273,6 @@ class JSFUIManager extends AbstractOptionPanelManager {
     {
         myFaceletsSyntaxButton = new JRadioButton();
         
-        GridBagConstraints gridBagConstraints = new GridBagConstraints();
         myFaceletsSyntaxButton.setSelected(true);
         getSegmentBox().setEnabled(false);
         myFaceletsSyntaxButton.setMnemonic(NbBundle.getMessage(
@@ -285,7 +284,7 @@ class JSFUIManager extends AbstractOptionPanelManager {
             }
         });
 
-        gridBagConstraints = new java.awt.GridBagConstraints();
+        GridBagConstraints gridBagConstraints = new GridBagConstraints();
         gridBagConstraints.gridx = 0;
         gridBagConstraints.gridy = gridy++;
         gridBagConstraints.insets = new java.awt.Insets(0, 6, 0, 0);
diff --git a/enterprise/web.core/src/org/netbeans/modules/web/wizards/targetpanel/providers/TagTargetPanelProvider.java b/enterprise/web.core/src/org/netbeans/modules/web/wizards/targetpanel/providers/TagTargetPanelProvider.java
index 55da880ee2..8a280b1cb2 100644
--- a/enterprise/web.core/src/org/netbeans/modules/web/wizards/targetpanel/providers/TagTargetPanelProvider.java
+++ b/enterprise/web.core/src/org/netbeans/modules/web/wizards/targetpanel/providers/TagTargetPanelProvider.java
@@ -248,9 +248,8 @@ class TagUIManager extends XmlOptionPanelManager {
                 "A11Y_AddToTLD_mnem").charAt(0));
         myTldCheckBox.setText(NbBundle.getMessage(TagTargetPanelProvider.class, 
                 "OPT_addTagFileToTLD"));
-        
+
         GridBagConstraints gridBagConstraints = new GridBagConstraints();
-        gridBagConstraints = new java.awt.GridBagConstraints();
         gridBagConstraints.gridx = 0;
         gridBagConstraints.gridy = 3;
         gridBagConstraints.gridwidth = 4;
diff --git a/enterprise/web.core/src/org/netbeans/modules/web/wizards/targetpanel/providers/XmlOptionPanelManager.java b/enterprise/web.core/src/org/netbeans/modules/web/wizards/targetpanel/providers/XmlOptionPanelManager.java
index c47c32e45b..b1b0e4d278 100644
--- a/enterprise/web.core/src/org/netbeans/modules/web/wizards/targetpanel/providers/XmlOptionPanelManager.java
+++ b/enterprise/web.core/src/org/netbeans/modules/web/wizards/targetpanel/providers/XmlOptionPanelManager.java
@@ -64,7 +64,6 @@ abstract class XmlOptionPanelManager extends AbstractOptionPanelManager {
         });
 
         GridBagConstraints gridBagConstraints = new GridBagConstraints();
-        gridBagConstraints = new java.awt.GridBagConstraints();
         gridBagConstraints.gridx = 0;
         gridBagConstraints.gridy = gridy++;
         gridBagConstraints.insets = new java.awt.Insets(0, 6, 0, 0);
diff --git a/enterprise/websvc.saas.codegen.j2ee/src/org/netbeans/modules/websvc/saas/codegen/j2ee/support/J2eeUtil.java b/enterprise/websvc.saas.codegen.j2ee/src/org/netbeans/modules/websvc/saas/codegen/j2ee/support/J2eeUtil.java
index 9caf1f4c73..b99517e259 100644
--- a/enterprise/websvc.saas.codegen.j2ee/src/org/netbeans/modules/websvc/saas/codegen/j2ee/support/J2eeUtil.java
+++ b/enterprise/websvc.saas.codegen.j2ee/src/org/netbeans/modules/websvc/saas/codegen/j2ee/support/J2eeUtil.java
@@ -509,7 +509,6 @@ public class J2eeUtil {
 
     public static void addServletAnnotation(JavaSource javaSource, final String servletName, final String urlPattern)
         throws IOException {
-        final String[] seiClass = new String[1];
         final CancellableTask<WorkingCopy> modificationTask = new CancellableTask<WorkingCopy>() {
 
             public void cancel() {
diff --git a/nb/o.n.upgrader/src/org/netbeans/upgrade/systemoptions/ColorProcessor.java b/nb/o.n.upgrader/src/org/netbeans/upgrade/systemoptions/ColorProcessor.java
index aac9a5868f..38ad1a8c84 100644
--- a/nb/o.n.upgrader/src/org/netbeans/upgrade/systemoptions/ColorProcessor.java
+++ b/nb/o.n.upgrader/src/org/netbeans/upgrade/systemoptions/ColorProcessor.java
@@ -36,7 +36,6 @@ class ColorProcessor extends PropertyProcessor {
     
     
     void processPropertyImpl(String propertyName, Object value) {
-        StringBuffer sb = new StringBuffer();
         if ("connectionBorderColor".equals(propertyName)||
                 "dragBorderColor".equals(propertyName)||
                 "formDesignerBackgroundColor".equals(propertyName)||
diff --git a/nb/o.n.upgrader/src/org/netbeans/upgrade/systemoptions/FileProcessor.java b/nb/o.n.upgrader/src/org/netbeans/upgrade/systemoptions/FileProcessor.java
index e017ac8807..b681edf2b7 100644
--- a/nb/o.n.upgrader/src/org/netbeans/upgrade/systemoptions/FileProcessor.java
+++ b/nb/o.n.upgrader/src/org/netbeans/upgrade/systemoptions/FileProcessor.java
@@ -31,7 +31,6 @@ class FileProcessor extends PropertyProcessor {
     }
 
     void processPropertyImpl(String propertyName, Object value) {
-        StringBuffer sb = new StringBuffer();
         if ("antHome".equals(propertyName) || "projectsFolder".equals(propertyName)) {//NOI18N
             List l = ((SerParser.ObjectWrapper)value).data;
             for (Iterator it = l.iterator(); it.hasNext();) {
diff --git a/nb/o.n.upgrader/src/org/netbeans/upgrade/systemoptions/HostPropertyProcessor.java b/nb/o.n.upgrader/src/org/netbeans/upgrade/systemoptions/HostPropertyProcessor.java
index 58450454c5..4c4c553193 100644
--- a/nb/o.n.upgrader/src/org/netbeans/upgrade/systemoptions/HostPropertyProcessor.java
+++ b/nb/o.n.upgrader/src/org/netbeans/upgrade/systemoptions/HostPropertyProcessor.java
@@ -34,7 +34,6 @@ class HostPropertyProcessor extends PropertyProcessor {
     }
     
     void processPropertyImpl(String propertyName, Object value) {
-        StringBuffer sb = new StringBuffer();
         if ("hostProperty".equals(propertyName)) {//NOI18N
             List l = ((SerParser.ObjectWrapper)value).data;
             for (Iterator it = l.iterator(); it.hasNext();) {
diff --git a/nb/o.n.upgrader/src/org/netbeans/upgrade/systemoptions/NbClassPathProcessor.java b/nb/o.n.upgrader/src/org/netbeans/upgrade/systemoptions/NbClassPathProcessor.java
index 941056bc4d..7b520f6434 100644
--- a/nb/o.n.upgrader/src/org/netbeans/upgrade/systemoptions/NbClassPathProcessor.java
+++ b/nb/o.n.upgrader/src/org/netbeans/upgrade/systemoptions/NbClassPathProcessor.java
@@ -31,7 +31,6 @@ class NbClassPathProcessor extends PropertyProcessor {
     }
 
     void processPropertyImpl(String propertyName, Object value) {
-        StringBuffer sb = new StringBuffer();
         List l = ((SerParser.ObjectWrapper)value).data;
         for (Iterator it = l.iterator(); it.hasNext();) {
             Object elem = (Object) it.next();
diff --git a/nb/o.n.upgrader/src/org/netbeans/upgrade/systemoptions/URLProcessor.java b/nb/o.n.upgrader/src/org/netbeans/upgrade/systemoptions/URLProcessor.java
index 9fe0568653..0c1e45ff3f 100644
--- a/nb/o.n.upgrader/src/org/netbeans/upgrade/systemoptions/URLProcessor.java
+++ b/nb/o.n.upgrader/src/org/netbeans/upgrade/systemoptions/URLProcessor.java
@@ -33,7 +33,6 @@ class URLProcessor extends PropertyProcessor {
     }
     
     void processPropertyImpl(String propertyName, Object value) {
-        StringBuffer sb = new StringBuffer();       
         if ("mainProjectURL".equals(propertyName)) {//NOI18N
             List l = ((SerParser.ObjectWrapper)value).data;
             try {
diff --git a/nb/welcome/src/org/netbeans/modules/welcome/content/RSSFeed.java b/nb/welcome/src/org/netbeans/modules/welcome/content/RSSFeed.java
index 9458a6d53e..ad931d1ff3 100644
--- a/nb/welcome/src/org/netbeans/modules/welcome/content/RSSFeed.java
+++ b/nb/welcome/src/org/netbeans/modules/welcome/content/RSSFeed.java
@@ -141,7 +141,6 @@ public class RSSFeed extends JPanel implements Constants, PropertyChangeListener
     
     public void setContent( Component content ) {
         removeAll();
-        Dimension d = new Dimension();
         add( content, BorderLayout.CENTER );
         firePropertyChange( FEED_CONTENT_PROPERTY, null, content );
         revalidate();
diff --git a/nbbuild/antsrc/org/netbeans/nbbuild/LocMakeNBM.java b/nbbuild/antsrc/org/netbeans/nbbuild/LocMakeNBM.java
index 970077f603..1ea526a306 100644
--- a/nbbuild/antsrc/org/netbeans/nbbuild/LocMakeNBM.java
+++ b/nbbuild/antsrc/org/netbeans/nbbuild/LocMakeNBM.java
@@ -354,7 +354,7 @@ public class LocMakeNBM extends Task {
   protected void addLocalePatterns( LinkedList<String> list,
 				    String loc) {
 //    String dir = new String() ;
-    String re = new String() ;
+    String re;
 
 
 //    dir = mainDir ;        // modified for clusterization
diff --git a/platform/api.visual/src/org/netbeans/modules/visual/anchor/DefaultAnchorShapeResolver.java b/platform/api.visual/src/org/netbeans/modules/visual/anchor/DefaultAnchorShapeResolver.java
index aeb89e5556..6eb6a72cf5 100644
--- a/platform/api.visual/src/org/netbeans/modules/visual/anchor/DefaultAnchorShapeResolver.java
+++ b/platform/api.visual/src/org/netbeans/modules/visual/anchor/DefaultAnchorShapeResolver.java
@@ -49,11 +49,11 @@ public class DefaultAnchorShapeResolver implements AnchorShapeLocationResolver
         this.attachedEnd = attachedTo;
         this.attachedWidget = attachedWidget;
     }
-    
+
     public int getEndLocation()
     {
-        int retVal = 0;
-        
+        int retVal;
+
         if(attachedWidget != null)
         {
             Rectangle bounds = attachedWidget.getBounds();
@@ -61,8 +61,7 @@ public class DefaultAnchorShapeResolver implements AnchorShapeLocationResolver
         }
         else
         {
-//            Rectangle bounds = attachedWidget.getBounds();
-            Rectangle bounds = new Rectangle();
+            Rectangle bounds;
             if(attachedEnd == ConnectionEnd.SOURCE)
             {
                 Widget sourceWidget = getConnection().getSourceAnchor().getRelatedWidget();
@@ -75,7 +74,7 @@ public class DefaultAnchorShapeResolver implements AnchorShapeLocationResolver
             }
             retVal = getLocation(bounds);
         }
-        
+
         return retVal;
     }
 
diff --git a/platform/api.visual/src/org/netbeans/modules/visual/graph/layout/hierarchicalsupport/LayeredGraph.java b/platform/api.visual/src/org/netbeans/modules/visual/graph/layout/hierarchicalsupport/LayeredGraph.java
index 4b16c974ba..6b19ea6862 100644
--- a/platform/api.visual/src/org/netbeans/modules/visual/graph/layout/hierarchicalsupport/LayeredGraph.java
+++ b/platform/api.visual/src/org/netbeans/modules/visual/graph/layout/hierarchicalsupport/LayeredGraph.java
@@ -168,8 +168,7 @@ public class LayeredGraph<N, E> {
         int upperLayerSize = upperLayer.size();
         int lowerLayerSize = lowerLayer.size();
         float lowerBarycenters[] = new float[lowerLayerSize];
-        
-        float[] barycenters = new float[lowerLayerSize];
+
         for (int k = 0; k < lowerLayerSize; k++) {
             float sum = 0;
             float count = 0;
@@ -182,7 +181,6 @@ public class LayeredGraph<N, E> {
             }
             Vertex<N> kv = lowerLayer.get(k);
             lowerBarycenters[k] = sum/count;
-            //System.out.println("kv = " + kv + " barycenter = " + lowerBarycenters[k]);
         }
         
         return lowerBarycenters;
diff --git a/platform/masterfs/src/org/netbeans/modules/masterfs/ProvidedExtensionsProxy.java b/platform/masterfs/src/org/netbeans/modules/masterfs/ProvidedExtensionsProxy.java
index 204a0f2571..66e09ca072 100644
--- a/platform/masterfs/src/org/netbeans/modules/masterfs/ProvidedExtensionsProxy.java
+++ b/platform/masterfs/src/org/netbeans/modules/masterfs/ProvidedExtensionsProxy.java
@@ -79,7 +79,6 @@ public class ProvidedExtensionsProxy extends ProvidedExtensions {
     }
     
     public ProvidedExtensions.IOHandler getRenameHandler(final File from, final String newName) {
-        final File to = new File(from.getParentFile(), newName);
         IOHandler retValue = null;
         for (Iterator<BaseAnnotationProvider> it = annotationProviders.iterator(); it.hasNext() && retValue == null;) {
             BaseAnnotationProvider provider = it.next();
diff --git a/platform/o.n.swing.tabcontrol/demosrc/org/netbeans/swing/tabcontrol/demo/TestFrame.java b/platform/o.n.swing.tabcontrol/demosrc/org/netbeans/swing/tabcontrol/demo/TestFrame.java
index 926bf46397..cef8844b77 100644
--- a/platform/o.n.swing.tabcontrol/demosrc/org/netbeans/swing/tabcontrol/demo/TestFrame.java
+++ b/platform/o.n.swing.tabcontrol/demosrc/org/netbeans/swing/tabcontrol/demo/TestFrame.java
@@ -189,7 +189,6 @@ public class TestFrame extends javax.swing.JFrame {
         
         jb9.addActionListener(new ActionListener() {
             public void actionPerformed(ActionEvent ae) {
-                int[] idxs = new int [] { 1, 3, 6, 8};
                 TabData[] td = new TabData[] {
                     new TabData(new JButton("inserted c 1"), myIcon, "Ic-1", "tip"),
                     new TabData(new JButton("inserted c 2"), myIcon, "Ic-2", "tip"),
diff --git a/platform/o.n.swing.tabcontrol/src/org/netbeans/swing/tabcontrol/DefaultTabDataModel.java b/platform/o.n.swing.tabcontrol/src/org/netbeans/swing/tabcontrol/DefaultTabDataModel.java
index b7812bef2a..66e1759e5b 100644
--- a/platform/o.n.swing.tabcontrol/src/org/netbeans/swing/tabcontrol/DefaultTabDataModel.java
+++ b/platform/o.n.swing.tabcontrol/src/org/netbeans/swing/tabcontrol/DefaultTabDataModel.java
@@ -93,8 +93,6 @@ public class DefaultTabDataModel implements TabDataModel {
             return;
         }
 
-        List newContents = Arrays.asList(data);
-
         list.clear();
         list.addAll(Arrays.asList(data));
 
diff --git a/platform/openide.filesystems/src/org/openide/filesystems/AbstractFolder.java b/platform/openide.filesystems/src/org/openide/filesystems/AbstractFolder.java
index 34aa19e1e5..cedd91e920 100644
--- a/platform/openide.filesystems/src/org/openide/filesystems/AbstractFolder.java
+++ b/platform/openide.filesystems/src/org/openide/filesystems/AbstractFolder.java
@@ -820,7 +820,7 @@ abstract class AbstractFolder extends FileObject {
                 fire && (added == null) && (removed == null) && !getFileSystem().isReadOnly() &&
                     !(this instanceof MultiFileObject)
             ) {
-                Set<String> nameFilter = nameFilter = new HashSet<String>();
+                Set<String> nameFilter = new HashSet<>();
 
                 if (addedNames != null) {
                     nameFilter.addAll(addedNames);
diff --git a/platform/print/src/org/netbeans/modules/print/ui/Preview.java b/platform/print/src/org/netbeans/modules/print/ui/Preview.java
index 0926e04f08..57ea25e375 100644
--- a/platform/print/src/org/netbeans/modules/print/ui/Preview.java
+++ b/platform/print/src/org/netbeans/modules/print/ui/Preview.java
@@ -186,11 +186,10 @@ public final class Preview extends Dialog implements Percent.Listener {
     }
 
     private JComponent createNavigatePanel() {
-        JPanel panel = new JPanel(new GridBagLayout());
         GridBagConstraints c = new GridBagConstraints();
 
         // first
-        panel = new JPanel(new GridBagLayout());
+        JPanel panel = new JPanel(new GridBagLayout());
         c.insets = new Insets(TINY_SIZE, TINY_SIZE, TINY_SIZE, TINY_SIZE);
         myFirst = createButton(
             new ButtonAction(icon(Config.class, "first"), i18n("TLT_First")) { // NOI18N
diff --git a/profiler/profiler.heapwalker/src/org/netbeans/modules/profiler/heapwalk/details/jdk/image/ImageDetailProvider.java b/profiler/profiler.heapwalker/src/org/netbeans/modules/profiler/heapwalk/details/jdk/image/ImageDetailProvider.java
index a64bd28fbd..cc88c8c5d7 100644
--- a/profiler/profiler.heapwalker/src/org/netbeans/modules/profiler/heapwalk/details/jdk/image/ImageDetailProvider.java
+++ b/profiler/profiler.heapwalker/src/org/netbeans/modules/profiler/heapwalk/details/jdk/image/ImageDetailProvider.java
@@ -129,7 +129,6 @@ public class ImageDetailProvider extends DetailsProvider.Basic {
 
         @Override
         protected void computeView(Instance instance, Heap heap) {
-            FieldAccessor fa = new FieldAccessor(heap, BUILDERS);
             Image image = null;
             JLabel label = null;
             try {
diff --git a/profiler/profiler.heapwalker/src/org/netbeans/modules/profiler/heapwalk/ui/ReferencesBrowserControllerUI.java b/profiler/profiler.heapwalker/src/org/netbeans/modules/profiler/heapwalk/ui/ReferencesBrowserControllerUI.java
index 19931f3f9e..64bcb3a2cd 100644
--- a/profiler/profiler.heapwalker/src/org/netbeans/modules/profiler/heapwalk/ui/ReferencesBrowserControllerUI.java
+++ b/profiler/profiler.heapwalker/src/org/netbeans/modules/profiler/heapwalk/ui/ReferencesBrowserControllerUI.java
@@ -354,9 +354,6 @@ public class ReferencesBrowserControllerUI extends JTitledPanel {
             });
             // --- 
         } else {
-            Object[] shortPath = new Object[length];
-            System.arraycopy(path, 0, shortPath, 0, length);
-            final TreePath p = new TreePath(shortPath);
             SwingUtilities.invokeLater(new Runnable() {
                 public void run() {
                     selectPath(path, length + MAX_STEP);
diff --git a/webcommon/javascript2.jquery/src/org/netbeans/modules/javascript2/jquery/editor/JQueryCodeCompletion.java b/webcommon/javascript2.jquery/src/org/netbeans/modules/javascript2/jquery/editor/JQueryCodeCompletion.java
index ef232bd30b..36d614d3c5 100644
--- a/webcommon/javascript2.jquery/src/org/netbeans/modules/javascript2/jquery/editor/JQueryCodeCompletion.java
+++ b/webcommon/javascript2.jquery/src/org/netbeans/modules/javascript2/jquery/editor/JQueryCodeCompletion.java
@@ -577,7 +577,7 @@ public class JQueryCodeCompletion implements CompletionProvider {
     }
 
     private Collection<HtmlTag> getHtmlTags(String prefix) {
-        Collection<HtmlTag> result = Collections.emptyList();
+        Collection<HtmlTag> result;
         HtmlModel htmlModel = HtmlModelFactory.getModel(HtmlVersion.HTML5);
         Collection<HtmlTag> allTags = htmlModel.getAllTags();
         if (prefix.isEmpty()) {
diff --git a/webcommon/javascript2.requirejs/src/org/netbeans/modules/javascript2/requirejs/editor/RequireJSCodeCompletion.java b/webcommon/javascript2.requirejs/src/org/netbeans/modules/javascript2/requirejs/editor/RequireJSCodeCompletion.java
index f12f60df64..b89f5defd6 100644
--- a/webcommon/javascript2.requirejs/src/org/netbeans/modules/javascript2/requirejs/editor/RequireJSCodeCompletion.java
+++ b/webcommon/javascript2.requirejs/src/org/netbeans/modules/javascript2/requirejs/editor/RequireJSCodeCompletion.java
@@ -174,7 +174,7 @@ public class RequireJSCodeCompletion implements CompletionProvider {
                 }
 
                 if (relativeTo.isEmpty()) {
-                    Collection<String> basePaths = new ArrayList<String>();
+                    Collection<String> basePaths;
                     if (rIndex != null) {
                         basePaths = rIndex.getBasePaths();
                         relativeTo.add(fo.getParent());


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@netbeans.apache.org
For additional commands, e-mail: commits-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists