You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by "rahulbcn27 (via GitHub)" <gi...@apache.org> on 2023/01/27 12:29:02 UTC
[GitHub] [cloudstack-terraform-provider] rahulbcn27 opened a new pull request, #49: Rahulbcn27 GitHub actions 1
rahulbcn27 opened a new pull request, #49:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/49
Created Github-Actions build.yml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-terraform-provider] rohityadavcloud commented on pull request #49: Rahulbcn27 GitHub actions 1
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #49:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/49#issuecomment-1408335670
@rahulbcn27 could you review https://github.com/apache/cloudstack-terraform-provider#testing-the-provider
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-terraform-provider] rohityadavcloud commented on a diff in pull request #49: Rahulbcn27 GitHub actions 1
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on code in PR #49:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/49#discussion_r1090419904
##########
.github/workflows/build.yml:
##########
@@ -0,0 +1,26 @@
+name: Build-Check
+
+on: [push, pull_request]
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
+ cancel-in-progress: true
+
+jobs:
+ build:
+ runs-on: ubuntu-22.04
+
+ steps:
+ - uses: actions/checkout@v3
+
+ - name: Set up Go
+ uses: actions/setup-go@v3
+ with:
+ go-version: 1.16.x
Review Comment:
Should we bump the version to latest?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-terraform-provider] rohityadavcloud commented on a diff in pull request #49: Rahulbcn27 GitHub actions 1
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on code in PR #49:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/49#discussion_r1090418118
##########
.github/workflows/build.yml:
##########
@@ -0,0 +1,26 @@
+name: Build-Check
Review Comment:
@rahulbcn27 pl add license
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-terraform-provider] rohityadavcloud merged pull request #49: Rahulbcn27 GitHub actions 1
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud merged PR #49:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/49
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-terraform-provider] rahulbcn27 commented on pull request #49: Rahulbcn27 GitHub actions 1
Posted by "rahulbcn27 (via GitHub)" <gi...@apache.org>.
rahulbcn27 commented on PR #49:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/49#issuecomment-1406437533
@rohityadavcloud Please review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-terraform-provider] rahulbcn27 commented on a diff in pull request #49: Rahulbcn27 GitHub actions 1
Posted by "rahulbcn27 (via GitHub)" <gi...@apache.org>.
rahulbcn27 commented on code in PR #49:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/49#discussion_r1090435227
##########
.github/workflows/build.yml:
##########
@@ -0,0 +1,26 @@
+name: Build-Check
Review Comment:
license added
##########
.github/workflows/build.yml:
##########
@@ -0,0 +1,26 @@
+name: Build-Check
+
+on: [push, pull_request]
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
+ cancel-in-progress: true
+
+jobs:
+ build:
+ runs-on: ubuntu-22.04
+
+ steps:
+ - uses: actions/checkout@v3
+
+ - name: Set up Go
+ uses: actions/setup-go@v3
+ with:
+ go-version: 1.16.x
Review Comment:
version updated to 1.19.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-terraform-provider] rohityadavcloud commented on pull request #49: Rahulbcn27 GitHub actions 1
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #49:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/49#issuecomment-1408364806
For basic build and unit tests this is good. However, we need to explore if some basic CI/CD using https://github.com/apache/cloudstack-terraform-provider#testing-the-provider (simulator) can be achieved as well. I'll merge this but explore further with @rahulbcn27 about this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org