You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Zack Shoylev <no...@github.com> on 2014/03/25 17:06:16 UTC
[jclouds-labs-openstack] OS Neutron Extension Router (#83)
Original PR here: https://github.com/jclouds/jclouds-labs-openstack/pull/47
This rebases so it can be merged. No further changes in this PR.
You can merge this Pull Request by running:
git pull https://github.com/rackerlabs/jclouds-labs-openstack os-neutron-router
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-labs-openstack/pull/83
-- Commit Summary --
* OS Neutron Extension Router
-- File Changes --
M openstack-neutron/pom.xml (1)
M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/NeutronApi.java (8)
A openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/domain/ExternalGatewayInfo.java (105)
M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/domain/Network.java (2)
M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/domain/NetworkType.java (6)
M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/domain/Port.java (4)
A openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/domain/Router.java (151)
A openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/domain/RouterInterface.java (127)
M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/domain/Subnet.java (10)
A openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/extensions/RouterApi.java (217)
M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/features/NetworkApi.java (13)
M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/features/PortApi.java (13)
M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/features/SubnetApi.java (13)
M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/functions/ParseNetworkDetails.java (6)
M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/functions/ParseNetworks.java (6)
M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/functions/ParsePortDetails.java (6)
M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/functions/ParsePorts.java (6)
A openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/functions/ParseRouterDetails.java (93)
A openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/functions/ParseRouters.java (93)
M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/functions/ParseSubnetDetails.java (6)
M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/functions/ParseSubnets.java (6)
A openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/options/CreateRouterOptions.java (168)
A openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/options/EmptyOptions.java (48)
A openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/options/UpdateRouterOptions.java (168)
A openstack-neutron/src/test/java/org/jclouds/openstack/neutron/v2_0/extensions/RouterApiExpectTest.java (295)
A openstack-neutron/src/test/java/org/jclouds/openstack/neutron/v2_0/extensions/RouterApiLiveTest.java (192)
M openstack-neutron/src/test/java/org/jclouds/openstack/neutron/v2_0/features/NetworkApiLiveTest.java (8)
M openstack-neutron/src/test/java/org/jclouds/openstack/neutron/v2_0/features/PortApiLiveTest.java (25)
M openstack-neutron/src/test/java/org/jclouds/openstack/neutron/v2_0/features/SubnetApiLiveTest.java (23)
A openstack-neutron/src/test/java/org/jclouds/openstack/neutron/v2_0/parse/ParseRouterTest.java (55)
A openstack-neutron/src/test/java/org/jclouds/openstack/neutron/v2_0/util/ClassUtil.java (43)
A openstack-neutron/src/test/java/org/jclouds/openstack/neutron/v2_0/util/PredicateUtil.java (51)
A openstack-neutron/src/test/resources/list_routers.json (74)
A openstack-neutron/src/test/resources/router.json (7)
-- Patch Links --
https://github.com/jclouds/jclouds-labs-openstack/pull/83.patch
https://github.com/jclouds/jclouds-labs-openstack/pull/83.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/83
Re: [jclouds-labs-openstack] OS Neutron Extension Router (#83)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-openstack #948](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/948/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/83#issuecomment-38585259
Re: [jclouds-labs-openstack] OS Neutron Extension Router (#83)
Posted by Andrew Phillips <no...@github.com>.
> I think this might fix the checkstyle violations
Yes, that looks good, thanks!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/83#issuecomment-38883181
Re: [jclouds-labs-openstack] OS Neutron Extension Router (#83)
Posted by Zack Shoylev <no...@github.com>.
@demobox : Glance tests were fixed in another PR. I am working on follow up PRs and trying to determine scope. Thanks for reminding me about the needed checkstyle fixes. I will try to keep it in mind! :)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/83#issuecomment-38750900
Re: [jclouds-labs-openstack] OS Neutron Extension Router (#83)
Posted by Zack Shoylev <no...@github.com>.
merged
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/83#issuecomment-38584885
Re: [jclouds-labs-openstack] OS Neutron Extension Router (#83)
Posted by Jeremy Daggett <no...@github.com>.
@demobox @zack-shoylev The broken Glance tests were addressed in PR https://github.com/jclouds/jclouds-labs-openstack/pull/84 HTH :)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/83#issuecomment-38808620
Re: [jclouds-labs-openstack] OS Neutron Extension Router (#83)
Posted by Zack Shoylev <no...@github.com>.
Closed #83.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/83
Re: [jclouds-labs-openstack] OS Neutron Extension Router (#83)
Posted by Zack Shoylev <no...@github.com>.
> jclouds » jclouds-labs-openstack #948 UNSTABLE
known unrelated issue
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/83#issuecomment-38585722
Re: [jclouds-labs-openstack] OS Neutron Extension Router (#83)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-openstack-pull-requests #185](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/185/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/83#issuecomment-38585771
Re: [jclouds-labs-openstack] OS Neutron Extension Router (#83)
Posted by Andrew Phillips <no...@github.com>.
> jclouds-labs-openstack-pull-requests #185 UNSTABLE
Glance tests [are failing](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/org.apache.jclouds.labs$openstack-glance/185/testReport/) - I guess you are expecting that, @zack-shoylev?
If I recall, we had a follow-up PR to this planned soon. Could we address the following [Checkstyle violations](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/185/org.apache.jclouds.labs$openstack-neutron/violations/) that we have introduced with this PR? Thanks!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/83#issuecomment-38744058
Re: [jclouds-labs-openstack] OS Neutron Extension Router (#83)
Posted by Zack Shoylev <no...@github.com>.
@demobox I think this might fix the checkstyle violations: https://github.com/jclouds/jclouds-labs-openstack/pull/86
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/83#issuecomment-38875095