You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/09/23 01:11:35 UTC

[GitHub] [iotdb] Beyyes commented on a diff in pull request #7403: [IOTDB-4080] Change the port name of show cluster, show regions, show confignodes, show datandoes; make running result of `Remove-datanode.sh` clear

Beyyes commented on code in PR #7403:
URL: https://github.com/apache/iotdb/pull/7403#discussion_r978195951


##########
server/src/main/java/org/apache/iotdb/db/mpp/common/header/ColumnHeaderConstant.java:
##########
@@ -200,7 +202,7 @@ public class ColumnHeaderConstant {
           new ColumnHeader(COLUMN_SERIES_SLOTS, TSDataType.INT64),
           new ColumnHeader(COLUMN_TIME_SLOTS, TSDataType.INT64),
           new ColumnHeader(COLUMN_DATANODE_ID, TSDataType.INT32),
-          new ColumnHeader(COLUMN_HOST, TSDataType.TEXT),
+          new ColumnHeader(COLUMN_RPC_PORT, TSDataType.TEXT),
           new ColumnHeader(COLUMN_PORT, TSDataType.INT32),

Review Comment:
   i will remove is and add test screenshot



##########
server/src/main/java/org/apache/iotdb/db/mpp/common/header/ColumnHeaderConstant.java:
##########
@@ -200,7 +202,7 @@ public class ColumnHeaderConstant {
           new ColumnHeader(COLUMN_SERIES_SLOTS, TSDataType.INT64),
           new ColumnHeader(COLUMN_TIME_SLOTS, TSDataType.INT64),
           new ColumnHeader(COLUMN_DATANODE_ID, TSDataType.INT32),
-          new ColumnHeader(COLUMN_HOST, TSDataType.TEXT),
+          new ColumnHeader(COLUMN_RPC_PORT, TSDataType.TEXT),
           new ColumnHeader(COLUMN_PORT, TSDataType.INT32),

Review Comment:
   i will remove it and add test screenshot



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org