You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/27 12:35:41 UTC
[GitHub] [airflow] uranusjr commented on a change in pull request #19853: Remove some more redundant parentheses
uranusjr commented on a change in pull request #19853:
URL: https://github.com/apache/airflow/pull/19853#discussion_r757777109
##########
File path: airflow/_vendor/connexion/operations/openapi.py
##########
@@ -197,7 +197,7 @@ def example_response(self, status_code=None, content_type=None):
except (KeyError, IndexError):
pass
try:
- return (deep_get(self._responses, example_path), status_code)
+ return deep_get(self._responses, example_path), status_code
Review comment:
I’d prefer keeping this, or split this into two lines
```python
response = deep_get(self._responses, example_path)
return response, status_code
```
otherwise it is too easy to miss this is actually returning a tuple.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org