You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2017/11/10 01:43:05 UTC
Review Request 63713: Restart all required services failed when
running cluster with several patch upgrades applied
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63713/
-----------------------------------------------------------
Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
Bugs: AMBARI-22411
https://issues.apache.org/jira/browse/AMBARI-22411
Repository: ambari
Description
-------
Small refactor to pass StackID instead of RepositoryVersionEntity, negating the check that made this call fail.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java d8712f2c75
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 5ea4bbdf3d
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 1ec790f7cc
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json 23c6d32dff
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java c80620f6a3
Diff: https://reviews.apache.org/r/63713/diff/1/
Testing
-------
Manual.
Unit tests pending.
Thanks,
Nate Cole
Re: Review Request 63713: Restart all required services failed when
running cluster with several patch upgrades applied
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63713/#review190670
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Nov. 9, 2017, 8:43 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63713/
> -----------------------------------------------------------
>
> (Updated Nov. 9, 2017, 8:43 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
>
>
> Bugs: AMBARI-22411
> https://issues.apache.org/jira/browse/AMBARI-22411
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Small refactor to pass StackID instead of RepositoryVersionEntity, negating the check that made this call fail.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java d8712f2c75
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 5ea4bbdf3d
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 1ec790f7cc
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json 23c6d32dff
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java c80620f6a3
>
>
> Diff: https://reviews.apache.org/r/63713/diff/1/
>
>
> Testing
> -------
>
> Manual.
> Unit tests pending. Mostly verify that existing tests continue to work without error.
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 63713: Restart all required services failed when
running cluster with several patch upgrades applied
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63713/#review190701
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Nov. 10, 2017, 3:43 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63713/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2017, 3:43 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
>
>
> Bugs: AMBARI-22411
> https://issues.apache.org/jira/browse/AMBARI-22411
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Small refactor to pass StackID instead of RepositoryVersionEntity, negating the check that made this call fail.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java d8712f2c75
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 5ea4bbdf3d
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 1ec790f7cc
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json 23c6d32dff
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java c80620f6a3
>
>
> Diff: https://reviews.apache.org/r/63713/diff/1/
>
>
> Testing
> -------
>
> Manual.
> Unit tests pending. Mostly verify that existing tests continue to work without error.
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 63713: Restart all required services failed when
running cluster with several patch upgrades applied
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63713/#review190669
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json
Line 1280 (original), 1280 (patched)
<https://reviews.apache.org/r/63713/#comment268233>
I think Tez can go by itself...
- Jonathan Hurley
On Nov. 9, 2017, 8:43 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63713/
> -----------------------------------------------------------
>
> (Updated Nov. 9, 2017, 8:43 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
>
>
> Bugs: AMBARI-22411
> https://issues.apache.org/jira/browse/AMBARI-22411
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Small refactor to pass StackID instead of RepositoryVersionEntity, negating the check that made this call fail.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java d8712f2c75
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 5ea4bbdf3d
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 1ec790f7cc
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json 23c6d32dff
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java c80620f6a3
>
>
> Diff: https://reviews.apache.org/r/63713/diff/1/
>
>
> Testing
> -------
>
> Manual.
> Unit tests pending. Mostly verify that existing tests continue to work without error.
>
>
> Thanks,
>
> Nate Cole
>
>