You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Eric Evans (JIRA)" <ji...@apache.org> on 2009/04/27 03:46:30 UTC

[jira] Created: (THRIFT-467) C# libraries fail to build

C# libraries fail to build
--------------------------

                 Key: THRIFT-467
                 URL: https://issues.apache.org/jira/browse/THRIFT-467
             Project: Thrift
          Issue Type: Bug
          Components: Library (C#)
         Environment: Debian unstable/testing, mono 2.0.1
            Reporter: Eric Evans


{quote}
/usr/bin/make -C /home/eevans/git/thrift/thrift/lib/csharp
make[1]: Entering directory `/home/eevans/git/thrift/thrift/lib/csharp'
gmcs src/Collections/THashSet.cs src/Protocol/TBase.cs src/Protocol/TProtocolException.cs src/Protocol/TProtocolFactory.cs src/Protocol/TList.cs src/Protocol/TSet.cs src/Protocol/TMap.cs src/Protocol/TProtocolUtil.cs src/Protocol/TMessageType.cs src/Protocol/TProtocol.cs src/Protocol/TType.cs src/Protocol/TField.cs src/Protocol/TMessage.cs src/Protocol/TStruct.cs src/Protocol/TBinaryProtocol.cs src/Server/TThreadedServer.cs src/Server/TThreadPoolServer.cs src/Server/TSimpleServer.cs src/Server/TServer.cs src/Transport/TBufferedTransport.cs src/Transport/TTransport.cs src/Transport/TSocket.cs src/Transport/TTransportException.cs src/Transport/TStreamTransport.cs src/Transport/TServerTransport.cs src/Transport/TServerSocket.cs src/Transport/TTransportFactory.cs src/TProcessor.cs src/TApplicationException.cs /out:Thrift.dll /target:library 
src/Collections/THashSet.cs(40,42): error CS1061: Type `System.Collections.Generic.HashSet<T>' does not contain a definition for `IsReadOnly' and no extension method `IsReadOnly' of type `System.Collections.Generic.HashSet<T>' could be found (are you missing a using directive or an assembly reference?)
Compilation failed: 1 error(s), 0 warnings
make[1]: *** [Thrift.dll] Error 1
make[1]: Leaving directory `/home/eevans/git/thrift/thrift/lib/csharp'
{quote}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-467) C# libraries fail to build

Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Greene updated THRIFT-467:
----------------------------------

    Attachment: thrift-467-001.diff

The way this is implemented, we could either cast the set to an ICollection<T> and return its value, or we could just return false, as HashSets are not read-only.

The attached patch fixes the problem on Jaunty for me. (I don't have a Sid install handy, but it should work everywhere).

> C# libraries fail to build
> --------------------------
>
>                 Key: THRIFT-467
>                 URL: https://issues.apache.org/jira/browse/THRIFT-467
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (C#)
>         Environment: Debian unstable/testing, mono 2.0.1
>            Reporter: Eric Evans
>         Attachments: thrift-467-001.diff
>
>
> {quote}
> /usr/bin/make -C /home/eevans/git/thrift/thrift/lib/csharp
> make[1]: Entering directory `/home/eevans/git/thrift/thrift/lib/csharp'
> gmcs src/Collections/THashSet.cs src/Protocol/TBase.cs src/Protocol/TProtocolException.cs src/Protocol/TProtocolFactory.cs src/Protocol/TList.cs src/Protocol/TSet.cs src/Protocol/TMap.cs src/Protocol/TProtocolUtil.cs src/Protocol/TMessageType.cs src/Protocol/TProtocol.cs src/Protocol/TType.cs src/Protocol/TField.cs src/Protocol/TMessage.cs src/Protocol/TStruct.cs src/Protocol/TBinaryProtocol.cs src/Server/TThreadedServer.cs src/Server/TThreadPoolServer.cs src/Server/TSimpleServer.cs src/Server/TServer.cs src/Transport/TBufferedTransport.cs src/Transport/TTransport.cs src/Transport/TSocket.cs src/Transport/TTransportException.cs src/Transport/TStreamTransport.cs src/Transport/TServerTransport.cs src/Transport/TServerSocket.cs src/Transport/TTransportFactory.cs src/TProcessor.cs src/TApplicationException.cs /out:Thrift.dll /target:library 
> src/Collections/THashSet.cs(40,42): error CS1061: Type `System.Collections.Generic.HashSet<T>' does not contain a definition for `IsReadOnly' and no extension method `IsReadOnly' of type `System.Collections.Generic.HashSet<T>' could be found (are you missing a using directive or an assembly reference?)
> Compilation failed: 1 error(s), 0 warnings
> make[1]: *** [Thrift.dll] Error 1
> make[1]: Leaving directory `/home/eevans/git/thrift/thrift/lib/csharp'
> {quote}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-467) C# libraries fail to build

Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12703148#action_12703148 ] 

Eric Evans commented on THRIFT-467:
-----------------------------------

Yes, it does build successfully on Sid with this patch applied.

> C# libraries fail to build
> --------------------------
>
>                 Key: THRIFT-467
>                 URL: https://issues.apache.org/jira/browse/THRIFT-467
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (C#)
>         Environment: Debian unstable/testing, mono 2.0.1
>            Reporter: Eric Evans
>         Attachments: thrift-467-001.diff
>
>
> {quote}
> /usr/bin/make -C /home/eevans/git/thrift/thrift/lib/csharp
> make[1]: Entering directory `/home/eevans/git/thrift/thrift/lib/csharp'
> gmcs src/Collections/THashSet.cs src/Protocol/TBase.cs src/Protocol/TProtocolException.cs src/Protocol/TProtocolFactory.cs src/Protocol/TList.cs src/Protocol/TSet.cs src/Protocol/TMap.cs src/Protocol/TProtocolUtil.cs src/Protocol/TMessageType.cs src/Protocol/TProtocol.cs src/Protocol/TType.cs src/Protocol/TField.cs src/Protocol/TMessage.cs src/Protocol/TStruct.cs src/Protocol/TBinaryProtocol.cs src/Server/TThreadedServer.cs src/Server/TThreadPoolServer.cs src/Server/TSimpleServer.cs src/Server/TServer.cs src/Transport/TBufferedTransport.cs src/Transport/TTransport.cs src/Transport/TSocket.cs src/Transport/TTransportException.cs src/Transport/TStreamTransport.cs src/Transport/TServerTransport.cs src/Transport/TServerSocket.cs src/Transport/TTransportFactory.cs src/TProcessor.cs src/TApplicationException.cs /out:Thrift.dll /target:library 
> src/Collections/THashSet.cs(40,42): error CS1061: Type `System.Collections.Generic.HashSet<T>' does not contain a definition for `IsReadOnly' and no extension method `IsReadOnly' of type `System.Collections.Generic.HashSet<T>' could be found (are you missing a using directive or an assembly reference?)
> Compilation failed: 1 error(s), 0 warnings
> make[1]: *** [Thrift.dll] Error 1
> make[1]: Leaving directory `/home/eevans/git/thrift/thrift/lib/csharp'
> {quote}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-467) C# libraries fail to build

Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Greene updated THRIFT-467:
----------------------------------

           Patch Info: [Patch Available]
    Affects Version/s: 0.1
        Fix Version/s: 0.1

This is a compatibility issue and all existing code is compatible.  I think it should be included in 0.1

> C# libraries fail to build
> --------------------------
>
>                 Key: THRIFT-467
>                 URL: https://issues.apache.org/jira/browse/THRIFT-467
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (C#)
>    Affects Versions: 0.1
>         Environment: Debian unstable/testing, mono 2.0.1
>            Reporter: Eric Evans
>             Fix For: 0.1
>
>         Attachments: thrift-467-001.diff
>
>
> {quote}
> /usr/bin/make -C /home/eevans/git/thrift/thrift/lib/csharp
> make[1]: Entering directory `/home/eevans/git/thrift/thrift/lib/csharp'
> gmcs src/Collections/THashSet.cs src/Protocol/TBase.cs src/Protocol/TProtocolException.cs src/Protocol/TProtocolFactory.cs src/Protocol/TList.cs src/Protocol/TSet.cs src/Protocol/TMap.cs src/Protocol/TProtocolUtil.cs src/Protocol/TMessageType.cs src/Protocol/TProtocol.cs src/Protocol/TType.cs src/Protocol/TField.cs src/Protocol/TMessage.cs src/Protocol/TStruct.cs src/Protocol/TBinaryProtocol.cs src/Server/TThreadedServer.cs src/Server/TThreadPoolServer.cs src/Server/TSimpleServer.cs src/Server/TServer.cs src/Transport/TBufferedTransport.cs src/Transport/TTransport.cs src/Transport/TSocket.cs src/Transport/TTransportException.cs src/Transport/TStreamTransport.cs src/Transport/TServerTransport.cs src/Transport/TServerSocket.cs src/Transport/TTransportFactory.cs src/TProcessor.cs src/TApplicationException.cs /out:Thrift.dll /target:library 
> src/Collections/THashSet.cs(40,42): error CS1061: Type `System.Collections.Generic.HashSet<T>' does not contain a definition for `IsReadOnly' and no extension method `IsReadOnly' of type `System.Collections.Generic.HashSet<T>' could be found (are you missing a using directive or an assembly reference?)
> Compilation failed: 1 error(s), 0 warnings
> make[1]: *** [Thrift.dll] Error 1
> make[1]: Leaving directory `/home/eevans/git/thrift/thrift/lib/csharp'
> {quote}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (THRIFT-467) C# libraries fail to build

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Reiss resolved THRIFT-467.
--------------------------------

    Resolution: Fixed
      Assignee: Eric Evans

> C# libraries fail to build
> --------------------------
>
>                 Key: THRIFT-467
>                 URL: https://issues.apache.org/jira/browse/THRIFT-467
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (C#)
>    Affects Versions: 0.1
>         Environment: Debian unstable/testing, mono 2.0.1
>            Reporter: Eric Evans
>            Assignee: Eric Evans
>             Fix For: 0.1
>
>         Attachments: thrift-467-001.diff
>
>
> {quote}
> /usr/bin/make -C /home/eevans/git/thrift/thrift/lib/csharp
> make[1]: Entering directory `/home/eevans/git/thrift/thrift/lib/csharp'
> gmcs src/Collections/THashSet.cs src/Protocol/TBase.cs src/Protocol/TProtocolException.cs src/Protocol/TProtocolFactory.cs src/Protocol/TList.cs src/Protocol/TSet.cs src/Protocol/TMap.cs src/Protocol/TProtocolUtil.cs src/Protocol/TMessageType.cs src/Protocol/TProtocol.cs src/Protocol/TType.cs src/Protocol/TField.cs src/Protocol/TMessage.cs src/Protocol/TStruct.cs src/Protocol/TBinaryProtocol.cs src/Server/TThreadedServer.cs src/Server/TThreadPoolServer.cs src/Server/TSimpleServer.cs src/Server/TServer.cs src/Transport/TBufferedTransport.cs src/Transport/TTransport.cs src/Transport/TSocket.cs src/Transport/TTransportException.cs src/Transport/TStreamTransport.cs src/Transport/TServerTransport.cs src/Transport/TServerSocket.cs src/Transport/TTransportFactory.cs src/TProcessor.cs src/TApplicationException.cs /out:Thrift.dll /target:library 
> src/Collections/THashSet.cs(40,42): error CS1061: Type `System.Collections.Generic.HashSet<T>' does not contain a definition for `IsReadOnly' and no extension method `IsReadOnly' of type `System.Collections.Generic.HashSet<T>' could be found (are you missing a using directive or an assembly reference?)
> Compilation failed: 1 error(s), 0 warnings
> make[1]: *** [Thrift.dll] Error 1
> make[1]: Leaving directory `/home/eevans/git/thrift/thrift/lib/csharp'
> {quote}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.