You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openwebbeans.apache.org by Mark Struberg <st...@yahoo.de> on 2009/01/08 16:14:29 UTC
tabs in sources
Hi!
I know this is a highly 'unproductive' and unwelcome task from a developers perspective, so don't slap me - a simple yes or no is enough ;)
What do you think about removing all tabs from the sources and only use spaces?
I know this would mean to do a complete code reformatting but tabs are a big mess and are going to get screwed up often. And now may be the last possible moment for such things.
Don't be rude to me, it was only a question ;)
LieGrue,
strub
----------------------------------------------------------------
“Multiple exclamation marks are a sure sign of a diseased mind!”
(Sir Terry Pratchett)
Re: tabs in sources
Posted by Kevan Miller <ke...@gmail.com>.
On Jan 8, 2009, at 2:25 PM, Mark Struberg wrote:
> Thanks for seconding this, Kevan ;)
>
> I personally would prefer using an already established coding/
> checkstyle ruleset like maven or myfaces instead of having our own
> one. I think myfaces_checks comes very close if we drop the tabs in
> favour to spaces.
Right. I'm not advocating that we *create* one. Just saying that would
be good if we had one that we'd agreed to...
--kevan
Re: tabs in sources
Posted by Gurkan Erdogdu <gu...@yahoo.com>.
Hi;
Tabs spaces is changed to space and eclipse formatter is updated on OpenWebBeans web page. I reformatted all the source codes and commits;
/Gurkan
________________________________
From: Mark Struberg <st...@yahoo.de>
To: openwebbeans-dev@incubator.apache.org
Sent: Thursday, January 8, 2009 9:25:57 PM
Subject: Re: tabs in sources
Thanks for seconding this, Kevan ;)
I personally would prefer using an already established coding/checkstyle ruleset like maven or myfaces instead of having our own one. I think myfaces_checks comes very close if we drop the tabs in favour to spaces.
Btw, I looked at the test coverage yesterday, and the result wasn't that bad. It's actually really good compared to a lot of commercial projects I've seen the last 2 decades ;)
LieGrue,
strub
----------------------------------------------------------------
“Multiple exclamation marks are a sure sign of a diseased mind!”
(Sir Terry Pratchett)
--- Kevan Miller <ke...@gmail.com> schrieb am Do, 8.1.2009:
> Von: Kevan Miller <ke...@gmail.com>
> Betreff: Re: tabs in sources
> An: openwebbeans-dev@incubator.apache.org
> Datum: Donnerstag, 8. Januar 2009, 18:31
> On Jan 8, 2009, at 10:14 AM, Mark Struberg wrote:
>
> > Hi!
> >
> > I know this is a highly 'unproductive' and
> unwelcome task from a developers perspective, so don't
> slap me - a simple yes or no is enough ;)
> >
> > What do you think about removing all tabs from the
> sources and only use spaces?
> >
> > I know this would mean to do a complete code
> reformatting but tabs are a big mess and are going to get
> screwed up often. And now may be the last possible moment
> for such things.
> >
> > Don't be rude to me, it was only a question ;)
>
> :) Can't see anybody being too upset... I agree... I
> hate tab characters in source code. All IDE's and
> editors that I know of can be easily configured to replace
> tabs with spaces.
>
> This should probably be part of a OpenWebBeans coding
> conventions/guidelines.
>
> --kevan
Re: tabs in sources
Posted by Mark Struberg <st...@yahoo.de>.
please use the
maven-javadoc-plugin-2.4
This version has
<prerequisites>
<maven>2.0.8</maven>
</prerequisites>
instead.
LieGrue,
strub
----------------------------------------------------------------
“Multiple exclamation marks are a sure sign of a diseased mind!”
(Sir Terry Pratchett)
--- Gurkan Erdogdu <gu...@yahoo.com> schrieb am Do, 8.1.2009:
> Von: Gurkan Erdogdu <gu...@yahoo.com>
> Betreff: Re: tabs in sources
> An: openwebbeans-dev@incubator.apache.org
> Datum: Donnerstag, 8. Januar 2009, 22:00
> It results in error saying that
>
> Error resolving version for
> 'org.apache.maven.plugins:maven-javadoc-plugin':
> Plugin requires Maven version 2.0.9
>
> But in local our maven version is 2.0.8
>
>
>
>
> ________________________________
> From: Mark Struberg <st...@yahoo.de>
> To: openwebbeans-dev@incubator.apache.org
> Sent: Thursday, January 8, 2009 10:55:44 PM
> Subject: Re: tabs in sources
>
> simply do a
>
> mvn clean site
>
> in the webbeans-impl after you applied the patch with the
> reporting sectionn.
>
> lg,
> strub
>
> --- Gurkan Erdogdu <gu...@yahoo.com> schrieb
> am Do, 8.1.2009:
> > Von: Gurkan Erdogdu <gu...@yahoo.com>
> > Betreff: Re: tabs in sources
> > An: openwebbeans-dev@incubator.apache.org
> > Datum: Donnerstag, 8. Januar 2009, 21:51
> > Mark how to create reports? which mvn command that
> pushes
> > the reports?
> >
> > Thanks;
> >
> > /Gurkan
> >
> >
> >
> >
> > ________________________________
> > From: Mark Struberg <st...@yahoo.de>
> > To: openwebbeans-dev@incubator.apache.org
> > Sent: Thursday, January 8, 2009 9:25:57 PM
> > Subject: Re: tabs in sources
> >
> > Thanks for seconding this, Kevan ;)
> >
> > I personally would prefer using an already established
> > coding/checkstyle ruleset like maven or myfaces
> instead of
> > having our own one. I think myfaces_checks comes very
> close
> > if we drop the tabs in favour to spaces.
> >
> > Btw, I looked at the test coverage yesterday, and the
> > result wasn't that bad. It's actually really
> good
> > compared to a lot of commercial projects I've seen
> the
> > last 2 decades ;)
> >
> >
> > LieGrue,
> > strub
> >
> ----------------------------------------------------------------
> > “Multiple exclamation marks are a sure sign of a
> diseased
> > mind!”
> > (Sir Terry Pratchett)
> >
> >
> > --- Kevan Miller <ke...@gmail.com>
> schrieb am
> > Do, 8.1.2009:
> >
> > > Von: Kevan Miller <ke...@gmail.com>
> > > Betreff: Re: tabs in sources
> > > An: openwebbeans-dev@incubator.apache.org
> > > Datum: Donnerstag, 8. Januar 2009, 18:31
> > > On Jan 8, 2009, at 10:14 AM, Mark Struberg wrote:
> > >
> > > > Hi!
> > > >
> > > > I know this is a highly
> 'unproductive'
> > and
> > > unwelcome task from a developers perspective, so
> > don't
> > > slap me - a simple yes or no is enough ;)
> > > >
> > > > What do you think about removing all tabs
> from
> > the
> > > sources and only use spaces?
> > > >
> > > > I know this would mean to do a complete code
> > > reformatting but tabs are a big mess and are
> going to
> > get
> > > screwed up often. And now may be the last
> possible
> > moment
> > > for such things.
> > > >
> > > > Don't be rude to me, it was only a
> question
> > ;)
> > >
> > > :) Can't see anybody being too upset... I
> agree...
> > I
> > > hate tab characters in source code. All IDE's
> and
> > > editors that I know of can be easily configured
> to
> > replace
> > > tabs with spaces.
> > >
> > > This should probably be part of a OpenWebBeans
> coding
> > > conventions/guidelines.
> > >
> > > --kevan
Re: tabs in sources
Posted by Gurkan Erdogdu <gu...@yahoo.com>.
It results in error saying that
Error resolving version for 'org.apache.maven.plugins:maven-javadoc-plugin': Plugin requires Maven version 2.0.9
But in local our maven version is 2.0.8
________________________________
From: Mark Struberg <st...@yahoo.de>
To: openwebbeans-dev@incubator.apache.org
Sent: Thursday, January 8, 2009 10:55:44 PM
Subject: Re: tabs in sources
simply do a
mvn clean site
in the webbeans-impl after you applied the patch with the reporting sectionn.
lg,
strub
--- Gurkan Erdogdu <gu...@yahoo.com> schrieb am Do, 8.1.2009:
> Von: Gurkan Erdogdu <gu...@yahoo.com>
> Betreff: Re: tabs in sources
> An: openwebbeans-dev@incubator.apache.org
> Datum: Donnerstag, 8. Januar 2009, 21:51
> Mark how to create reports? which mvn command that pushes
> the reports?
>
> Thanks;
>
> /Gurkan
>
>
>
>
> ________________________________
> From: Mark Struberg <st...@yahoo.de>
> To: openwebbeans-dev@incubator.apache.org
> Sent: Thursday, January 8, 2009 9:25:57 PM
> Subject: Re: tabs in sources
>
> Thanks for seconding this, Kevan ;)
>
> I personally would prefer using an already established
> coding/checkstyle ruleset like maven or myfaces instead of
> having our own one. I think myfaces_checks comes very close
> if we drop the tabs in favour to spaces.
>
> Btw, I looked at the test coverage yesterday, and the
> result wasn't that bad. It's actually really good
> compared to a lot of commercial projects I've seen the
> last 2 decades ;)
>
>
> LieGrue,
> strub
> ----------------------------------------------------------------
> “Multiple exclamation marks are a sure sign of a diseased
> mind!”
> (Sir Terry Pratchett)
>
>
> --- Kevan Miller <ke...@gmail.com> schrieb am
> Do, 8.1.2009:
>
> > Von: Kevan Miller <ke...@gmail.com>
> > Betreff: Re: tabs in sources
> > An: openwebbeans-dev@incubator.apache.org
> > Datum: Donnerstag, 8. Januar 2009, 18:31
> > On Jan 8, 2009, at 10:14 AM, Mark Struberg wrote:
> >
> > > Hi!
> > >
> > > I know this is a highly 'unproductive'
> and
> > unwelcome task from a developers perspective, so
> don't
> > slap me - a simple yes or no is enough ;)
> > >
> > > What do you think about removing all tabs from
> the
> > sources and only use spaces?
> > >
> > > I know this would mean to do a complete code
> > reformatting but tabs are a big mess and are going to
> get
> > screwed up often. And now may be the last possible
> moment
> > for such things.
> > >
> > > Don't be rude to me, it was only a question
> ;)
> >
> > :) Can't see anybody being too upset... I agree...
> I
> > hate tab characters in source code. All IDE's and
> > editors that I know of can be easily configured to
> replace
> > tabs with spaces.
> >
> > This should probably be part of a OpenWebBeans coding
> > conventions/guidelines.
> >
> > --kevan
Re: tabs in sources
Posted by Matthias Wessendorf <ma...@apache.org>.
On Thu, Jan 8, 2009 at 2:14 PM, Mark Struberg <st...@yahoo.de> wrote:
> you may also try the myfaces coding style.
there is one ? ;-)
>
> please see the patch.
>
> LieGrue,
> strub
> ----------------------------------------------------------------
> "Multiple exclamation marks are a sure sign of a diseased mind!"
> (Sir Terry Pratchett)
>
>
> --- Gurkan Erdogdu <gu...@yahoo.com> schrieb am Do, 8.1.2009:
>
>> Von: Gurkan Erdogdu <gu...@yahoo.com>
>> Betreff: Re: tabs in sources
>> An: openwebbeans-dev@incubator.apache.org
>> Datum: Donnerstag, 8. Januar 2009, 22:04
>> :) I looked at the MVN book assembly chapter from the
>> internet
>>
>> :/Gurkan
>>
>>
>>
>>
>> ________________________________
>> From: Mark Struberg <st...@yahoo.de>
>> To: openwebbeans-dev@incubator.apache.org
>> Sent: Thursday, January 8, 2009 11:00:49 PM
>> Subject: Re: tabs in sources
>>
>> btw, I looked at the distribution module now
>>
>> mvn package -Ddistribute=true
>>
>> behaves a bit weird.
>>
>> It tries to download the artifacts we do like to build from
>> the public maven repo first and therefore fails.
>> Did you copy this from somewhere?
>>
>> Maybe I didn't get the point...
>>
>> LieGrue,
>> strub
>> ----------------------------------------------------------------
>> "Multiple exclamation marks are a sure sign of a diseased
>> mind!"
>> (Sir Terry Pratchett)
>>
>>
>> --- Mark Struberg <st...@yahoo.de> schrieb am Do,
>> 8.1.2009:
>>
>> > Von: Mark Struberg <st...@yahoo.de>
>> > Betreff: Re: tabs in sources
>> > An: openwebbeans-dev@incubator.apache.org
>> > Datum: Donnerstag, 8. Januar 2009, 21:55
>> > simply do a
>> >
>> > mvn clean site
>> >
>> > in the webbeans-impl after you applied the patch with
>> the
>> > reporting sectionn.
>> >
>> > lg,
>> > strub
>> >
>> > --- Gurkan Erdogdu <gu...@yahoo.com>
>> schrieb
>> > am Do, 8.1.2009:
>> > > Von: Gurkan Erdogdu
>> <gu...@yahoo.com>
>> > > Betreff: Re: tabs in sources
>> > > An: openwebbeans-dev@incubator.apache.org
>> > > Datum: Donnerstag, 8. Januar 2009, 21:51
>> > > Mark how to create reports? which mvn command
>> that
>> > pushes
>> > > the reports?
>> > >
>> > > Thanks;
>> > >
>> > > /Gurkan
>> > >
>> > >
>> > >
>> > >
>> > > ________________________________
>> > > From: Mark Struberg <st...@yahoo.de>
>> > > To: openwebbeans-dev@incubator.apache.org
>> > > Sent: Thursday, January 8, 2009 9:25:57 PM
>> > > Subject: Re: tabs in sources
>> > >
>> > > Thanks for seconding this, Kevan ;)
>> > >
>> > > I personally would prefer using an already
>> established
>> > > coding/checkstyle ruleset like maven or myfaces
>> > instead of
>> > > having our own one. I think myfaces_checks comes
>> very
>> > close
>> > > if we drop the tabs in favour to spaces.
>> > >
>> > > Btw, I looked at the test coverage yesterday, and
>> the
>> > > result wasn't that bad. It's actually
>> really
>> > good
>> > > compared to a lot of commercial projects I've
>> seen
>> > the
>> > > last 2 decades ;)
>> > >
>> > >
>> > > LieGrue,
>> > > strub
>> > >
>> >
>> ----------------------------------------------------------------
>> > > "Multiple exclamation marks are a sure sign of
>> a
>> > diseased
>> > > mind!"
>> > > (Sir Terry Pratchett)
>> > >
>> > >
>> > > --- Kevan Miller <ke...@gmail.com>
>> > schrieb am
>> > > Do, 8.1.2009:
>> > >
>> > > > Von: Kevan Miller
>> <ke...@gmail.com>
>> > > > Betreff: Re: tabs in sources
>> > > > An: openwebbeans-dev@incubator.apache.org
>> > > > Datum: Donnerstag, 8. Januar 2009, 18:31
>> > > > On Jan 8, 2009, at 10:14 AM, Mark Struberg
>> wrote:
>> > > >
>> > > > > Hi!
>> > > > >
>> > > > > I know this is a highly
>> > 'unproductive'
>> > > and
>> > > > unwelcome task from a developers
>> perspective, so
>> > > don't
>> > > > slap me - a simple yes or no is enough ;)
>> > > > >
>> > > > > What do you think about removing all
>> tabs
>> > from
>> > > the
>> > > > sources and only use spaces?
>> > > > >
>> > > > > I know this would mean to do a complete
>> code
>> > > > reformatting but tabs are a big mess and are
>> > going to
>> > > get
>> > > > screwed up often. And now may be the last
>> > possible
>> > > moment
>> > > > for such things.
>> > > > >
>> > > > > Don't be rude to me, it was only a
>> > question
>> > > ;)
>> > > >
>> > > > :) Can't see anybody being too upset...
>> I
>> > agree...
>> > > I
>> > > > hate tab characters in source code. All
>> IDE's
>> > and
>> > > > editors that I know of can be easily
>> configured
>> > to
>> > > replace
>> > > > tabs with spaces.
>> > > >
>> > > > This should probably be part of a
>> OpenWebBeans
>> > coding
>> > > > conventions/guidelines.
>> > > >
>> > > > --kevan
>
>
>
--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
Re: tabs in sources
Posted by Mark Struberg <st...@yahoo.de>.
you may also try the myfaces coding style.
please see the patch.
LieGrue,
strub
----------------------------------------------------------------
“Multiple exclamation marks are a sure sign of a diseased mind!”
(Sir Terry Pratchett)
--- Gurkan Erdogdu <gu...@yahoo.com> schrieb am Do, 8.1.2009:
> Von: Gurkan Erdogdu <gu...@yahoo.com>
> Betreff: Re: tabs in sources
> An: openwebbeans-dev@incubator.apache.org
> Datum: Donnerstag, 8. Januar 2009, 22:04
> :) I looked at the MVN book assembly chapter from the
> internet
>
> :/Gurkan
>
>
>
>
> ________________________________
> From: Mark Struberg <st...@yahoo.de>
> To: openwebbeans-dev@incubator.apache.org
> Sent: Thursday, January 8, 2009 11:00:49 PM
> Subject: Re: tabs in sources
>
> btw, I looked at the distribution module now
>
> mvn package -Ddistribute=true
>
> behaves a bit weird.
>
> It tries to download the artifacts we do like to build from
> the public maven repo first and therefore fails.
> Did you copy this from somewhere?
>
> Maybe I didn't get the point...
>
> LieGrue,
> strub
> ----------------------------------------------------------------
> “Multiple exclamation marks are a sure sign of a diseased
> mind!”
> (Sir Terry Pratchett)
>
>
> --- Mark Struberg <st...@yahoo.de> schrieb am Do,
> 8.1.2009:
>
> > Von: Mark Struberg <st...@yahoo.de>
> > Betreff: Re: tabs in sources
> > An: openwebbeans-dev@incubator.apache.org
> > Datum: Donnerstag, 8. Januar 2009, 21:55
> > simply do a
> >
> > mvn clean site
> >
> > in the webbeans-impl after you applied the patch with
> the
> > reporting sectionn.
> >
> > lg,
> > strub
> >
> > --- Gurkan Erdogdu <gu...@yahoo.com>
> schrieb
> > am Do, 8.1.2009:
> > > Von: Gurkan Erdogdu
> <gu...@yahoo.com>
> > > Betreff: Re: tabs in sources
> > > An: openwebbeans-dev@incubator.apache.org
> > > Datum: Donnerstag, 8. Januar 2009, 21:51
> > > Mark how to create reports? which mvn command
> that
> > pushes
> > > the reports?
> > >
> > > Thanks;
> > >
> > > /Gurkan
> > >
> > >
> > >
> > >
> > > ________________________________
> > > From: Mark Struberg <st...@yahoo.de>
> > > To: openwebbeans-dev@incubator.apache.org
> > > Sent: Thursday, January 8, 2009 9:25:57 PM
> > > Subject: Re: tabs in sources
> > >
> > > Thanks for seconding this, Kevan ;)
> > >
> > > I personally would prefer using an already
> established
> > > coding/checkstyle ruleset like maven or myfaces
> > instead of
> > > having our own one. I think myfaces_checks comes
> very
> > close
> > > if we drop the tabs in favour to spaces.
> > >
> > > Btw, I looked at the test coverage yesterday, and
> the
> > > result wasn't that bad. It's actually
> really
> > good
> > > compared to a lot of commercial projects I've
> seen
> > the
> > > last 2 decades ;)
> > >
> > >
> > > LieGrue,
> > > strub
> > >
> >
> ----------------------------------------------------------------
> > > “Multiple exclamation marks are a sure sign of
> a
> > diseased
> > > mind!”
> > > (Sir Terry Pratchett)
> > >
> > >
> > > --- Kevan Miller <ke...@gmail.com>
> > schrieb am
> > > Do, 8.1.2009:
> > >
> > > > Von: Kevan Miller
> <ke...@gmail.com>
> > > > Betreff: Re: tabs in sources
> > > > An: openwebbeans-dev@incubator.apache.org
> > > > Datum: Donnerstag, 8. Januar 2009, 18:31
> > > > On Jan 8, 2009, at 10:14 AM, Mark Struberg
> wrote:
> > > >
> > > > > Hi!
> > > > >
> > > > > I know this is a highly
> > 'unproductive'
> > > and
> > > > unwelcome task from a developers
> perspective, so
> > > don't
> > > > slap me - a simple yes or no is enough ;)
> > > > >
> > > > > What do you think about removing all
> tabs
> > from
> > > the
> > > > sources and only use spaces?
> > > > >
> > > > > I know this would mean to do a complete
> code
> > > > reformatting but tabs are a big mess and are
> > going to
> > > get
> > > > screwed up often. And now may be the last
> > possible
> > > moment
> > > > for such things.
> > > > >
> > > > > Don't be rude to me, it was only a
> > question
> > > ;)
> > > >
> > > > :) Can't see anybody being too upset...
> I
> > agree...
> > > I
> > > > hate tab characters in source code. All
> IDE's
> > and
> > > > editors that I know of can be easily
> configured
> > to
> > > replace
> > > > tabs with spaces.
> > > >
> > > > This should probably be part of a
> OpenWebBeans
> > coding
> > > > conventions/guidelines.
> > > >
> > > > --kevan
Re: tabs in sources
Posted by Gurkan Erdogdu <gu...@yahoo.com>.
:) I looked at the MVN book assembly chapter from the internet
:/Gurkan
________________________________
From: Mark Struberg <st...@yahoo.de>
To: openwebbeans-dev@incubator.apache.org
Sent: Thursday, January 8, 2009 11:00:49 PM
Subject: Re: tabs in sources
btw, I looked at the distribution module now
mvn package -Ddistribute=true
behaves a bit weird.
It tries to download the artifacts we do like to build from the public maven repo first and therefore fails.
Did you copy this from somewhere?
Maybe I didn't get the point...
LieGrue,
strub
----------------------------------------------------------------
“Multiple exclamation marks are a sure sign of a diseased mind!”
(Sir Terry Pratchett)
--- Mark Struberg <st...@yahoo.de> schrieb am Do, 8.1.2009:
> Von: Mark Struberg <st...@yahoo.de>
> Betreff: Re: tabs in sources
> An: openwebbeans-dev@incubator.apache.org
> Datum: Donnerstag, 8. Januar 2009, 21:55
> simply do a
>
> mvn clean site
>
> in the webbeans-impl after you applied the patch with the
> reporting sectionn.
>
> lg,
> strub
>
> --- Gurkan Erdogdu <gu...@yahoo.com> schrieb
> am Do, 8.1.2009:
> > Von: Gurkan Erdogdu <gu...@yahoo.com>
> > Betreff: Re: tabs in sources
> > An: openwebbeans-dev@incubator.apache.org
> > Datum: Donnerstag, 8. Januar 2009, 21:51
> > Mark how to create reports? which mvn command that
> pushes
> > the reports?
> >
> > Thanks;
> >
> > /Gurkan
> >
> >
> >
> >
> > ________________________________
> > From: Mark Struberg <st...@yahoo.de>
> > To: openwebbeans-dev@incubator.apache.org
> > Sent: Thursday, January 8, 2009 9:25:57 PM
> > Subject: Re: tabs in sources
> >
> > Thanks for seconding this, Kevan ;)
> >
> > I personally would prefer using an already established
> > coding/checkstyle ruleset like maven or myfaces
> instead of
> > having our own one. I think myfaces_checks comes very
> close
> > if we drop the tabs in favour to spaces.
> >
> > Btw, I looked at the test coverage yesterday, and the
> > result wasn't that bad. It's actually really
> good
> > compared to a lot of commercial projects I've seen
> the
> > last 2 decades ;)
> >
> >
> > LieGrue,
> > strub
> >
> ----------------------------------------------------------------
> > “Multiple exclamation marks are a sure sign of a
> diseased
> > mind!”
> > (Sir Terry Pratchett)
> >
> >
> > --- Kevan Miller <ke...@gmail.com>
> schrieb am
> > Do, 8.1.2009:
> >
> > > Von: Kevan Miller <ke...@gmail.com>
> > > Betreff: Re: tabs in sources
> > > An: openwebbeans-dev@incubator.apache.org
> > > Datum: Donnerstag, 8. Januar 2009, 18:31
> > > On Jan 8, 2009, at 10:14 AM, Mark Struberg wrote:
> > >
> > > > Hi!
> > > >
> > > > I know this is a highly
> 'unproductive'
> > and
> > > unwelcome task from a developers perspective, so
> > don't
> > > slap me - a simple yes or no is enough ;)
> > > >
> > > > What do you think about removing all tabs
> from
> > the
> > > sources and only use spaces?
> > > >
> > > > I know this would mean to do a complete code
> > > reformatting but tabs are a big mess and are
> going to
> > get
> > > screwed up often. And now may be the last
> possible
> > moment
> > > for such things.
> > > >
> > > > Don't be rude to me, it was only a
> question
> > ;)
> > >
> > > :) Can't see anybody being too upset... I
> agree...
> > I
> > > hate tab characters in source code. All IDE's
> and
> > > editors that I know of can be easily configured
> to
> > replace
> > > tabs with spaces.
> > >
> > > This should probably be part of a OpenWebBeans
> coding
> > > conventions/guidelines.
> > >
> > > --kevan
Re: tabs in sources
Posted by Mark Struberg <st...@yahoo.de>.
btw, I looked at the distribution module now
mvn package -Ddistribute=true
behaves a bit weird.
It tries to download the artifacts we do like to build from the public maven repo first and therefore fails.
Did you copy this from somewhere?
Maybe I didn't get the point...
LieGrue,
strub
----------------------------------------------------------------
“Multiple exclamation marks are a sure sign of a diseased mind!”
(Sir Terry Pratchett)
--- Mark Struberg <st...@yahoo.de> schrieb am Do, 8.1.2009:
> Von: Mark Struberg <st...@yahoo.de>
> Betreff: Re: tabs in sources
> An: openwebbeans-dev@incubator.apache.org
> Datum: Donnerstag, 8. Januar 2009, 21:55
> simply do a
>
> mvn clean site
>
> in the webbeans-impl after you applied the patch with the
> reporting sectionn.
>
> lg,
> strub
>
> --- Gurkan Erdogdu <gu...@yahoo.com> schrieb
> am Do, 8.1.2009:
> > Von: Gurkan Erdogdu <gu...@yahoo.com>
> > Betreff: Re: tabs in sources
> > An: openwebbeans-dev@incubator.apache.org
> > Datum: Donnerstag, 8. Januar 2009, 21:51
> > Mark how to create reports? which mvn command that
> pushes
> > the reports?
> >
> > Thanks;
> >
> > /Gurkan
> >
> >
> >
> >
> > ________________________________
> > From: Mark Struberg <st...@yahoo.de>
> > To: openwebbeans-dev@incubator.apache.org
> > Sent: Thursday, January 8, 2009 9:25:57 PM
> > Subject: Re: tabs in sources
> >
> > Thanks for seconding this, Kevan ;)
> >
> > I personally would prefer using an already established
> > coding/checkstyle ruleset like maven or myfaces
> instead of
> > having our own one. I think myfaces_checks comes very
> close
> > if we drop the tabs in favour to spaces.
> >
> > Btw, I looked at the test coverage yesterday, and the
> > result wasn't that bad. It's actually really
> good
> > compared to a lot of commercial projects I've seen
> the
> > last 2 decades ;)
> >
> >
> > LieGrue,
> > strub
> >
> ----------------------------------------------------------------
> > “Multiple exclamation marks are a sure sign of a
> diseased
> > mind!”
> > (Sir Terry Pratchett)
> >
> >
> > --- Kevan Miller <ke...@gmail.com>
> schrieb am
> > Do, 8.1.2009:
> >
> > > Von: Kevan Miller <ke...@gmail.com>
> > > Betreff: Re: tabs in sources
> > > An: openwebbeans-dev@incubator.apache.org
> > > Datum: Donnerstag, 8. Januar 2009, 18:31
> > > On Jan 8, 2009, at 10:14 AM, Mark Struberg wrote:
> > >
> > > > Hi!
> > > >
> > > > I know this is a highly
> 'unproductive'
> > and
> > > unwelcome task from a developers perspective, so
> > don't
> > > slap me - a simple yes or no is enough ;)
> > > >
> > > > What do you think about removing all tabs
> from
> > the
> > > sources and only use spaces?
> > > >
> > > > I know this would mean to do a complete code
> > > reformatting but tabs are a big mess and are
> going to
> > get
> > > screwed up often. And now may be the last
> possible
> > moment
> > > for such things.
> > > >
> > > > Don't be rude to me, it was only a
> question
> > ;)
> > >
> > > :) Can't see anybody being too upset... I
> agree...
> > I
> > > hate tab characters in source code. All IDE's
> and
> > > editors that I know of can be easily configured
> to
> > replace
> > > tabs with spaces.
> > >
> > > This should probably be part of a OpenWebBeans
> coding
> > > conventions/guidelines.
> > >
> > > --kevan
Re: tabs in sources
Posted by Mark Struberg <st...@yahoo.de>.
simply do a
mvn clean site
in the webbeans-impl after you applied the patch with the reporting sectionn.
lg,
strub
--- Gurkan Erdogdu <gu...@yahoo.com> schrieb am Do, 8.1.2009:
> Von: Gurkan Erdogdu <gu...@yahoo.com>
> Betreff: Re: tabs in sources
> An: openwebbeans-dev@incubator.apache.org
> Datum: Donnerstag, 8. Januar 2009, 21:51
> Mark how to create reports? which mvn command that pushes
> the reports?
>
> Thanks;
>
> /Gurkan
>
>
>
>
> ________________________________
> From: Mark Struberg <st...@yahoo.de>
> To: openwebbeans-dev@incubator.apache.org
> Sent: Thursday, January 8, 2009 9:25:57 PM
> Subject: Re: tabs in sources
>
> Thanks for seconding this, Kevan ;)
>
> I personally would prefer using an already established
> coding/checkstyle ruleset like maven or myfaces instead of
> having our own one. I think myfaces_checks comes very close
> if we drop the tabs in favour to spaces.
>
> Btw, I looked at the test coverage yesterday, and the
> result wasn't that bad. It's actually really good
> compared to a lot of commercial projects I've seen the
> last 2 decades ;)
>
>
> LieGrue,
> strub
> ----------------------------------------------------------------
> “Multiple exclamation marks are a sure sign of a diseased
> mind!”
> (Sir Terry Pratchett)
>
>
> --- Kevan Miller <ke...@gmail.com> schrieb am
> Do, 8.1.2009:
>
> > Von: Kevan Miller <ke...@gmail.com>
> > Betreff: Re: tabs in sources
> > An: openwebbeans-dev@incubator.apache.org
> > Datum: Donnerstag, 8. Januar 2009, 18:31
> > On Jan 8, 2009, at 10:14 AM, Mark Struberg wrote:
> >
> > > Hi!
> > >
> > > I know this is a highly 'unproductive'
> and
> > unwelcome task from a developers perspective, so
> don't
> > slap me - a simple yes or no is enough ;)
> > >
> > > What do you think about removing all tabs from
> the
> > sources and only use spaces?
> > >
> > > I know this would mean to do a complete code
> > reformatting but tabs are a big mess and are going to
> get
> > screwed up often. And now may be the last possible
> moment
> > for such things.
> > >
> > > Don't be rude to me, it was only a question
> ;)
> >
> > :) Can't see anybody being too upset... I agree...
> I
> > hate tab characters in source code. All IDE's and
> > editors that I know of can be easily configured to
> replace
> > tabs with spaces.
> >
> > This should probably be part of a OpenWebBeans coding
> > conventions/guidelines.
> >
> > --kevan
Re: tabs in sources
Posted by Gurkan Erdogdu <gu...@yahoo.com>.
Mark how to create reports? which mvn command that pushes the reports?
Thanks;
/Gurkan
________________________________
From: Mark Struberg <st...@yahoo.de>
To: openwebbeans-dev@incubator.apache.org
Sent: Thursday, January 8, 2009 9:25:57 PM
Subject: Re: tabs in sources
Thanks for seconding this, Kevan ;)
I personally would prefer using an already established coding/checkstyle ruleset like maven or myfaces instead of having our own one. I think myfaces_checks comes very close if we drop the tabs in favour to spaces.
Btw, I looked at the test coverage yesterday, and the result wasn't that bad. It's actually really good compared to a lot of commercial projects I've seen the last 2 decades ;)
LieGrue,
strub
----------------------------------------------------------------
“Multiple exclamation marks are a sure sign of a diseased mind!”
(Sir Terry Pratchett)
--- Kevan Miller <ke...@gmail.com> schrieb am Do, 8.1.2009:
> Von: Kevan Miller <ke...@gmail.com>
> Betreff: Re: tabs in sources
> An: openwebbeans-dev@incubator.apache.org
> Datum: Donnerstag, 8. Januar 2009, 18:31
> On Jan 8, 2009, at 10:14 AM, Mark Struberg wrote:
>
> > Hi!
> >
> > I know this is a highly 'unproductive' and
> unwelcome task from a developers perspective, so don't
> slap me - a simple yes or no is enough ;)
> >
> > What do you think about removing all tabs from the
> sources and only use spaces?
> >
> > I know this would mean to do a complete code
> reformatting but tabs are a big mess and are going to get
> screwed up often. And now may be the last possible moment
> for such things.
> >
> > Don't be rude to me, it was only a question ;)
>
> :) Can't see anybody being too upset... I agree... I
> hate tab characters in source code. All IDE's and
> editors that I know of can be easily configured to replace
> tabs with spaces.
>
> This should probably be part of a OpenWebBeans coding
> conventions/guidelines.
>
> --kevan
Re: tabs in sources
Posted by Mark Struberg <st...@yahoo.de>.
Thanks for seconding this, Kevan ;)
I personally would prefer using an already established coding/checkstyle ruleset like maven or myfaces instead of having our own one. I think myfaces_checks comes very close if we drop the tabs in favour to spaces.
Btw, I looked at the test coverage yesterday, and the result wasn't that bad. It's actually really good compared to a lot of commercial projects I've seen the last 2 decades ;)
LieGrue,
strub
----------------------------------------------------------------
“Multiple exclamation marks are a sure sign of a diseased mind!”
(Sir Terry Pratchett)
--- Kevan Miller <ke...@gmail.com> schrieb am Do, 8.1.2009:
> Von: Kevan Miller <ke...@gmail.com>
> Betreff: Re: tabs in sources
> An: openwebbeans-dev@incubator.apache.org
> Datum: Donnerstag, 8. Januar 2009, 18:31
> On Jan 8, 2009, at 10:14 AM, Mark Struberg wrote:
>
> > Hi!
> >
> > I know this is a highly 'unproductive' and
> unwelcome task from a developers perspective, so don't
> slap me - a simple yes or no is enough ;)
> >
> > What do you think about removing all tabs from the
> sources and only use spaces?
> >
> > I know this would mean to do a complete code
> reformatting but tabs are a big mess and are going to get
> screwed up often. And now may be the last possible moment
> for such things.
> >
> > Don't be rude to me, it was only a question ;)
>
> :) Can't see anybody being too upset... I agree... I
> hate tab characters in source code. All IDE's and
> editors that I know of can be easily configured to replace
> tabs with spaces.
>
> This should probably be part of a OpenWebBeans coding
> conventions/guidelines.
>
> --kevan
Re: tabs in sources
Posted by Kevan Miller <ke...@gmail.com>.
On Jan 8, 2009, at 10:14 AM, Mark Struberg wrote:
> Hi!
>
> I know this is a highly 'unproductive' and unwelcome task from a
> developers perspective, so don't slap me - a simple yes or no is
> enough ;)
>
> What do you think about removing all tabs from the sources and only
> use spaces?
>
> I know this would mean to do a complete code reformatting but tabs
> are a big mess and are going to get screwed up often. And now may be
> the last possible moment for such things.
>
> Don't be rude to me, it was only a question ;)
:) Can't see anybody being too upset... I agree... I hate tab
characters in source code. All IDE's and editors that I know of can be
easily configured to replace tabs with spaces.
This should probably be part of a OpenWebBeans coding conventions/
guidelines.
--kevan