You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Phil Steitz (JIRA)" <ji...@apache.org> on 2007/09/23 22:02:50 UTC

[jira] Created: (DBCP-242) DelegatingConnection close does not complete action

DelegatingConnection close does not complete action
---------------------------------------------------

                 Key: DBCP-242
                 URL: https://issues.apache.org/jira/browse/DBCP-242
             Project: Commons Dbcp
          Issue Type: Bug
    Affects Versions: Nightly Builds
            Reporter: Phil Steitz
             Fix For: 1.3


The change introduced in r557176 eliminated the call to passivate() in DelegatingConnection.close()  and sets  _closed to true only if isClosed has returned false.  The passivate() call should be restored (or the contract changed, which may be inconsistent with the spec) and _closed should always be set to false by this method.  This is consistent with <= 1.2.2 behaviour. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (DBCP-242) DelegatingConnection close does not complete action

Posted by "Phil Steitz (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DBCP-242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Phil Steitz resolved DBCP-242.
------------------------------

    Resolution: Fixed

Fixed in r746629 by reverting to 1.2.2 version of the method

> DelegatingConnection close does not complete action
> ---------------------------------------------------
>
>                 Key: DBCP-242
>                 URL: https://issues.apache.org/jira/browse/DBCP-242
>             Project: Commons Dbcp
>          Issue Type: Bug
>    Affects Versions: Nightly Builds
>            Reporter: Phil Steitz
>             Fix For: 1.3
>
>
> The change introduced in r557176 eliminated the call to passivate() in DelegatingConnection.close()  and sets  _closed to true only if isClosed has returned false.  The passivate() call should be restored (or the contract changed, which may be inconsistent with the spec) and _closed should always be set to false by this method.  This is consistent with <= 1.2.2 behaviour. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (DBCP-242) DelegatingConnection close does not complete action

Posted by "Phil Steitz (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DBCP-242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Phil Steitz closed DBCP-242.
----------------------------


> DelegatingConnection close does not complete action
> ---------------------------------------------------
>
>                 Key: DBCP-242
>                 URL: https://issues.apache.org/jira/browse/DBCP-242
>             Project: Commons Dbcp
>          Issue Type: Bug
>    Affects Versions: Nightly Builds
>            Reporter: Phil Steitz
>             Fix For: 1.3
>
>
> The change introduced in r557176 eliminated the call to passivate() in DelegatingConnection.close()  and sets  _closed to true only if isClosed has returned false.  The passivate() call should be restored (or the contract changed, which may be inconsistent with the spec) and _closed should always be set to false by this method.  This is consistent with <= 1.2.2 behaviour. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.