You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by bu...@apache.org on 2008/03/06 21:15:24 UTC

DO NOT REPLY [Bug 44551] New: SocketHubAppender in the 1.2. 16 does not support a scroll back buffer or application property

https://issues.apache.org/bugzilla/show_bug.cgi?id=44551

           Summary: SocketHubAppender in the 1.2.16 does not support a
                    scroll back buffer or application property
           Product: Log4j
           Version: 1.2
          Platform: PC
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: Appender
        AssignedTo: log4j-dev@logging.apache.org
        ReportedBy: jason.tholstrup@gmail.com


Created an attachment (id=21644)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=21644)
Patch to fix the issues listed in the description

Part 1)
The 1.3 version of SocketHubAppender uses a cyclic buffer to store the last X
log messages that are delivered to the client on connection so that they can
have some of the recently logged events. This was never back ported to the
1.2.X branch.

Part 2)
The 1.2.X version of SocketAppender supports an application property which
chainsaw can read to specify which application the log is for. 
SocketHubAppender should also support this functionality.

The attached patch resolves these issues.

Thanks to Scott Deboy for his guidance.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


DO NOT REPLY [Bug 44551] SocketHubAppender in the 1.2. 16 does not support a scroll back buffer or application property

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44551


Jason Tholstrup <ja...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jason.tholstrup@gmail.com




-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


DO NOT REPLY [Bug 44551] SocketHubAppender in the 1.2. 16 does not support a scroll back buffer or application property

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44551





--- Comment #6 from Scott Deboy <sd...@iname.com>  2008-03-06 22:24:17 PST ---
I agree with Paul..I don't think a CLA is required for submitted patches.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


DO NOT REPLY [Bug 44551] SocketHubAppender in the 1.2. 16 does not support a scroll back buffer or application property

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44551





--- Comment #7 from Jacob Kjome <ho...@visi.com>  2008-03-06 22:27:31 PST ---
My misunderstanding.  From http://www.apache.org/licenses/ ...

"The ASF desires that all contributors of ideas, code, or documentation to the
Apache projects complete, sign, and submit (via postal mail, fax or email) an
Individual Contributor License Agreement (CLA) [PDF form]."

Looks like it isn't "required", but "desired" for general contributors. 
However, for committers it is required...

"A signed CLA is required to be on file before an individual is given commit
rights to an ASF project."

Sorry for the noise.

Jake


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


DO NOT REPLY [Bug 44551] SocketHubAppender in the 1.2. 16 does not support a scroll back buffer or application property

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44551





--- Comment #5 from Paul Smith <ps...@apache.org>  2008-03-06 22:08:57 PST ---
I thought that if a person attached their contribution to bugzilla that was
implied donation to Apache?


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


DO NOT REPLY [Bug 44551] SocketHubAppender in the 1.2. 16 does not support a scroll back buffer or application property

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44551





--- Comment #4 from Jacob Kjome <ho...@visi.com>  2008-03-06 21:51:51 PST ---
Can we presume that the Apache Contributor Agreement has been signed and is on
file at the foundation?

Jake


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


DO NOT REPLY [Bug 44551] SocketHubAppender in the 1.2. 16 does not support a scroll back buffer or application property

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44551





--- Comment #1 from Paul Smith <ps...@apache.org>  2008-03-06 18:49:05 PST ---
This patch looks good to me, I can't see any reason not to apply it.

Scott?  any final comments?


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


DO NOT REPLY [Bug 44551] SocketHubAppender in the 1.2. 16 does not support a scroll back buffer or application property

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44551


Paul Smith <ps...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #3 from Paul Smith <ps...@apache.org>  2008-03-06 21:44:00 PST ---
Patch applied as of revision 634545.

Thanks muchly.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


DO NOT REPLY [Bug 44551] SocketHubAppender in the 1.2. 16 does not support a scroll back buffer or application property

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44551





--- Comment #2 from Scott Deboy <sd...@iname.com>  2008-03-06 20:53:21 PST ---
Looks good to me as well.

Thanks for the contribution Jason


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org