You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/07/01 14:43:05 UTC
[jira] [Commented] (THRIFT-3215) TJSONProtocol '(c++) uses "throw
new" to throw exceptions instead of "throw"
[ https://issues.apache.org/jira/browse/THRIFT-3215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14610047#comment-14610047 ]
ASF GitHub Bot commented on THRIFT-3215:
----------------------------------------
GitHub user cmhe opened a pull request:
https://github.com/apache/thrift/pull/536
THRIFT-3215 Replaces "throw new" in TJSONProtocol with a normal "throw"
Sponsored-by: Roger Meier <r....@siemens.com>
Signed-off-by: Claudius Heine <ch...@denx.de>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cmhe/thrift THRIFT-3215
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/536.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #536
----
commit c32e2f874a695e042dafc2bc2c6ef8b5b5e4f911
Author: Claudius Heine <ch...@denx.de>
Date: 2015-07-01T08:35:38Z
THRIFT-3215 Replaces "throw new" in TJSONProtocol with a "throw" (+ testcase)
Sponsored-by: Roger Meier <r....@siemens.com>
Signed-off-by: Claudius Heine <ch...@denx.de>
----
> TJSONProtocol '(c++) uses "throw new" to throw exceptions instead of "throw"
> ----------------------------------------------------------------------------
>
> Key: THRIFT-3215
> URL: https://issues.apache.org/jira/browse/THRIFT-3215
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.9.2
> Reporter: Claudius Heine
>
> The C++ implementation of the TJSONProtocol throws TProtocolExceptions via "throw new TProtocolException".
> To catch those exceptions you need to "catch (TProtocolException* e)" instead of "catch (TProtocolException& e)".
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)