You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2016/08/24 01:04:23 UTC
[kudu-CR] KUDU-1048 master should show versions of tservers, version summary
Will Berkeley has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4104
Change subject: KUDU-1048 master should show versions of tservers, version summary
......................................................................
KUDU-1048 master should show versions of tservers, version summary
This patch adds a version summary table and a total count of
registered tablet servers to /tablet-servers.
It also fixes the display of the registration, which was printing in
red font.
Sample: https://raw.githubusercontent.com/wdberkeley/kudu-cr/master/KUDU-1048-after.png
Change-Id: Idd203209e3d99292018801b94ec2904b6634854f
---
M src/kudu/master/master-path-handlers.cc
1 file changed, 23 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/4104/1
--
To view, visit http://gerrit.cloudera.org:8080/4104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idd203209e3d99292018801b94ec2904b6634854f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
[kudu-CR] KUDU-1048 master should show versions of tservers, version summary
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4104
to look at the new patch set (#2).
Change subject: KUDU-1048 master should show versions of tservers, version summary
......................................................................
KUDU-1048 master should show versions of tservers, version summary
This patch adds a version summary table and a total count of
registered tablet servers to /tablet-servers.
It also fixes the display of the registration, which was printing in
red font.
Sample: https://raw.githubusercontent.com/wdberkeley/kudu-cr/master/KUDU-1048-improved.png
Change-Id: Idd203209e3d99292018801b94ec2904b6634854f
---
M src/kudu/master/master-path-handlers.cc
M src/kudu/master/ts_descriptor.cc
M src/kudu/master/ts_descriptor.h
M src/kudu/master/ts_manager.cc
4 files changed, 47 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/4104/2
--
To view, visit http://gerrit.cloudera.org:8080/4104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd203209e3d99292018801b94ec2904b6634854f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-1048 master should show versions of tservers, version summary
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change.
Change subject: KUDU-1048 master should show versions of tservers, version summary
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/4104/1/src/kudu/master/master-path-handlers.cc
File src/kudu/master/master-path-handlers.cc:
PS1, Line 71: freqs
> technically these are counts not frequencies
I'm constructing a frequency table for the versions. Counts is more standard terminology for programming so I will swap it.
PS1, Line 78: ++
> I think a post-increment would be more standard-looking here.
Done
PS1, Line 88: th>Count</th><
> eg here you could have a "Count (Live)" and "Count (Dead)" or somesuch
Done
--
To view, visit http://gerrit.cloudera.org:8080/4104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd203209e3d99292018801b94ec2904b6634854f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1048 master should show versions of tservers, version summary
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1048 master should show versions of tservers, version summary
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/4104/1/src/kudu/master/master-path-handlers.cc
File src/kudu/master/master-path-handlers.cc:
PS1, Line 71: freqs
technically these are counts not frequencies
PS1, Line 78: ++
I think a post-increment would be more standard-looking here.
Also, I wonder whether we should actually build two counts, one for 'live' and one for 'presumed dead' tablet servers. Currently the master never "forgets" a tablet server. Perhaps a map<string, array<int, 2>> would be helpful?
The threshold for liveness is FLAGS_tserver_unresponsive_timeout_ms but that liveness check should probably be moved into a bool accessor in TSDescriptor for simplicity
PS1, Line 88: th>Count</th><
eg here you could have a "Count (Live)" and "Count (Dead)" or somesuch
--
To view, visit http://gerrit.cloudera.org:8080/4104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd203209e3d99292018801b94ec2904b6634854f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1048 master should show versions of tservers, version summary
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change.
Change subject: KUDU-1048 master should show versions of tservers, version summary
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4104/2/src/kudu/master/ts_manager.cc
File src/kudu/master/ts_manager.cc:
Line 103: if (ts->TimeSinceHeartbeat().ToMilliseconds() < FLAGS_tserver_unresponsive_timeout_ms) {
> can you use PresumedDead here now? then you shouldn't need the DECLARE in t
Done
--
To view, visit http://gerrit.cloudera.org:8080/4104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd203209e3d99292018801b94ec2904b6634854f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1048 master should show versions of tservers, version summary
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1048 master should show versions of tservers, version summary
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd203209e3d99292018801b94ec2904b6634854f
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] KUDU-1048 master should show versions of tservers, version summary
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: KUDU-1048 master should show versions of tservers, version summary
......................................................................
Patch Set 2:
Build Started http://104.196.14.100/job/kudu-gerrit/3040/
--
To view, visit http://gerrit.cloudera.org:8080/4104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd203209e3d99292018801b94ec2904b6634854f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] KUDU-1048 master should show versions of tservers, version summary
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: KUDU-1048 master should show versions of tservers, version summary
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/3037/
--
To view, visit http://gerrit.cloudera.org:8080/4104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd203209e3d99292018801b94ec2904b6634854f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] KUDU-1048 master should show versions of tservers, version summary
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4104
to look at the new patch set (#3).
Change subject: KUDU-1048 master should show versions of tservers, version summary
......................................................................
KUDU-1048 master should show versions of tservers, version summary
This patch adds a version summary table and a total count of
registered tablet servers to /tablet-servers.
It also fixes the display of the registration, which was printing in
red font.
Sample: https://raw.githubusercontent.com/wdberkeley/kudu-cr/master/KUDU-1048-improved.png
Change-Id: Idd203209e3d99292018801b94ec2904b6634854f
---
M src/kudu/master/master-path-handlers.cc
M src/kudu/master/ts_descriptor.cc
M src/kudu/master/ts_descriptor.h
M src/kudu/master/ts_manager.cc
4 files changed, 46 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/4104/3
--
To view, visit http://gerrit.cloudera.org:8080/4104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd203209e3d99292018801b94ec2904b6634854f
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] KUDU-1048 master should show versions of tservers, version summary
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: KUDU-1048 master should show versions of tservers, version summary
......................................................................
Patch Set 3:
Build Started http://104.196.14.100/job/kudu-gerrit/3129/
--
To view, visit http://gerrit.cloudera.org:8080/4104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd203209e3d99292018801b94ec2904b6634854f
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] KUDU-1048 master should show versions of tservers, version summary
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: KUDU-1048 master should show versions of tservers, version summary
......................................................................
KUDU-1048 master should show versions of tservers, version summary
This patch adds a version summary table and a total count of
registered tablet servers to /tablet-servers.
It also fixes the display of the registration, which was printing in
red font.
Sample: https://raw.githubusercontent.com/wdberkeley/kudu-cr/master/KUDU-1048-improved.png
Change-Id: Idd203209e3d99292018801b94ec2904b6634854f
Reviewed-on: http://gerrit.cloudera.org:8080/4104
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/master/master-path-handlers.cc
M src/kudu/master/ts_descriptor.cc
M src/kudu/master/ts_descriptor.h
M src/kudu/master/ts_manager.cc
4 files changed, 46 insertions(+), 14 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idd203209e3d99292018801b94ec2904b6634854f
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] KUDU-1048 master should show versions of tservers, version summary
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1048 master should show versions of tservers, version summary
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4104/2/src/kudu/master/ts_manager.cc
File src/kudu/master/ts_manager.cc:
Line 103: if (ts->TimeSinceHeartbeat().ToMilliseconds() < FLAGS_tserver_unresponsive_timeout_ms) {
can you use PresumedDead here now? then you shouldn't need the DECLARE in the header either, since the only access to that flag would be from the ts_descriptor.cc
--
To view, visit http://gerrit.cloudera.org:8080/4104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd203209e3d99292018801b94ec2904b6634854f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes