You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/10/18 21:17:36 UTC

[GitHub] [commons-collections] aherbert commented on a diff in pull request #335: [Collections-384][bloom filters] bit count producer operation is not clearly defined

aherbert commented on code in PR #335:
URL: https://github.com/apache/commons-collections/pull/335#discussion_r998720775


##########
src/test/java/org/apache/commons/collections4/bloomfilter/AbstractIndexProducerTest.java:
##########
@@ -43,7 +48,7 @@ public abstract class AbstractIndexProducerTest {
     /**
      * An expandable list of int values.
      */
-    private static class IntList {
+    protected static class IntList {

Review Comment:
   When I checked you had not pushed the entire AbstractBitCountProducerTest and so it was not (yet) used in that class. I see the changes now. Let me know when you have fixed everything and I'll review again.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org