You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Ivan Kelly (JIRA)" <ji...@apache.org> on 2010/07/02 17:20:50 UTC
[jira] Created: (ZOOKEEPER-802) Improved LogGraph filters +
documentation
Improved LogGraph filters + documentation
-----------------------------------------
Key: ZOOKEEPER-802
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-802
Project: Zookeeper
Issue Type: Improvement
Reporter: Ivan Kelly
Assignee: Ivan Kelly
Priority: Minor
The log filtering mechanism has been improved and extended to work with message logs. Also, the documentation has been moved into the forrest documentation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-802) Improved LogGraph filters +
documentation
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated ZOOKEEPER-802:
---------------------------------
Status: Open (was: Patch Available)
removed the generated html from patch
> Improved LogGraph filters + documentation
> -----------------------------------------
>
> Key: ZOOKEEPER-802
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-802
> Project: Zookeeper
> Issue Type: Improvement
> Affects Versions: 3.4.0
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-802.patch, ZOOKEEPER-802.patch, ZOOKEEPER-802.patch
>
>
> The log filtering mechanism has been improved and extended to work with message logs. Also, the documentation has been moved into the forrest documentation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-802) Improved LogGraph filters +
documentation
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12885548#action_12885548 ]
Hadoop QA commented on ZOOKEEPER-802:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12448783/ZOOKEEPER-802.patch
against trunk revision 960686.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/94/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/94/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/94/console
This message is automatically generated.
> Improved LogGraph filters + documentation
> -----------------------------------------
>
> Key: ZOOKEEPER-802
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-802
> Project: Zookeeper
> Issue Type: Improvement
> Affects Versions: 3.4.0
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-802.patch, ZOOKEEPER-802.patch, ZOOKEEPER-802.patch, ZOOKEEPER-802.patch
>
>
> The log filtering mechanism has been improved and extended to work with message logs. Also, the documentation has been moved into the forrest documentation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-802) Improved LogGraph filters +
documentation
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated ZOOKEEPER-802:
---------------------------------
Status: Patch Available (was: Open)
> Improved LogGraph filters + documentation
> -----------------------------------------
>
> Key: ZOOKEEPER-802
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-802
> Project: Zookeeper
> Issue Type: Improvement
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Minor
> Attachments: ZOOKEEPER-802.patch, ZOOKEEPER-802.patch
>
>
> The log filtering mechanism has been improved and extended to work with message logs. Also, the documentation has been moved into the forrest documentation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-802) Improved LogGraph filters +
documentation
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-802:
-----------------------------------
Status: Open (was: Patch Available)
Patch now works however this seems to have broken the session view - I don't see any user sessions in the UI (says something about no date and update filter, but I have no filter).
Also only shows servers 1-4 of 5 servers - I am running against the current svn trunk.
> Improved LogGraph filters + documentation
> -----------------------------------------
>
> Key: ZOOKEEPER-802
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-802
> Project: Zookeeper
> Issue Type: Improvement
> Affects Versions: 3.4.0
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-802.patch, ZOOKEEPER-802.patch, ZOOKEEPER-802.patch, ZOOKEEPER-802.patch
>
>
> The log filtering mechanism has been improved and extended to work with message logs. Also, the documentation has been moved into the forrest documentation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-802) Improved LogGraph filters +
documentation
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12885458#action_12885458 ]
Ivan Kelly commented on ZOOKEEPER-802:
--------------------------------------
I think the patching error must be related to the FLE changes which this change is dependent on. Ill upload a new patch once that one is submitted.
Regarding the docs, Bookkeeper was the only other contrib documented and that was in the main src/doc.
> Improved LogGraph filters + documentation
> -----------------------------------------
>
> Key: ZOOKEEPER-802
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-802
> Project: Zookeeper
> Issue Type: Improvement
> Affects Versions: 3.4.0
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-802.patch, ZOOKEEPER-802.patch
>
>
> The log filtering mechanism has been improved and extended to work with message logs. Also, the documentation has been moved into the forrest documentation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-802) Improved LogGraph filters +
documentation
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated ZOOKEEPER-802:
---------------------------------
Status: Patch Available (was: Open)
This applies cleanly to trunk. The tabs-spaces issue is still there in loggraph, but i'll submit a fixup for that as a separate patch as it'll be quite big.
> Improved LogGraph filters + documentation
> -----------------------------------------
>
> Key: ZOOKEEPER-802
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-802
> Project: Zookeeper
> Issue Type: Improvement
> Affects Versions: 3.4.0
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-802.patch, ZOOKEEPER-802.patch, ZOOKEEPER-802.patch
>
>
> The log filtering mechanism has been improved and extended to work with message logs. Also, the documentation has been moved into the forrest documentation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-802) Improved LogGraph filters +
documentation
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12885161#action_12885161 ]
Hadoop QA commented on ZOOKEEPER-802:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12448678/ZOOKEEPER-802.patch
against trunk revision 958096.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/131/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/131/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/131/console
This message is automatically generated.
> Improved LogGraph filters + documentation
> -----------------------------------------
>
> Key: ZOOKEEPER-802
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-802
> Project: Zookeeper
> Issue Type: Improvement
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Minor
> Attachments: ZOOKEEPER-802.patch, ZOOKEEPER-802.patch
>
>
> The log filtering mechanism has been improved and extended to work with message logs. Also, the documentation has been moved into the forrest documentation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-802) Improved LogGraph filters +
documentation
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12885994#action_12885994 ]
Hadoop QA commented on ZOOKEEPER-802:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12448889/ZOOKEEPER-802.patch
against trunk revision 961026.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/135/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/135/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/135/console
This message is automatically generated.
> Improved LogGraph filters + documentation
> -----------------------------------------
>
> Key: ZOOKEEPER-802
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-802
> Project: Zookeeper
> Issue Type: Improvement
> Affects Versions: 3.4.0
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: logs.tar.gz, ZOOKEEPER-802.patch, ZOOKEEPER-802.patch, ZOOKEEPER-802.patch, ZOOKEEPER-802.patch, ZOOKEEPER-802.patch
>
>
> The log filtering mechanism has been improved and extended to work with message logs. Also, the documentation has been moved into the forrest documentation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-802) Improved LogGraph filters +
documentation
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892249#action_12892249 ]
Ivan Kelly commented on ZOOKEEPER-802:
--------------------------------------
Were you testing with transaction logs or message logs when the session view didn't work. Session view only works with transaction logs.
> Improved LogGraph filters + documentation
> -----------------------------------------
>
> Key: ZOOKEEPER-802
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-802
> Project: Zookeeper
> Issue Type: Improvement
> Affects Versions: 3.4.0
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: logs.tar.gz, ZOOKEEPER-802.patch, ZOOKEEPER-802.patch, ZOOKEEPER-802.patch, ZOOKEEPER-802.patch, ZOOKEEPER-802.patch
>
>
> The log filtering mechanism has been improved and extended to work with message logs. Also, the documentation has been moved into the forrest documentation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-802) Improved LogGraph filters +
documentation
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated ZOOKEEPER-802:
---------------------------------
Status: Patch Available (was: Open)
> Improved LogGraph filters + documentation
> -----------------------------------------
>
> Key: ZOOKEEPER-802
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-802
> Project: Zookeeper
> Issue Type: Improvement
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Minor
> Attachments: ZOOKEEPER-802.patch
>
>
> The log filtering mechanism has been improved and extended to work with message logs. Also, the documentation has been moved into the forrest documentation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-802) Improved LogGraph filters +
documentation
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-802:
-----------------------------------
Status: Open (was: Patch Available)
Affects Version/s: 3.4.0
Fix Version/s: 3.4.0
This patch fails to apply to latest trunk:
patching file src/contrib/loggraph/src/java/org/apache/zookeeper/graph/JsonGenerator.java
Hunk #1 FAILED at 74.
Hunk #3 FAILED at 121.
Hunk #4 FAILED at 157.
Hunk #5 succeeded at 178 (offset -3 lines).
3 out of 5 hunks FAILED -- saving rejects to file src/contrib/loggraph/src/java/org/apache/zookeeper/graph/JsonGenerator.java.rej
> Improved LogGraph filters + documentation
> -----------------------------------------
>
> Key: ZOOKEEPER-802
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-802
> Project: Zookeeper
> Issue Type: Improvement
> Affects Versions: 3.4.0
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-802.patch, ZOOKEEPER-802.patch
>
>
> The log filtering mechanism has been improved and extended to work with message logs. Also, the documentation has been moved into the forrest documentation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-802) Improved LogGraph filters +
documentation
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated ZOOKEEPER-802:
---------------------------------
Attachment: ZOOKEEPER-802.patch
> Improved LogGraph filters + documentation
> -----------------------------------------
>
> Key: ZOOKEEPER-802
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-802
> Project: Zookeeper
> Issue Type: Improvement
> Affects Versions: 3.4.0
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-802.patch, ZOOKEEPER-802.patch, ZOOKEEPER-802.patch, ZOOKEEPER-802.patch
>
>
> The log filtering mechanism has been improved and extended to work with message logs. Also, the documentation has been moved into the forrest documentation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-802) Improved LogGraph filters +
documentation
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-802:
-----------------------------------
Status: Open (was: Patch Available)
I'm afraid the sessions view is still broken. I have sessions but they are not showing up. Also there is some weirdness in the filters - I have no filters but once I loaded new log files (really the same log files loaded again) and after doing so no only were there no sessions but also the server view was empty as well.
> Improved LogGraph filters + documentation
> -----------------------------------------
>
> Key: ZOOKEEPER-802
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-802
> Project: Zookeeper
> Issue Type: Improvement
> Affects Versions: 3.4.0
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: logs.tar.gz, ZOOKEEPER-802.patch, ZOOKEEPER-802.patch, ZOOKEEPER-802.patch, ZOOKEEPER-802.patch, ZOOKEEPER-802.patch
>
>
> The log filtering mechanism has been improved and extended to work with message logs. Also, the documentation has been moved into the forrest documentation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-802) Improved LogGraph filters +
documentation
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated ZOOKEEPER-802:
---------------------------------
Attachment: ZOOKEEPER-802.patch
> Improved LogGraph filters + documentation
> -----------------------------------------
>
> Key: ZOOKEEPER-802
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-802
> Project: Zookeeper
> Issue Type: Improvement
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Minor
> Attachments: ZOOKEEPER-802.patch
>
>
> The log filtering mechanism has been improved and extended to work with message logs. Also, the documentation has been moved into the forrest documentation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-802) Improved LogGraph filters +
documentation
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12884727#action_12884727 ]
Hadoop QA commented on ZOOKEEPER-802:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12448577/ZOOKEEPER-802.patch
against trunk revision 958096.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/129/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/129/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/129/console
This message is automatically generated.
> Improved LogGraph filters + documentation
> -----------------------------------------
>
> Key: ZOOKEEPER-802
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-802
> Project: Zookeeper
> Issue Type: Improvement
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Minor
> Attachments: ZOOKEEPER-802.patch
>
>
> The log filtering mechanism has been improved and extended to work with message logs. Also, the documentation has been moved into the forrest documentation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-802) Improved LogGraph filters +
documentation
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12885847#action_12885847 ]
Hadoop QA commented on ZOOKEEPER-802:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12448753/ZOOKEEPER-802.patch
against trunk revision 960686.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/134/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/134/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/134/console
This message is automatically generated.
> Improved LogGraph filters + documentation
> -----------------------------------------
>
> Key: ZOOKEEPER-802
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-802
> Project: Zookeeper
> Issue Type: Improvement
> Affects Versions: 3.4.0
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-802.patch, ZOOKEEPER-802.patch, ZOOKEEPER-802.patch, ZOOKEEPER-802.patch
>
>
> The log filtering mechanism has been improved and extended to work with message logs. Also, the documentation has been moved into the forrest documentation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-802) Improved LogGraph filters +
documentation
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated ZOOKEEPER-802:
---------------------------------
Status: Open (was: Patch Available)
Included some stuff from another patch by mistake.
> Improved LogGraph filters + documentation
> -----------------------------------------
>
> Key: ZOOKEEPER-802
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-802
> Project: Zookeeper
> Issue Type: Improvement
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Minor
> Attachments: ZOOKEEPER-802.patch
>
>
> The log filtering mechanism has been improved and extended to work with message logs. Also, the documentation has been moved into the forrest documentation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-802) Improved LogGraph filters +
documentation
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12885338#action_12885338 ]
Patrick Hunt commented on ZOOKEEPER-802:
----------------------------------------
typically the docs for contribs reside inside the contrib, not in the main src doc. Not too big a deal to me, I'm not sure how others might feel about it...
> Improved LogGraph filters + documentation
> -----------------------------------------
>
> Key: ZOOKEEPER-802
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-802
> Project: Zookeeper
> Issue Type: Improvement
> Affects Versions: 3.4.0
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-802.patch, ZOOKEEPER-802.patch
>
>
> The log filtering mechanism has been improved and extended to work with message logs. Also, the documentation has been moved into the forrest documentation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-802) Improved LogGraph filters +
documentation
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated ZOOKEEPER-802:
---------------------------------
Attachment: ZOOKEEPER-802.patch
> Improved LogGraph filters + documentation
> -----------------------------------------
>
> Key: ZOOKEEPER-802
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-802
> Project: Zookeeper
> Issue Type: Improvement
> Affects Versions: 3.4.0
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: logs.tar.gz, ZOOKEEPER-802.patch, ZOOKEEPER-802.patch, ZOOKEEPER-802.patch, ZOOKEEPER-802.patch, ZOOKEEPER-802.patch
>
>
> The log filtering mechanism has been improved and extended to work with message logs. Also, the documentation has been moved into the forrest documentation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-802) Improved LogGraph filters +
documentation
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-802:
-----------------------------------
Attachment: logs.tar.gz
logs that show the failure I'm seeing. (server 5 missing from graph and sessions not showing up)
> Improved LogGraph filters + documentation
> -----------------------------------------
>
> Key: ZOOKEEPER-802
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-802
> Project: Zookeeper
> Issue Type: Improvement
> Affects Versions: 3.4.0
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: logs.tar.gz, ZOOKEEPER-802.patch, ZOOKEEPER-802.patch, ZOOKEEPER-802.patch, ZOOKEEPER-802.patch
>
>
> The log filtering mechanism has been improved and extended to work with message logs. Also, the documentation has been moved into the forrest documentation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-802) Improved LogGraph filters +
documentation
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated ZOOKEEPER-802:
---------------------------------
Status: Patch Available (was: Open)
Comments addressed.
> Improved LogGraph filters + documentation
> -----------------------------------------
>
> Key: ZOOKEEPER-802
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-802
> Project: Zookeeper
> Issue Type: Improvement
> Affects Versions: 3.4.0
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: logs.tar.gz, ZOOKEEPER-802.patch, ZOOKEEPER-802.patch, ZOOKEEPER-802.patch, ZOOKEEPER-802.patch, ZOOKEEPER-802.patch
>
>
> The log filtering mechanism has been improved and extended to work with message logs. Also, the documentation has been moved into the forrest documentation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-802) Improved LogGraph filters +
documentation
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated ZOOKEEPER-802:
---------------------------------
Attachment: ZOOKEEPER-802.patch
> Improved LogGraph filters + documentation
> -----------------------------------------
>
> Key: ZOOKEEPER-802
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-802
> Project: Zookeeper
> Issue Type: Improvement
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Minor
> Attachments: ZOOKEEPER-802.patch, ZOOKEEPER-802.patch
>
>
> The log filtering mechanism has been improved and extended to work with message logs. Also, the documentation has been moved into the forrest documentation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-802) Improved LogGraph filters +
documentation
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated ZOOKEEPER-802:
---------------------------------
Attachment: ZOOKEEPER-802.patch
> Improved LogGraph filters + documentation
> -----------------------------------------
>
> Key: ZOOKEEPER-802
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-802
> Project: Zookeeper
> Issue Type: Improvement
> Affects Versions: 3.4.0
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-802.patch, ZOOKEEPER-802.patch, ZOOKEEPER-802.patch
>
>
> The log filtering mechanism has been improved and extended to work with message logs. Also, the documentation has been moved into the forrest documentation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-802) Improved LogGraph filters +
documentation
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated ZOOKEEPER-802:
---------------------------------
Status: Patch Available (was: Open)
> Improved LogGraph filters + documentation
> -----------------------------------------
>
> Key: ZOOKEEPER-802
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-802
> Project: Zookeeper
> Issue Type: Improvement
> Affects Versions: 3.4.0
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-802.patch, ZOOKEEPER-802.patch, ZOOKEEPER-802.patch, ZOOKEEPER-802.patch
>
>
> The log filtering mechanism has been improved and extended to work with message logs. Also, the documentation has been moved into the forrest documentation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.