You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2012/11/09 03:21:25 UTC

Review Request: SQOOP-684 Encode type of the job into executed map reduce job

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7982/
-----------------------------------------------------------

Review request for Sqoop.


Description
-------

I've put explicit information about Job type into generated mapreduce job.


This addresses bug SQOOP-684.
    https://issues.apache.org/jira/browse/SQOOP-684


Diffs
-----

  core/src/main/java/org/apache/sqoop/core/CoreError.java 29c0809c75b367a287b5ef7baca07fd3a6493612 
  core/src/main/java/org/apache/sqoop/framework/ExecutionEngine.java e1ccdf6aef39dea2be01c86a571d93c4737b5473 
  core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java f4be6395e9c8cff6d061dba40ad44fd48114406b 
  core/src/main/java/org/apache/sqoop/framework/SubmissionRequest.java c70a5cc5e7108e775d9f3cac7bb8fa5a56cbd0a3 
  execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MRSubmissionRequest.java 3f3722223eea1128da107f6d7dd17b7ffa3d54eb 
  execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java 77ca59bad60481c353673082d62245026699649d 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/JobConstants.java 19ac91e00ad92f6b17bd6e210c1b8e293e8f2960 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java ae647cead6bab955e81aedf0c364c51a920a62be 
  execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java 6892b4b5f48ada17185ca2bd170a8af3d87483db 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/TestHdfsLoad.java 812dd8e034a5f1f30ca534aa71b895b934b5c863 
  execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java e269899827d83a53d2406c0179b0622544f02bef 
  submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java b8415e3f4f3c33361b5a02b752bf9b38eb341a91 

Diff: https://reviews.apache.org/r/7982/diff/


Testing
-------


Thanks,

Jarek Cecho

Re: Review Request: SQOOP-684 Encode type of the job into executed map reduce job

Posted by Bilung Lee <bl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7982/#review13305
-----------------------------------------------------------

Ship it!


Ship It!

- Bilung Lee


On Nov. 9, 2012, 2:21 a.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7982/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2012, 2:21 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> I've put explicit information about Job type into generated mapreduce job.
> 
> 
> This addresses bug SQOOP-684.
>     https://issues.apache.org/jira/browse/SQOOP-684
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/sqoop/core/CoreError.java 29c0809c75b367a287b5ef7baca07fd3a6493612 
>   core/src/main/java/org/apache/sqoop/framework/ExecutionEngine.java e1ccdf6aef39dea2be01c86a571d93c4737b5473 
>   core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java f4be6395e9c8cff6d061dba40ad44fd48114406b 
>   core/src/main/java/org/apache/sqoop/framework/SubmissionRequest.java c70a5cc5e7108e775d9f3cac7bb8fa5a56cbd0a3 
>   execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MRSubmissionRequest.java 3f3722223eea1128da107f6d7dd17b7ffa3d54eb 
>   execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java 77ca59bad60481c353673082d62245026699649d 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/JobConstants.java 19ac91e00ad92f6b17bd6e210c1b8e293e8f2960 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java ae647cead6bab955e81aedf0c364c51a920a62be 
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopMapper.java 6892b4b5f48ada17185ca2bd170a8af3d87483db 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestHdfsLoad.java 812dd8e034a5f1f30ca534aa71b895b934b5c863 
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java e269899827d83a53d2406c0179b0622544f02bef 
>   submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java b8415e3f4f3c33361b5a02b752bf9b38eb341a91 
> 
> Diff: https://reviews.apache.org/r/7982/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>