You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/08/27 10:41:09 UTC

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #419: fix: ActionBar should not appear in create/edit route resultview

juzhiyuan commented on a change in pull request #419:
URL: https://github.com/apache/apisix-dashboard/pull/419#discussion_r478323368



##########
File path: src/pages/Route/Create.tsx
##########
@@ -270,7 +270,11 @@ const Page: React.FC<Props> = (props) => {
           {renderStep()}
         </Card>
       </PageHeaderWrapper>
-      <ActionBar step={step} lastStep={redirect ? 2 : 4} onChange={onStepChange} withResultView />
+      {step !== 5 ? (
+        <ActionBar step={step} lastStep={redirect ? 2 : 4} onChange={onStepChange} withResultView />

Review comment:
       Why not update Action directly? 

##########
File path: src/pages/Route/Create.tsx
##########
@@ -270,7 +270,11 @@ const Page: React.FC<Props> = (props) => {
           {renderStep()}
         </Card>
       </PageHeaderWrapper>
-      <ActionBar step={step} lastStep={redirect ? 2 : 4} onChange={onStepChange} withResultView />
+      {step !== 5 ? (
+        <ActionBar step={step} lastStep={redirect ? 2 : 4} onChange={onStepChange} withResultView />

Review comment:
       Good point but why not update Action directly? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org