You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/07/19 09:39:56 UTC

[GitHub] [ignite-3] zstan commented on a diff in pull request #945: IGNITE-17328 Introduce implicit transactions from SQL

zstan commented on code in PR #945:
URL: https://github.com/apache/ignite-3/pull/945#discussion_r924285636


##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/AsyncSqlCursorImpl.java:
##########
@@ -71,6 +77,10 @@ public CompletionStage<BatchedResult<T>> requestNextAsync(int rows) {
                     t = t.getCause();
                 }
 
+                if (tx != null) {

Review Comment:
   we need to somehow handle tx here, this is exceptionally situation, i agree that probably not in all cases we need rollback, but this need to be discussed somehow and probably under differ issue.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org