You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/06/21 17:35:33 UTC
[GitHub] [flink] akalash opened a new pull request #16227: [FLINK-23041][streaming] Added new well defined checkpoint configuration aligned-checkpoint-timeout instead of alignment-timeout
akalash opened a new pull request #16227:
URL: https://github.com/apache/flink/pull/16227
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*This PR adds new configuration aligned-checkpoint-timeout instead of alignment-timeout*
## Brief change log
-*alignment-timeout was deprecated*
-*aligned-checkpoint-timeout was added. It represents time since the global start of the checkpoint after which AC switches to UC*
## Verifying this change
This change added tests and can be verified as follows:
- *Added tests in AlternatingCheckpointTest*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (**yes** / no)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (**yes** / no)
- If yes, how is the feature documented? (not applicable / **docs** / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] akalash commented on a change in pull request #16227: [FLINK-23041][streaming] Added new well defined checkpoint configuration aligned-checkpoint-timeout instead of alignment-timeout
Posted by GitBox <gi...@apache.org>.
akalash commented on a change in pull request #16227:
URL: https://github.com/apache/flink/pull/16227#discussion_r659764657
##########
File path: docs/layouts/shortcodes/generated/rest_v1_dispatcher.html
##########
@@ -101,10 +101,10 @@
"type" : "object",
"id" : "urn:jsonschema:org:apache:flink:runtime:rest:messages:DashboardConfiguration:Features",
"properties" : {
- "web-submit" : {
Review comment:
This file is autogenerated but it looks like it is generated in alphabet order so it should be correct now. I can only guess but perhaps, initially, the author made these changes manually
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16227: [FLINK-23041][streaming] Added new well defined checkpoint configuration aligned-checkpoint-timeout instead of alignment-timeout
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16227:
URL: https://github.com/apache/flink/pull/16227#issuecomment-865242134
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a6971ac844ae62b0af49c935f82bd306168b146d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19261",
"triggerID" : "a6971ac844ae62b0af49c935f82bd306168b146d",
"triggerType" : "PUSH"
}, {
"hash" : "058af60e4592de5e83d7ba6a4165a169d986f409",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19330",
"triggerID" : "058af60e4592de5e83d7ba6a4165a169d986f409",
"triggerType" : "PUSH"
}, {
"hash" : "ac27568d7b4dcb40ab08da6ad5c8eb4f799d5b12",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19354",
"triggerID" : "ac27568d7b4dcb40ab08da6ad5c8eb4f799d5b12",
"triggerType" : "PUSH"
}, {
"hash" : "757fe7352ef110e3ce9192d92839a435b0ca9498",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19372",
"triggerID" : "757fe7352ef110e3ce9192d92839a435b0ca9498",
"triggerType" : "PUSH"
}, {
"hash" : "9a20519f5838e1a41cf5682735a9a4283b5003d5",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19404",
"triggerID" : "9a20519f5838e1a41cf5682735a9a4283b5003d5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9a20519f5838e1a41cf5682735a9a4283b5003d5 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19404)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16227: [FLINK-23041][streaming] Added new well defined checkpoint configuration aligned-checkpoint-timeout instead of alignment-timeout
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16227:
URL: https://github.com/apache/flink/pull/16227#issuecomment-865242134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16227: [FLINK-23041][streaming] Added new well defined checkpoint configuration aligned-checkpoint-timeout instead of alignment-timeout
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16227:
URL: https://github.com/apache/flink/pull/16227#issuecomment-865242134
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a6971ac844ae62b0af49c935f82bd306168b146d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a6971ac844ae62b0af49c935f82bd306168b146d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a6971ac844ae62b0af49c935f82bd306168b146d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16227: [FLINK-23041][streaming] Added new well defined checkpoint configuration aligned-checkpoint-timeout instead of alignment-timeout
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16227:
URL: https://github.com/apache/flink/pull/16227#issuecomment-865242134
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a6971ac844ae62b0af49c935f82bd306168b146d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19261",
"triggerID" : "a6971ac844ae62b0af49c935f82bd306168b146d",
"triggerType" : "PUSH"
}, {
"hash" : "058af60e4592de5e83d7ba6a4165a169d986f409",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19330",
"triggerID" : "058af60e4592de5e83d7ba6a4165a169d986f409",
"triggerType" : "PUSH"
}, {
"hash" : "ac27568d7b4dcb40ab08da6ad5c8eb4f799d5b12",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ac27568d7b4dcb40ab08da6ad5c8eb4f799d5b12",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 058af60e4592de5e83d7ba6a4165a169d986f409 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19330)
* ac27568d7b4dcb40ab08da6ad5c8eb4f799d5b12 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] akalash commented on pull request #16227: [FLINK-23041][streaming] Added new well defined checkpoint configuration aligned-checkpoint-timeout instead of alignment-timeout
Posted by GitBox <gi...@apache.org>.
akalash commented on pull request #16227:
URL: https://github.com/apache/flink/pull/16227#issuecomment-869689848
@dawidwys, I added the documentation - https://github.com/apache/flink/pull/16227/files#diff-330cebde422d7911fd9cb5f32e58770389b13862cb372e6fdb276ba44bb3c4ac, I don't really sure what should I do with the old alignment timeout but as you can see I just deprecated it. I hope it is ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16227: [FLINK-23041][streaming] Added new well defined checkpoint configuration aligned-checkpoint-timeout instead of alignment-timeout
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16227:
URL: https://github.com/apache/flink/pull/16227#issuecomment-865242134
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a6971ac844ae62b0af49c935f82bd306168b146d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19261",
"triggerID" : "a6971ac844ae62b0af49c935f82bd306168b146d",
"triggerType" : "PUSH"
}, {
"hash" : "058af60e4592de5e83d7ba6a4165a169d986f409",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19330",
"triggerID" : "058af60e4592de5e83d7ba6a4165a169d986f409",
"triggerType" : "PUSH"
}, {
"hash" : "ac27568d7b4dcb40ab08da6ad5c8eb4f799d5b12",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19354",
"triggerID" : "ac27568d7b4dcb40ab08da6ad5c8eb4f799d5b12",
"triggerType" : "PUSH"
}, {
"hash" : "757fe7352ef110e3ce9192d92839a435b0ca9498",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19372",
"triggerID" : "757fe7352ef110e3ce9192d92839a435b0ca9498",
"triggerType" : "PUSH"
}, {
"hash" : "9a20519f5838e1a41cf5682735a9a4283b5003d5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19404",
"triggerID" : "9a20519f5838e1a41cf5682735a9a4283b5003d5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 757fe7352ef110e3ce9192d92839a435b0ca9498 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19372)
* 9a20519f5838e1a41cf5682735a9a4283b5003d5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19404)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16227: [FLINK-23041][streaming] Added new well defined checkpoint configuration aligned-checkpoint-timeout instead of alignment-timeout
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16227:
URL: https://github.com/apache/flink/pull/16227#issuecomment-865221778
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit a6971ac844ae62b0af49c935f82bd306168b146d (Mon Jun 21 17:38:54 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16227: [FLINK-23041][streaming] Added new well defined checkpoint configuration aligned-checkpoint-timeout instead of alignment-timeout
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16227:
URL: https://github.com/apache/flink/pull/16227#issuecomment-865242134
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a6971ac844ae62b0af49c935f82bd306168b146d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19261",
"triggerID" : "a6971ac844ae62b0af49c935f82bd306168b146d",
"triggerType" : "PUSH"
}, {
"hash" : "058af60e4592de5e83d7ba6a4165a169d986f409",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19330",
"triggerID" : "058af60e4592de5e83d7ba6a4165a169d986f409",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 058af60e4592de5e83d7ba6a4165a169d986f409 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19330)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16227: [FLINK-23041][streaming] Added new well defined checkpoint configuration aligned-checkpoint-timeout instead of alignment-timeout
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16227:
URL: https://github.com/apache/flink/pull/16227#issuecomment-865242134
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a6971ac844ae62b0af49c935f82bd306168b146d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19261",
"triggerID" : "a6971ac844ae62b0af49c935f82bd306168b146d",
"triggerType" : "PUSH"
}, {
"hash" : "058af60e4592de5e83d7ba6a4165a169d986f409",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19330",
"triggerID" : "058af60e4592de5e83d7ba6a4165a169d986f409",
"triggerType" : "PUSH"
}, {
"hash" : "ac27568d7b4dcb40ab08da6ad5c8eb4f799d5b12",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19354",
"triggerID" : "ac27568d7b4dcb40ab08da6ad5c8eb4f799d5b12",
"triggerType" : "PUSH"
}, {
"hash" : "757fe7352ef110e3ce9192d92839a435b0ca9498",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19372",
"triggerID" : "757fe7352ef110e3ce9192d92839a435b0ca9498",
"triggerType" : "PUSH"
}, {
"hash" : "9a20519f5838e1a41cf5682735a9a4283b5003d5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9a20519f5838e1a41cf5682735a9a4283b5003d5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 757fe7352ef110e3ce9192d92839a435b0ca9498 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19372)
* 9a20519f5838e1a41cf5682735a9a4283b5003d5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16227: [FLINK-23041][streaming] Added new well defined checkpoint configuration aligned-checkpoint-timeout instead of alignment-timeout
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16227:
URL: https://github.com/apache/flink/pull/16227#issuecomment-865242134
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a6971ac844ae62b0af49c935f82bd306168b146d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19261",
"triggerID" : "a6971ac844ae62b0af49c935f82bd306168b146d",
"triggerType" : "PUSH"
}, {
"hash" : "058af60e4592de5e83d7ba6a4165a169d986f409",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19330",
"triggerID" : "058af60e4592de5e83d7ba6a4165a169d986f409",
"triggerType" : "PUSH"
}, {
"hash" : "ac27568d7b4dcb40ab08da6ad5c8eb4f799d5b12",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19354",
"triggerID" : "ac27568d7b4dcb40ab08da6ad5c8eb4f799d5b12",
"triggerType" : "PUSH"
}, {
"hash" : "757fe7352ef110e3ce9192d92839a435b0ca9498",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19372",
"triggerID" : "757fe7352ef110e3ce9192d92839a435b0ca9498",
"triggerType" : "PUSH"
}, {
"hash" : "9a20519f5838e1a41cf5682735a9a4283b5003d5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19404",
"triggerID" : "9a20519f5838e1a41cf5682735a9a4283b5003d5",
"triggerType" : "PUSH"
}, {
"hash" : "8613d508a347d7a0a80329b32384a5437dc8d3ae",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19630",
"triggerID" : "8613d508a347d7a0a80329b32384a5437dc8d3ae",
"triggerType" : "PUSH"
}, {
"hash" : "4fa243ae7b809dac330c63462a61959b8f320f07",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19631",
"triggerID" : "4fa243ae7b809dac330c63462a61959b8f320f07",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4fa243ae7b809dac330c63462a61959b8f320f07 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19631)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16227: [FLINK-23041][streaming] Added new well defined checkpoint configuration aligned-checkpoint-timeout instead of alignment-timeout
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16227:
URL: https://github.com/apache/flink/pull/16227#issuecomment-865221778
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16227: [FLINK-23041][streaming] Added new well defined checkpoint configuration aligned-checkpoint-timeout instead of alignment-timeout
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16227:
URL: https://github.com/apache/flink/pull/16227#issuecomment-865242134
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a6971ac844ae62b0af49c935f82bd306168b146d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19261",
"triggerID" : "a6971ac844ae62b0af49c935f82bd306168b146d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a6971ac844ae62b0af49c935f82bd306168b146d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19261)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] akalash commented on pull request #16227: [FLINK-23041][streaming] Added new well defined checkpoint configuration aligned-checkpoint-timeout instead of alignment-timeout
Posted by GitBox <gi...@apache.org>.
akalash commented on pull request #16227:
URL: https://github.com/apache/flink/pull/16227#issuecomment-869689848
@dawidwys, I added the documentation - https://github.com/apache/flink/pull/16227/files#diff-330cebde422d7911fd9cb5f32e58770389b13862cb372e6fdb276ba44bb3c4ac, I don't really sure what should I do with the old alignment timeout but as you can see I just deprecated it. I hope it is ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16227: [FLINK-23041][streaming] Added new well defined checkpoint configuration aligned-checkpoint-timeout instead of alignment-timeout
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16227:
URL: https://github.com/apache/flink/pull/16227#issuecomment-865242134
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a6971ac844ae62b0af49c935f82bd306168b146d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19261",
"triggerID" : "a6971ac844ae62b0af49c935f82bd306168b146d",
"triggerType" : "PUSH"
}, {
"hash" : "058af60e4592de5e83d7ba6a4165a169d986f409",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19330",
"triggerID" : "058af60e4592de5e83d7ba6a4165a169d986f409",
"triggerType" : "PUSH"
}, {
"hash" : "ac27568d7b4dcb40ab08da6ad5c8eb4f799d5b12",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19354",
"triggerID" : "ac27568d7b4dcb40ab08da6ad5c8eb4f799d5b12",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 058af60e4592de5e83d7ba6a4165a169d986f409 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19330)
* ac27568d7b4dcb40ab08da6ad5c8eb4f799d5b12 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19354)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on a change in pull request #16227: [FLINK-23041][streaming] Added new well defined checkpoint configuration aligned-checkpoint-timeout instead of alignment-timeout
Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #16227:
URL: https://github.com/apache/flink/pull/16227#discussion_r659689492
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/CheckpointConfig.java
##########
@@ -783,9 +816,17 @@ public void configure(ReadableConfig configuration) {
configuration
.getOptional(ExecutionCheckpointingOptions.CHECKPOINT_ID_OF_IGNORED_IN_FLIGHT_DATA)
.ifPresent(this::setCheckpointIdOfIgnoredInFlightData);
- configuration
- .getOptional(ExecutionCheckpointingOptions.ALIGNMENT_TIMEOUT)
- .ifPresent(this::setAlignmentTimeout);
+
+ Optional<Duration> alignedCheckpointTimeout =
+ configuration.getOptional(ExecutionCheckpointingOptions.ALIGNED_CHECKPOINT_TIMEOUT);
+ if (alignedCheckpointTimeout.isPresent()) {
Review comment:
IIRC this whole block is unnecessary. It is already implemented inside of the Configuration if you use the `deprecatedKeys`.
It should be enough to do:
```
Duration alignedCheckpointTimeout = configuration.get(ExecutionCheckpointingOptions.ALIGNED_CHECKPOINT_TIMEOUT);
```
##########
File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/checkpointing/AlternatingCheckpointsTest.java
##########
@@ -353,6 +353,30 @@ public void testTimeoutAlignmentOnFirstBarrier() throws Exception {
assertEquals(1, target.getTriggeredCheckpointCounter());
}
+ @Test
+ public void testTimeoutAlignmentBeforeFirstBarrier() throws Exception {
+ // given: Local channels.
+ int numChannels = 2;
+ ValidatingCheckpointHandler target = new ValidatingCheckpointHandler();
+ CheckpointedInputGate gate =
+ new TestCheckpointedInputGateBuilder(
+ numChannels, getTestBarrierHandlerFactory(target))
+ .withTestChannels()
+ .withMailboxExecutor()
+ .build();
+
+ long alignedCheckpointTimeout = 100;
+ // when: Aligned checkpoint timeout expired before the first barrier received.
+ Buffer checkpointBarrier = withTimeout(1, alignedCheckpointTimeout);
+ clock.advanceTime(alignedCheckpointTimeout + 1, TimeUnit.MILLISECONDS);
+
+ ((TestInputChannel) gate.getChannel(0)).read(checkpointBarrier.retainBuffer());
+
+ // then: The UC is triggered as soon as the first barrier will be received.
Review comment:
nit:
```suggestion
// then: The UC is triggered as soon as the first barrier is received.
```
##########
File path: docs/layouts/shortcodes/generated/rest_v1_dispatcher.html
##########
@@ -101,10 +101,10 @@
"type" : "object",
"id" : "urn:jsonschema:org:apache:flink:runtime:rest:messages:DashboardConfiguration:Features",
"properties" : {
- "web-submit" : {
Review comment:
Out of curiosity. Do you know where does the reordering comes from? Is the file autogenerated? If you don't know don't bother looking for an answer.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/tasks/CheckpointCoordinatorConfiguration.java
##########
@@ -207,6 +208,7 @@ public int hashCode() {
checkpointRetentionPolicy,
isExactlyOnce,
isUnalignedCheckpointsEnabled,
+ alignedCheckpointTimeout,
Review comment:
Good catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16227: [FLINK-23041][streaming] Added new well defined checkpoint configuration aligned-checkpoint-timeout instead of alignment-timeout
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16227:
URL: https://github.com/apache/flink/pull/16227#issuecomment-865242134
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a6971ac844ae62b0af49c935f82bd306168b146d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19261",
"triggerID" : "a6971ac844ae62b0af49c935f82bd306168b146d",
"triggerType" : "PUSH"
}, {
"hash" : "058af60e4592de5e83d7ba6a4165a169d986f409",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19330",
"triggerID" : "058af60e4592de5e83d7ba6a4165a169d986f409",
"triggerType" : "PUSH"
}, {
"hash" : "ac27568d7b4dcb40ab08da6ad5c8eb4f799d5b12",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19354",
"triggerID" : "ac27568d7b4dcb40ab08da6ad5c8eb4f799d5b12",
"triggerType" : "PUSH"
}, {
"hash" : "757fe7352ef110e3ce9192d92839a435b0ca9498",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "757fe7352ef110e3ce9192d92839a435b0ca9498",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 058af60e4592de5e83d7ba6a4165a169d986f409 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19330)
* ac27568d7b4dcb40ab08da6ad5c8eb4f799d5b12 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19354)
* 757fe7352ef110e3ce9192d92839a435b0ca9498 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16227: [FLINK-23041][streaming] Added new well defined checkpoint configuration aligned-checkpoint-timeout instead of alignment-timeout
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16227:
URL: https://github.com/apache/flink/pull/16227#issuecomment-865242134
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a6971ac844ae62b0af49c935f82bd306168b146d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19261",
"triggerID" : "a6971ac844ae62b0af49c935f82bd306168b146d",
"triggerType" : "PUSH"
}, {
"hash" : "058af60e4592de5e83d7ba6a4165a169d986f409",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "058af60e4592de5e83d7ba6a4165a169d986f409",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a6971ac844ae62b0af49c935f82bd306168b146d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19261)
* 058af60e4592de5e83d7ba6a4165a169d986f409 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16227: [FLINK-23041][streaming] Added new well defined checkpoint configuration aligned-checkpoint-timeout instead of alignment-timeout
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16227:
URL: https://github.com/apache/flink/pull/16227#issuecomment-865242134
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a6971ac844ae62b0af49c935f82bd306168b146d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19261",
"triggerID" : "a6971ac844ae62b0af49c935f82bd306168b146d",
"triggerType" : "PUSH"
}, {
"hash" : "058af60e4592de5e83d7ba6a4165a169d986f409",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19330",
"triggerID" : "058af60e4592de5e83d7ba6a4165a169d986f409",
"triggerType" : "PUSH"
}, {
"hash" : "ac27568d7b4dcb40ab08da6ad5c8eb4f799d5b12",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19354",
"triggerID" : "ac27568d7b4dcb40ab08da6ad5c8eb4f799d5b12",
"triggerType" : "PUSH"
}, {
"hash" : "757fe7352ef110e3ce9192d92839a435b0ca9498",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19372",
"triggerID" : "757fe7352ef110e3ce9192d92839a435b0ca9498",
"triggerType" : "PUSH"
}, {
"hash" : "9a20519f5838e1a41cf5682735a9a4283b5003d5",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19404",
"triggerID" : "9a20519f5838e1a41cf5682735a9a4283b5003d5",
"triggerType" : "PUSH"
}, {
"hash" : "8613d508a347d7a0a80329b32384a5437dc8d3ae",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19630",
"triggerID" : "8613d508a347d7a0a80329b32384a5437dc8d3ae",
"triggerType" : "PUSH"
}, {
"hash" : "4fa243ae7b809dac330c63462a61959b8f320f07",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4fa243ae7b809dac330c63462a61959b8f320f07",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9a20519f5838e1a41cf5682735a9a4283b5003d5 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19404)
* 8613d508a347d7a0a80329b32384a5437dc8d3ae Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19630)
* 4fa243ae7b809dac330c63462a61959b8f320f07 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16227: [FLINK-23041][streaming] Added new well defined checkpoint configuration aligned-checkpoint-timeout instead of alignment-timeout
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16227:
URL: https://github.com/apache/flink/pull/16227#issuecomment-865242134
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a6971ac844ae62b0af49c935f82bd306168b146d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19261",
"triggerID" : "a6971ac844ae62b0af49c935f82bd306168b146d",
"triggerType" : "PUSH"
}, {
"hash" : "058af60e4592de5e83d7ba6a4165a169d986f409",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19330",
"triggerID" : "058af60e4592de5e83d7ba6a4165a169d986f409",
"triggerType" : "PUSH"
}, {
"hash" : "ac27568d7b4dcb40ab08da6ad5c8eb4f799d5b12",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19354",
"triggerID" : "ac27568d7b4dcb40ab08da6ad5c8eb4f799d5b12",
"triggerType" : "PUSH"
}, {
"hash" : "757fe7352ef110e3ce9192d92839a435b0ca9498",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19372",
"triggerID" : "757fe7352ef110e3ce9192d92839a435b0ca9498",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ac27568d7b4dcb40ab08da6ad5c8eb4f799d5b12 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19354)
* 757fe7352ef110e3ce9192d92839a435b0ca9498 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19372)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys closed pull request #16227: [FLINK-23041][streaming] Added new well defined checkpoint configuration aligned-checkpoint-timeout instead of alignment-timeout
Posted by GitBox <gi...@apache.org>.
dawidwys closed pull request #16227:
URL: https://github.com/apache/flink/pull/16227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys closed pull request #16227: [FLINK-23041][streaming] Added new well defined checkpoint configuration aligned-checkpoint-timeout instead of alignment-timeout
Posted by GitBox <gi...@apache.org>.
dawidwys closed pull request #16227:
URL: https://github.com/apache/flink/pull/16227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16227: [FLINK-23041][streaming] Added new well defined checkpoint configuration aligned-checkpoint-timeout instead of alignment-timeout
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16227:
URL: https://github.com/apache/flink/pull/16227#issuecomment-865221778
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 4fa243ae7b809dac330c63462a61959b8f320f07 (Thu Sep 23 17:53:02 UTC 2021)
**Warnings:**
* Documentation files were touched, but no `docs/content.zh/` files: Update Chinese documentation or file Jira ticket.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16227: [FLINK-23041][streaming] Added new well defined checkpoint configuration aligned-checkpoint-timeout instead of alignment-timeout
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16227:
URL: https://github.com/apache/flink/pull/16227#issuecomment-865242134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16227: [FLINK-23041][streaming] Added new well defined checkpoint configuration aligned-checkpoint-timeout instead of alignment-timeout
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16227:
URL: https://github.com/apache/flink/pull/16227#issuecomment-865242134
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a6971ac844ae62b0af49c935f82bd306168b146d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19261",
"triggerID" : "a6971ac844ae62b0af49c935f82bd306168b146d",
"triggerType" : "PUSH"
}, {
"hash" : "058af60e4592de5e83d7ba6a4165a169d986f409",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19330",
"triggerID" : "058af60e4592de5e83d7ba6a4165a169d986f409",
"triggerType" : "PUSH"
}, {
"hash" : "ac27568d7b4dcb40ab08da6ad5c8eb4f799d5b12",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19354",
"triggerID" : "ac27568d7b4dcb40ab08da6ad5c8eb4f799d5b12",
"triggerType" : "PUSH"
}, {
"hash" : "757fe7352ef110e3ce9192d92839a435b0ca9498",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19372",
"triggerID" : "757fe7352ef110e3ce9192d92839a435b0ca9498",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 757fe7352ef110e3ce9192d92839a435b0ca9498 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19372)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16227: [FLINK-23041][streaming] Added new well defined checkpoint configuration aligned-checkpoint-timeout instead of alignment-timeout
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16227:
URL: https://github.com/apache/flink/pull/16227#issuecomment-865242134
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a6971ac844ae62b0af49c935f82bd306168b146d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19261",
"triggerID" : "a6971ac844ae62b0af49c935f82bd306168b146d",
"triggerType" : "PUSH"
}, {
"hash" : "058af60e4592de5e83d7ba6a4165a169d986f409",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19330",
"triggerID" : "058af60e4592de5e83d7ba6a4165a169d986f409",
"triggerType" : "PUSH"
}, {
"hash" : "ac27568d7b4dcb40ab08da6ad5c8eb4f799d5b12",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19354",
"triggerID" : "ac27568d7b4dcb40ab08da6ad5c8eb4f799d5b12",
"triggerType" : "PUSH"
}, {
"hash" : "757fe7352ef110e3ce9192d92839a435b0ca9498",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19372",
"triggerID" : "757fe7352ef110e3ce9192d92839a435b0ca9498",
"triggerType" : "PUSH"
}, {
"hash" : "9a20519f5838e1a41cf5682735a9a4283b5003d5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19404",
"triggerID" : "9a20519f5838e1a41cf5682735a9a4283b5003d5",
"triggerType" : "PUSH"
}, {
"hash" : "8613d508a347d7a0a80329b32384a5437dc8d3ae",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19630",
"triggerID" : "8613d508a347d7a0a80329b32384a5437dc8d3ae",
"triggerType" : "PUSH"
}, {
"hash" : "4fa243ae7b809dac330c63462a61959b8f320f07",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19631",
"triggerID" : "4fa243ae7b809dac330c63462a61959b8f320f07",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8613d508a347d7a0a80329b32384a5437dc8d3ae Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19630)
* 4fa243ae7b809dac330c63462a61959b8f320f07 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19631)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on pull request #16227: [FLINK-23041][streaming] Added new well defined checkpoint configuration aligned-checkpoint-timeout instead of alignment-timeout
Posted by GitBox <gi...@apache.org>.
dawidwys commented on pull request #16227:
URL: https://github.com/apache/flink/pull/16227#issuecomment-869694972
Let's just drop the old value. It wasn't properly advertised and I think it doesn't make much sense to document it on that general page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16227: [FLINK-23041][streaming] Added new well defined checkpoint configuration aligned-checkpoint-timeout instead of alignment-timeout
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16227:
URL: https://github.com/apache/flink/pull/16227#issuecomment-865242134
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a6971ac844ae62b0af49c935f82bd306168b146d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19261",
"triggerID" : "a6971ac844ae62b0af49c935f82bd306168b146d",
"triggerType" : "PUSH"
}, {
"hash" : "058af60e4592de5e83d7ba6a4165a169d986f409",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19330",
"triggerID" : "058af60e4592de5e83d7ba6a4165a169d986f409",
"triggerType" : "PUSH"
}, {
"hash" : "ac27568d7b4dcb40ab08da6ad5c8eb4f799d5b12",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19354",
"triggerID" : "ac27568d7b4dcb40ab08da6ad5c8eb4f799d5b12",
"triggerType" : "PUSH"
}, {
"hash" : "757fe7352ef110e3ce9192d92839a435b0ca9498",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19372",
"triggerID" : "757fe7352ef110e3ce9192d92839a435b0ca9498",
"triggerType" : "PUSH"
}, {
"hash" : "9a20519f5838e1a41cf5682735a9a4283b5003d5",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19404",
"triggerID" : "9a20519f5838e1a41cf5682735a9a4283b5003d5",
"triggerType" : "PUSH"
}, {
"hash" : "8613d508a347d7a0a80329b32384a5437dc8d3ae",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19630",
"triggerID" : "8613d508a347d7a0a80329b32384a5437dc8d3ae",
"triggerType" : "PUSH"
}, {
"hash" : "4fa243ae7b809dac330c63462a61959b8f320f07",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19631",
"triggerID" : "4fa243ae7b809dac330c63462a61959b8f320f07",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9a20519f5838e1a41cf5682735a9a4283b5003d5 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19404)
* 8613d508a347d7a0a80329b32384a5437dc8d3ae Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19630)
* 4fa243ae7b809dac330c63462a61959b8f320f07 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19631)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] akalash commented on a change in pull request #16227: [FLINK-23041][streaming] Added new well defined checkpoint configuration aligned-checkpoint-timeout instead of alignment-timeout
Posted by GitBox <gi...@apache.org>.
akalash commented on a change in pull request #16227:
URL: https://github.com/apache/flink/pull/16227#discussion_r659764657
##########
File path: docs/layouts/shortcodes/generated/rest_v1_dispatcher.html
##########
@@ -101,10 +101,10 @@
"type" : "object",
"id" : "urn:jsonschema:org:apache:flink:runtime:rest:messages:DashboardConfiguration:Features",
"properties" : {
- "web-submit" : {
Review comment:
This file is autogenerated but it looks like it is generated in alphabet order so it should be correct now. I can only guess but perhaps, initially, the author made these changes manually
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16227: [FLINK-23041][streaming] Added new well defined checkpoint configuration aligned-checkpoint-timeout instead of alignment-timeout
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16227:
URL: https://github.com/apache/flink/pull/16227#issuecomment-865242134
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a6971ac844ae62b0af49c935f82bd306168b146d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19261",
"triggerID" : "a6971ac844ae62b0af49c935f82bd306168b146d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a6971ac844ae62b0af49c935f82bd306168b146d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19261)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16227: [FLINK-23041][streaming] Added new well defined checkpoint configuration aligned-checkpoint-timeout instead of alignment-timeout
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16227:
URL: https://github.com/apache/flink/pull/16227#issuecomment-865242134
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a6971ac844ae62b0af49c935f82bd306168b146d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19261",
"triggerID" : "a6971ac844ae62b0af49c935f82bd306168b146d",
"triggerType" : "PUSH"
}, {
"hash" : "058af60e4592de5e83d7ba6a4165a169d986f409",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19330",
"triggerID" : "058af60e4592de5e83d7ba6a4165a169d986f409",
"triggerType" : "PUSH"
}, {
"hash" : "ac27568d7b4dcb40ab08da6ad5c8eb4f799d5b12",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19354",
"triggerID" : "ac27568d7b4dcb40ab08da6ad5c8eb4f799d5b12",
"triggerType" : "PUSH"
}, {
"hash" : "757fe7352ef110e3ce9192d92839a435b0ca9498",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19372",
"triggerID" : "757fe7352ef110e3ce9192d92839a435b0ca9498",
"triggerType" : "PUSH"
}, {
"hash" : "9a20519f5838e1a41cf5682735a9a4283b5003d5",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19404",
"triggerID" : "9a20519f5838e1a41cf5682735a9a4283b5003d5",
"triggerType" : "PUSH"
}, {
"hash" : "8613d508a347d7a0a80329b32384a5437dc8d3ae",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8613d508a347d7a0a80329b32384a5437dc8d3ae",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9a20519f5838e1a41cf5682735a9a4283b5003d5 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19404)
* 8613d508a347d7a0a80329b32384a5437dc8d3ae UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on pull request #16227: [FLINK-23041][streaming] Added new well defined checkpoint configuration aligned-checkpoint-timeout instead of alignment-timeout
Posted by GitBox <gi...@apache.org>.
dawidwys commented on pull request #16227:
URL: https://github.com/apache/flink/pull/16227#issuecomment-869694972
Let's just drop the old value. It wasn't properly advertised and I think it doesn't make much sense to document it on that general page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org