[jira] [Commented] (AIRFLOW-317) Avoid exception when reading logs from s3.

["Stefan Seelmann (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16624830#comment-16624830 ] 

Stefan Seelmann commented on AIRFLOW-317:
-----------------------------------------

No longer valid according to https://github.com/apache/incubator-airflow/pull/1656#issuecomment-383647450

> Avoid exception when reading logs from s3.
> ------------------------------------------
>
>                 Key: AIRFLOW-317
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-317
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: aws
>    Affects Versions: 1.7.1.2, 1.7.1.3
>            Reporter: Oleksandr Vilchynskyy
>            Assignee: Oleksandr Vilchynskyy
>            Priority: Minor
>              Labels: patch
>             Fix For: 1.7.1.2, 1.7.1.3
>
>
> There is unneeded decode() method after s3_key.get_contents_as_string(). get_contents_as_string() already returns a string. The problem appears if log file contains non-ascii characters decode() method  will raise Exception and log will not be processed.
> Without decode() method it will work as always, but log decoding will be processed to browser.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)