You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by d2r <gi...@git.apache.org> on 2015/01/14 18:30:30 UTC
[GitHub] storm pull request: [Storm 599] Use use nimbus's cached heartbeats...
GitHub user d2r opened a pull request:
https://github.com/apache/storm/pull/381
[Storm 599] Use use nimbus's cached heartbeats rather than fetching again from ZK, take two
This is a retry of the reverted pull request #356.
In #356, a merge error (we think?) on the branch used for the pull request caused part of the change on one line to go missing.
```Diff
- beats (.executor-beats storm-cluster-state storm-id (:executor->node+port assignment))
+ beats (map-val :heartbeat @(:heartbeats-cache nimbus))
```
The new code should have been:
```Diff
+ beats (map-val :heartbeat (get @(:heartbeats-cache nimbus) storm-id))
```
This caused incorrect retrieval of heartbeats and therefore metrics were not populated as noted by @harshach [here](https://issues.apache.org/jira/browse/STORM-599?focusedCommentId=14275512&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14275512).
Testing again with this branch in a clean environment shows that metrics are updated as expected once per `nimbus.monitor.freq.secs`, which defaults to 10s.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/d2r/storm STORM-599-use-cached-hbs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/381.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #381
----
commit 1d973c6838118e64024505269b82baffd0f41f8d
Author: Derek Dagit <de...@yahoo-inc.com>
Date: 2015-01-14T17:12:30Z
use hb cache instead of fetching via zk
commit fc952d4c64f52e29cd162ffacee984ef36ab9447
Author: Derek Dagit <de...@yahoo-inc.com>
Date: 2015-01-14T17:13:05Z
Remove unnecessary code
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [Storm 599] Use use nimbus's cached heartbeats...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/381#issuecomment-69963830
+1 I manually brought up the topology and it is behaving as expected. The metrics are updated every 10 seconds like clockwork.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [Storm 599] Use use nimbus's cached heartbeats...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/381#issuecomment-70337221
+1. There might be minor issue that metrics gets updated in bulk i.e if I refresh it doesn't reflect the new values immediately it will update after few retries. Before if I want to get latest metrics I can keep refreshing and gets the latest metrics. This is not a big issue I am +1 on merging this in. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [Storm 599] Use use nimbus's cached heartbeats...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/381
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---