Coveralls results

[Aleksandr Mashchenko <am...@apache.org>]

Hello,

Seems that coveralls shows coverage of the PR-s like it is in the master 
branch. Can we do something about that?

Also it reports that "coverage remained the same" for this build [1], 
which adds tests for new files.

Can someone explain that?


[1] https://coveralls.io/builds/16057728

---
Regards,
Aleksandr

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org

Re: Coveralls results

[Lukasz Lenart <lu...@apache.org>]

I think it compares coverage against build on the master branch with a
PR's coverage. I meant, Travis performs build on the master branch and
sends results to Coveralls, then a PR is opened and the same is
performed for the PR. So it might happen that the coverages can vary
because of a starting point for each branch. To have proper results
each time we would run two builds at the same time - on the master
branch and a PR's branch.

2018-03-21 21:30 GMT+01:00 Aleksandr Mashchenko <am...@apache.org>:
> Hello,
>
> Seems that coveralls shows coverage of the PR-s like it is in the master
> branch. Can we do something about that?
>
> Also it reports that "coverage remained the same" for this build [1], which
> adds tests for new files.
>
> Can someone explain that?
>
>
> [1] https://coveralls.io/builds/16057728
>
> ---
> Regards,
> Aleksandr
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org