You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by AntiMoron <gi...@git.apache.org> on 2018/04/10 15:04:58 UTC

[GitHub] incubator-weex pull request #1108: Fix compile problem. 'progressBlock:' not...

GitHub user AntiMoron opened a pull request:

    https://github.com/apache/incubator-weex/pull/1108

    Fix compile problem. 'progressBlock:' not found in the function declaration [-Werror,-Wdocumentation]

    parameter 'progressBlock:' not found in the function declaration [-Werror,-Wdocumentation]
    
     * @param progressBlock: A block called while the download start
              ^~~~~~~~~~~~~~
    
    错别字修改、新 demo、较小的 bugfix、甚至较大的功能都可以直接提到 `master` 分支;


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/AntiMoron/incubator-weex master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/1108.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1108
    
----
commit 060c7b4546f2a8eeea5043802b0937fbad064ec5
Author: AntiMoron <an...@...>
Date:   2018-04-10T15:03:08Z

    Fix compile problem.
    
    parameter 'progressBlock:' not found in the function declaration [-Werror,-Wdocumentation]
    
     * @param progressBlock: A block called while the download start
              ^~~~~~~~~~~~~~

----


---

[GitHub] incubator-weex issue #1108: Fix compile problem. 'progressBlock:' not found ...

Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:

    https://github.com/apache/incubator-weex/pull/1108
  
    
    <!--
      0 failure: 
      1 warning:  No Changelog chan...
      1 messages
      
    -->
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Warnings</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:warning:</td>
          <td>No Changelog changes!</td>
        </tr>
      </tbody>
    </table>
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Messages</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:book:</td>
          <td>danger test finished.</td>
        </tr>
      </tbody>
    </table>
    
    
    <p align="right">
      Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
    </p>



---

[GitHub] incubator-weex pull request #1108: Fix compile problem. 'progressBlock:' not...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-weex/pull/1108


---