You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by danny0405 <gi...@git.apache.org> on 2018/01/03 07:34:35 UTC
[GitHub] storm pull request #2493: [STORM-2879] Supervisor collapse continuously when...
GitHub user danny0405 opened a pull request:
https://github.com/apache/storm/pull/2493
[STORM-2879] Supervisor collapse continuously when there is a expired assignment for overdue storm
We do not make a transaction when supervisor clean up local files for a overdue storm, if an exception occurred during deleting storm-code/ser/jar, an overdue local assignment will be left on disk.
Then when supervisor restart from the exception above, the slots will be initial and container will be recovered from LocalAssignments, the blob store will fetch the files from Nimbus/Master, but will get a KeyNotFoundException, and supervisor collapses again.
So lets just make the current assignment null when we first initial a Slot and recover container from local assignment, let supervisor clean up the local assignment and Nimbus/master will reassign it finally.
This is the JIRA issue [STORM-2879](https://issues.apache.org/jira/browse/STORM-2879).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/danny0405/storm slot-bug-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2493.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2493
----
commit 9655d0dc8c4f01e17edc3ff823cf7446dbc9930e
Author: chenyuzhao <ch...@...>
Date: 2018-01-03T07:31:38Z
fix STORM-2879
----
---
[GitHub] storm issue #2493: [STORM-2879] Supervisor collapse continuously when there ...
Posted by danny0405 <gi...@git.apache.org>.
Github user danny0405 commented on the issue:
https://github.com/apache/storm/pull/2493
@revans2 This is the JIRA issue: https://issues.apache.org/jira/browse/STORM-2879
---
[GitHub] storm issue #2493: [STORM-2879] Supervisor collapse continuously when there ...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2493
@revans2 I just added @danny0405 to contributor list and assigned to the JIRA issue.
@danny0405 Could you please provide a 1.x patch as well? Thanks in advance!
---
[GitHub] storm pull request #2493: [STORM-2879] Supervisor collapse continuously when...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2493
---
[GitHub] storm issue #2493: [STORM-2879] Supervisor collapse continuously when there ...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2493
@danny0405 I merged this into master, but the patch does not apply cleanly to 1.x (Slot.java moved locations)
Could you please provide a 1.x patch as well? Also do you have a JIRA ID that I can assign the JIRA to? Just want to make sure that you get credit for the fix.
---