You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Chris Chabot (JIRA)" <ji...@apache.org> on 2008/06/06 16:09:45 UTC
[jira] Created: (SHINDIG-353) Allow the expansion of the thumbnail
and screenshot module prefs field for internationalization.
Allow the expansion of the thumbnail and screenshot module prefs field for internationalization.
-------------------------------------------------------------------------------------------------
Key: SHINDIG-353
URL: https://issues.apache.org/jira/browse/SHINDIG-353
Project: Shindig
Issue Type: New Feature
Components: Gadget Rendering Server (PHP)
Reporter: Chris Chabot
Perform substitutions of each hangman expansion on all fields which get displayed to users. This currently includes, but is not limited to, the following fields:
a. All Module.ModulePrefs attributes, Module.Content@href, Module.Content, UserPref@display_name, UserPref@default_value, and UserPref.EnumValue@display_value.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-353) Allow the expansion of the thumbnail
and screenshot module prefs field for internationalization.
Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Chabot resolved SHINDIG-353.
----------------------------------
Resolution: Fixed
Assignee: Chris Chabot
I've added user pref substitutions directly into the gadget spec parser.
The big downside is that since translations aren't done 'on the fly' you can't switch languages half way (which doesn't and shouldn't happen in practice, but -could have- worked), however it saves a lot of expensive code of looping through the complex data structures in the gadget, and it also means that anything that was using the user prefs directly (and a few things are) also get the correct displayed values. Since i can't see any real life benefits to the complex approach, and this is a lot simpler and faster, i picked the simpler solution.
Alternative is possible but would require a more pervasive approach, and i think this simpler solution already does exactly what is expected by the spec.
> Allow the expansion of the thumbnail and screenshot module prefs field for internationalization.
> -------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-353
> URL: https://issues.apache.org/jira/browse/SHINDIG-353
> Project: Shindig
> Issue Type: New Feature
> Components: Gadget Rendering Server (PHP)
> Reporter: Chris Chabot
> Assignee: Chris Chabot
>
> Perform substitutions of each hangman expansion on all fields which get displayed to users. This currently includes, but is not limited to, the following fields:
> a. All Module.ModulePrefs attributes, Module.Content@href, Module.Content, UserPref@display_name, UserPref@default_value, and UserPref.EnumValue@display_value.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.