[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #9909: graphics: in smp sched_lock is not enough to prevent preemption

["pkarashchenko (via GitHub)" <gi...@apache.org>]

pkarashchenko commented on code in PR #9909:
URL: https://github.com/apache/nuttx/pull/9909#discussion_r1275245591


##########
graphics/nxterm/nxterm_kbdin.c:
##########
@@ -128,6 +129,7 @@ ssize_t nxterm_read(FAR struct file *filep, FAR char *buffer, size_t len)
            * to wake us up.
            */
 
+          flags = enter_critical_section();

Review Comment:
   From the change description: "in smp sched_lock is not enough to prevent preemption", but I'm missing what is the state of the problem and how the critical section helps here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org