You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2022/11/21 20:04:45 UTC
[GitHub] [logging-log4j2] jvz opened a new pull request, #1144: Structured properties API enhancement proposal
jvz opened a new pull request, #1144:
URL: https://github.com/apache/logging-log4j2/pull/1144
This PR has initial work toward implementing https://cwiki.apache.org/confluence/display/LOGGING/Properties+Enhancement with updates to the property parsing API. This is proposed to replace `PropertiesUtil` in general as the semantics for keys have changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] rgoers commented on pull request #1144: Structured properties API enhancement proposal
Posted by GitBox <gi...@apache.org>.
rgoers commented on PR #1144:
URL: https://github.com/apache/logging-log4j2/pull/1144#issuecomment-1377461284
I am thrilled you are breaking out all the independent changes!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] jvz commented on pull request #1144: Structured properties API enhancement proposal
Posted by GitBox <gi...@apache.org>.
jvz commented on PR #1144:
URL: https://github.com/apache/logging-log4j2/pull/1144#issuecomment-1326737629
The `context` parameter in the new API is the main action for that. Properties of the form `log4j2.*.foo.bar` are filled in with the context name if specified (hence the unit test demos as migrating everything over to this API isn't done yet).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Structured properties API enhancement proposal (logging-log4j2)
Posted by "vy (via GitHub)" <gi...@apache.org>.
vy closed pull request #1144: Structured properties API enhancement proposal
URL: https://github.com/apache/logging-log4j2/pull/1144
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] jvz commented on pull request #1144: Structured properties API enhancement proposal
Posted by GitBox <gi...@apache.org>.
jvz commented on PR #1144:
URL: https://github.com/apache/logging-log4j2/pull/1144#issuecomment-1377643739
I hope you continue to remain thrilled when I submit the next PR as this one changes a bunch of files: LOG4J2-3228. We're removing `Serializable` from a few interfaces which lets us remove a bunch of serialization proxy classes (but not `ThrowableProxy` amusingly enough; that seems to be reused by JSON et al.).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] jvz commented on pull request #1144: Structured properties API enhancement proposal
Posted by GitBox <gi...@apache.org>.
jvz commented on PR #1144:
URL: https://github.com/apache/logging-log4j2/pull/1144#issuecomment-1375993484
I'm going to begin working on breaking out the various entangled changes in this PR into independent changes. A partial list of things to extract to separate commits/PRs:
- [ ] Move `JsonReader` API to log4j-api in the `util` package
- [ ] Automatic spotless apply in build
- [ ] Replace `NullOutputStream` with `OutputStream::nullOutputStream`
- [ ] Remove `Serializable` from `Layout` API (we already tend to use custom interfaces to serializing to bytes)
- [ ] Remove `Serializable` from `LogEvent` API
- [ ] Update `Lazy::relaxed`
- [ ] Move `Recycler` API to log4j-api in `util`
- [ ] Move `AbstractLifeCycle` methods to default methods in `LifeCycle`
- [ ] Update `TriggeringPolicy` to extend `LifeCycle` (marked as a TODO from long ago)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] jvz commented on pull request #1144: Structured properties API enhancement proposal
Posted by GitBox <gi...@apache.org>.
jvz commented on PR #1144:
URL: https://github.com/apache/logging-log4j2/pull/1144#issuecomment-1322606218
Wow, CodeQL is a little paranoid there. Let me see what I can do about that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] jvz commented on pull request #1144: Structured properties API enhancement proposal
Posted by GitBox <gi...@apache.org>.
jvz commented on PR #1144:
URL: https://github.com/apache/logging-log4j2/pull/1144#issuecomment-1369162977
@ppkarwasz I've still got things to fix here, but the general shape of the changes are coming into place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org