[GitHub] [spark] allisonwang-db commented on a diff in pull request #37641: [SPARK-40201][SQL][TESTS] Improve v1 write test coverage

[GitBox <gi...@apache.org>]

allisonwang-db commented on code in PR #37641:
URL: https://github.com/apache/spark/pull/37641#discussion_r982873072


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala:
##########
@@ -177,7 +171,15 @@ object FileFormatWriter extends Logging {
     // 1) When the planned write config is disabled.
     // 2) When the concurrent writers are enabled (in this case the required ordering of a
     //    V1 write command will be empty).
-    if (Utils.isTesting) outputOrderingMatched = orderingMatched
+    if (Utils.isTesting) {
+      if (SQLConf.get.plannedWriteEnabled && !orderingMatched) {

Review Comment:
   I think we also need to check the concurrent writer is not enabled.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org