[GitHub] flink pull request #2071: [FLINK-4018][streaming-connectors] Configurable id...

[rmetzger <gi...@git.apache.org>]

Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2071#discussion_r70059586
  
    --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java ---
    @@ -155,6 +163,15 @@ public void run() {
     					// we can close this consumer thread once we've reached the end of the subscribed shard
     					break;
     				} else {
    +					if (fetchIntervalMillis != 0) {
    --- End diff --
    
    There is no input type validation happening, right?
    So if a user sets a negative sleeping interval, it will probably fail.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---