You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/02 01:04:30 UTC

[GitHub] [flink] dianfu opened a new pull request #19333: [FLINK-26190][python] Remove getTableConfig from ExecNodeConfiguration

dianfu opened a new pull request #19333:
URL: https://github.com/apache/flink/pull/19333


   
   ## What is the purpose of the change
   
   *This pull request tries to remove getTableConfig from ExecNodeConfiguration. It has refactored the PythonConfig and many other places as a result.*
   
   ## Verifying this change
   
   This change is a code refactor work and has already covered by existing tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19333: [FLINK-26190][python] Remove getTableConfig from ExecNodeConfiguration

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19333:
URL: https://github.com/apache/flink/pull/19333#issuecomment-1086447112


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "84ab13731ec4deaa375549d5d63afb2020ccd476",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34138",
       "triggerID" : "84ab13731ec4deaa375549d5d63afb2020ccd476",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0ae998978c02b08d84eb814e3c9fd95b15883f3b",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34141",
       "triggerID" : "0ae998978c02b08d84eb814e3c9fd95b15883f3b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ad73bf1efadc750338dae3344cef633a0ad495d2",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34150",
       "triggerID" : "ad73bf1efadc750338dae3344cef633a0ad495d2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0ae998978c02b08d84eb814e3c9fd95b15883f3b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34141) 
   * ad73bf1efadc750338dae3344cef633a0ad495d2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34150) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19333: [FLINK-26190][python] Remove getTableConfig from ExecNodeConfiguration

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19333:
URL: https://github.com/apache/flink/pull/19333#issuecomment-1086447112


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "84ab13731ec4deaa375549d5d63afb2020ccd476",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34138",
       "triggerID" : "84ab13731ec4deaa375549d5d63afb2020ccd476",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0ae998978c02b08d84eb814e3c9fd95b15883f3b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34141",
       "triggerID" : "0ae998978c02b08d84eb814e3c9fd95b15883f3b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 84ab13731ec4deaa375549d5d63afb2020ccd476 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34138) 
   * 0ae998978c02b08d84eb814e3c9fd95b15883f3b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34141) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19333: [FLINK-26190][python] Remove getTableConfig from ExecNodeConfiguration

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19333:
URL: https://github.com/apache/flink/pull/19333#issuecomment-1086447112


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "84ab13731ec4deaa375549d5d63afb2020ccd476",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34138",
       "triggerID" : "84ab13731ec4deaa375549d5d63afb2020ccd476",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0ae998978c02b08d84eb814e3c9fd95b15883f3b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0ae998978c02b08d84eb814e3c9fd95b15883f3b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 84ab13731ec4deaa375549d5d63afb2020ccd476 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34138) 
   * 0ae998978c02b08d84eb814e3c9fd95b15883f3b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19333: [FLINK-26190][python] Remove getTableConfig from ExecNodeConfiguration

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19333:
URL: https://github.com/apache/flink/pull/19333#issuecomment-1086447112


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "84ab13731ec4deaa375549d5d63afb2020ccd476",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34138",
       "triggerID" : "84ab13731ec4deaa375549d5d63afb2020ccd476",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0ae998978c02b08d84eb814e3c9fd95b15883f3b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34141",
       "triggerID" : "0ae998978c02b08d84eb814e3c9fd95b15883f3b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ad73bf1efadc750338dae3344cef633a0ad495d2",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34150",
       "triggerID" : "ad73bf1efadc750338dae3344cef633a0ad495d2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ad73bf1efadc750338dae3344cef633a0ad495d2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34150) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19333: [FLINK-26190][python] Remove getTableConfig from ExecNodeConfiguration

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19333:
URL: https://github.com/apache/flink/pull/19333#issuecomment-1086447112


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "84ab13731ec4deaa375549d5d63afb2020ccd476",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34138",
       "triggerID" : "84ab13731ec4deaa375549d5d63afb2020ccd476",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0ae998978c02b08d84eb814e3c9fd95b15883f3b",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34141",
       "triggerID" : "0ae998978c02b08d84eb814e3c9fd95b15883f3b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0ae998978c02b08d84eb814e3c9fd95b15883f3b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34141) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19333: [FLINK-26190][python] Remove getTableConfig from ExecNodeConfiguration

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19333:
URL: https://github.com/apache/flink/pull/19333#issuecomment-1086447112


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "84ab13731ec4deaa375549d5d63afb2020ccd476",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34138",
       "triggerID" : "84ab13731ec4deaa375549d5d63afb2020ccd476",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 84ab13731ec4deaa375549d5d63afb2020ccd476 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34138) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #19333: [FLINK-26190][python] Remove getTableConfig from ExecNodeConfiguration

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #19333:
URL: https://github.com/apache/flink/pull/19333#issuecomment-1086447112


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "84ab13731ec4deaa375549d5d63afb2020ccd476",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "84ab13731ec4deaa375549d5d63afb2020ccd476",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 84ab13731ec4deaa375549d5d63afb2020ccd476 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19333: [FLINK-26190][python] Remove getTableConfig from ExecNodeConfiguration

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19333:
URL: https://github.com/apache/flink/pull/19333#issuecomment-1086447112


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "84ab13731ec4deaa375549d5d63afb2020ccd476",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34138",
       "triggerID" : "84ab13731ec4deaa375549d5d63afb2020ccd476",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0ae998978c02b08d84eb814e3c9fd95b15883f3b",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34141",
       "triggerID" : "0ae998978c02b08d84eb814e3c9fd95b15883f3b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ad73bf1efadc750338dae3344cef633a0ad495d2",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ad73bf1efadc750338dae3344cef633a0ad495d2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0ae998978c02b08d84eb814e3c9fd95b15883f3b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=34141) 
   * ad73bf1efadc750338dae3344cef633a0ad495d2 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org